From: <ansuelsmth@gmail.com>
To: "'Viresh Kumar'" <viresh.kumar@linaro.org>
Cc: "'Rob Herring'" <robh+dt@kernel.org>,
"'Viresh Kumar'" <vireshk@kernel.org>,
"'Andy Gross'" <agross@kernel.org>,
"'Bjorn Andersson'" <bjorn.andersson@linaro.org>,
"'Ilia Lin'" <ilia.lin@kernel.org>,
"'Nishanth Menon'" <nm@ti.com>,
"'Stephen Boyd'" <sboyd@kernel.org>,
"'Rafael J. Wysocki'" <rjw@rjwysocki.net>,
"'Sricharan R'" <sricharan@codeaurora.org>,
"'linux-arm-msm'" <linux-arm-msm@vger.kernel.org>,
"'open list:THERMAL'" <linux-pm@vger.kernel.org>,
<devicetree@vger.kernel.org>, <linux-kernel@vger.kernel.org>
Subject: R: R: [PATCH v2 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq
Date: Mon, 27 Apr 2020 12:43:43 +0200 [thread overview]
Message-ID: <016c01d61c80$ba1358b0$2e3a0a10$@gmail.com> (raw)
In-Reply-To: <20200427034951.xrk5ja3pg4anbg4s@vireshk-i7>
> On 25-04-20, 00:19, ansuelsmth@gmail.com wrote:
> > > On Wed, Apr 22, 2020 at 3:12 PM Ansuel Smith
> <ansuelsmth@gmail.com>
> > > wrote:
> > > >
> > > > Update binding to new generic name "operating-points-v2-qcom-cpu"
> > > >
> > > > Fixes: a8811ec764f9 ("cpufreq: qcom: Add support for krait based
> socs")
> > > > Signed-off-by: Ansuel Smith <ansuelsmth@gmail.com>
> > > > ---
> > > > Documentation/devicetree/bindings/opp/qcom-nvmem-cpufreq.txt |
> 2
> > > +-
> > > > 1 file changed, 1 insertion(+), 1 deletion(-)
> > > >
> > > > diff --git a/Documentation/devicetree/bindings/opp/qcom-nvmem-
> > > cpufreq.txt b/Documentation/devicetree/bindings/opp/qcom-nvmem-
> > > cpufreq.txt
> > > > index 64f07417ecfb..537e1774f589 100644
> > > > --- a/Documentation/devicetree/bindings/opp/qcom-nvmem-
> cpufreq.txt
> > > > +++ b/Documentation/devicetree/bindings/opp/qcom-nvmem-
> > > cpufreq.txt
> > > > @@ -19,7 +19,7 @@ In 'cpu' nodes:
> > > >
> > > > In 'operating-points-v2' table:
> > > > - compatible: Should be
> > > > - - 'operating-points-v2-kryo-cpu' for apq8096, msm8996,
> msm8974,
> > > > + - 'operating-points-v2-qcom-cpu' for apq8096, msm8996,
> > > msm8974,
> > > > apq8064, ipq8064,
msm8960 and ipq8074.
> > >
> > > This is not how you fix the backwards compatibility issue pointed out
> > > on the Fixes reference.
> > >
> > > Rob
> >
> > Sorry but can you give some directive? Should I use the old binding and
> change
> > the driver to use it instead of the new one (and drop it) ?
>
> It is not about the name of the binding, you can rename it to whatever
> you want. The kernel needs to keep supporting all the previous
> bindings, so we can keep on changing the kernel but keep the same
> bootloader (with earlier bindings).
>
> --
> viresh
Ok but still I can't understand why this is not right.
In 1/2 of this patchset I added the check for the old binding in the driver
and
here I updated the Documentation with the new one. This way the kernel
should support all the previous bindings and I can use the new better name.
next prev parent reply other threads:[~2020-04-27 10:43 UTC|newest]
Thread overview: 7+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-04-22 20:12 [PATCH v2 1/2] cpufreq: qcom: fix compatibility issue with old binding Ansuel Smith
2020-04-22 20:12 ` [PATCH v2 2/2] dt-bindings: opp: Fix wrong binding in qcom-nvmem-cpufreq Ansuel Smith
2020-04-24 21:48 ` Rob Herring
2020-04-24 22:19 ` R: " ansuelsmth
2020-04-27 3:49 ` Viresh Kumar
2020-04-27 10:43 ` ansuelsmth [this message]
2020-04-27 17:45 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='016c01d61c80$ba1358b0$2e3a0a10$@gmail.com' \
--to=ansuelsmth@gmail.com \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=ilia.lin@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-pm@vger.kernel.org \
--cc=nm@ti.com \
--cc=rjw@rjwysocki.net \
--cc=robh+dt@kernel.org \
--cc=sboyd@kernel.org \
--cc=sricharan@codeaurora.org \
--cc=viresh.kumar@linaro.org \
--cc=vireshk@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).