From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-dy1-f170.google.com (mail-dy1-f170.google.com [74.125.82.170]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 998BA3CCFC3 for ; Thu, 2 Apr 2026 18:47:34 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=74.125.82.170 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775155656; cv=none; b=THqxdG8w7R0sKQl1fCbj1XbI/k+noKKwJUKU2yAzBBbVJdrv7Z2Rxaq3aoYMl007BK47nqHtLcLmjxtCXvkftU+SEzfNSKwRHCkwBYUNK5lSeATZzLqnj3PlbXTI7G3oLpJK8pjcKqH50rYENhclc2dmifHcdF6TI+ZTi6NXYbk= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1775155656; c=relaxed/simple; bh=OVudXei1XMX+Hk0vFE/KI/maetr0rgXz6TaXIWcvCYw=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=N3VtgWBHWAWUMrgUd+YjMhGSne4sdhHyzA8185iuQ0YtQirEdg9X5k+vLWRPJjBNjo928uWobV5hw7W93YpSsoq8vtuF57fOSpXmMLZeY8S8jz2Gkcu+Fs1qg30FzCUbI9fd7F9JUJO+qX3riAqiTQ/bqHU7KiBLGUuy5simfZQ= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com; spf=pass smtp.mailfrom=google.com; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b=owql1B9m; arc=none smtp.client-ip=74.125.82.170 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=reject dis=none) header.from=google.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=google.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=google.com header.i=@google.com header.b="owql1B9m" Received: by mail-dy1-f170.google.com with SMTP id 5a478bee46e88-2c56aa62931so2681592eec.0 for ; Thu, 02 Apr 2026 11:47:34 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=google.com; s=20251104; t=1775155654; x=1775760454; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=MpykImWK6bjT2nlpOYqPcIo7o07mstIYTD+Wq8ULKFw=; b=owql1B9mcaC0eOg4VNCiuhWkg/5iwr+DNvkHZxi74p7vcNh9DPI4i07VvHU+En21OV JAUuKT0JDx6TZuVOtXRpCE/0xDlh2MVYPJrILlRAb3k81bHYVpWhwptxA3ZVwbDuR5VX gy8HWzaysceZNknsMiL2bEF9dTt7vz6FrbuFZhbaZTjgxx69m7YgQi/ARDsBSy/PqAf8 o1EreyeoCam0/B0LrFd3QvOysLr3QcU0hoyPo0mTnfm16nHWic0BNWhXFe8jU/9nDi96 giuIi/h5SowRAI2FEma/5EgETouteSIOZiszBjvyro1Y7U9XLZkD0p4glfnsrjYkRSPC h2Lw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20251104; t=1775155654; x=1775760454; h=content-transfer-encoding:in-reply-to:from:content-language :references:cc:to:subject:user-agent:mime-version:date:message-id :x-gm-gg:x-gm-message-state:from:to:cc:subject:date:message-id :reply-to; bh=MpykImWK6bjT2nlpOYqPcIo7o07mstIYTD+Wq8ULKFw=; b=R+Im/h0u6pTZPZFjrJkdMg+5NH7oJ7SbddcX460a0MNvgI+MlDsI5cwoSpo0rbS3xq 8hm12xe6UDgybODam0K6S4/clbGqmKmmZmGE42uERBzO7kXSMlPpxWQgw08E2EGyb65N szfNH04DTt5lqBKrp7KhgwCAL5F/TMs7vcMO/ZCjNrIcchgux6b9gmRKXGPLPHqngLlZ vczR0qCdNW9vEUYEzKgWg7lyxJToKQ9UnDfPHh71YCkxaOvqHHS6vlTWZluVx8h/xM4i 3p2qQflZLn8YUuEGXDkCfJdaW+q6Y9NsSsVsXLxr1QJwwXOLtK4WujlbXkeGfbXp7sow k1WQ== X-Forwarded-Encrypted: i=1; AJvYcCVmajgMPsRsKOGDk2mbRJO7LPnc7Jdr7Z3dr3j3D3fKvNWEZL1Dg95tDNAkaEKfmEhh/0iHrdWC+Umg@vger.kernel.org X-Gm-Message-State: AOJu0Yy0o+cPvrxZUtQJp404E2fcbAInzAtrARqRBF9EDO+/wMsP4jRW IIl/P8uv2QlmOslp3bkg6Iomy0hdFSS9nXednsHWr8XbvOKOd9AqAyka7LwUnsUdHg== X-Gm-Gg: AeBDiesyDK3++IlxyvpiXM7rFBrFBSdrWX+QSoOK0K4H0wfbtLv+bCa1JmL/O6JkLmq iU0o59vhszeAgDa182/YBUpQdL5SYq3K6uFRSbYq19WNvRPgZ7UwOQkeYROc2H7xKVIBpphZiTX 1ihOfduz2Z0TWtYoEywUQg9bIoy8wRJwbFPsgkO8btmJqWIGrSy2KkcRKKMOw6h47rh5QyCPWNS tQdQy/rS8Ecvdk5c4KnnoKgbZ8PWzIhEU+m49SMuo2DulHDu3So9+rJqkiQXYT3C71P8hUTczta kQ6kZVSZXs6FA70aeEth77Ldc3Jmh/GwtUBFzQPwLP+VEx2AS1okijS34R5r4oCZ/VBbejPNd5Q OY9iC1joXt9lH4yc6V/ppgdwwe30dH1pnFHxD5reAd62VXCg4vtxqc2ryqSCHZeHl+aFtPWIwsT 5xmrqF7M4t8hBO1dePXDQNDItFbcFh5eMQwHZh1K9A1b18F4LaTl7R0ylDe1YZEjZ7ICoQ/0WdI f3L5oODtmQqXTKEKYTnXaJt8Q== X-Received: by 2002:a05:7300:e8a7:b0:2c6:31f0:a025 with SMTP id 5a478bee46e88-2cbfc4623eemr138794eec.27.1775155653050; Thu, 02 Apr 2026 11:47:33 -0700 (PDT) Received: from ?IPV6:2a00:79e0:2e7c:8:2412:bdd2:9fa6:2acc? ([2a00:79e0:2e7c:8:2412:bdd2:9fa6:2acc]) by smtp.gmail.com with ESMTPSA id 5a478bee46e88-2ca7c20b2b1sm3319049eec.18.2026.04.02.11.47.31 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 02 Apr 2026 11:47:32 -0700 (PDT) Message-ID: <017b8552-87e2-4409-ae34-9a3ab7365a68@google.com> Date: Thu, 2 Apr 2026 11:47:30 -0700 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH v10 6/6] usb: typec: tcpm/tcpci_maxim: deprecate WAR for setting charger mode To: Heikki Krogerus Cc: =?UTF-8?Q?Andr=C3=A9_Draszik?= , Lee Jones , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Greg Kroah-Hartman , Jagan Sridharan , Mark Brown , Matti Vaittinen , Andrew Morton , Sebastian Reichel , Peter Griffin , Tudor Ambarus , Alim Akhtar , linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, linux-usb@vger.kernel.org, linux-pm@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, RD Babiera , Kyle Tso References: <20260331-max77759-charger-v10-0-76f59233c369@google.com> <20260331-max77759-charger-v10-6-76f59233c369@google.com> Content-Language: en-US From: Amit Sunil Dhamne In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Hi Heikki, On 4/2/26 7:33 AM, Heikki Krogerus wrote: > Hi Amit, > >> +static int get_vbus_regulator_handle(struct max_tcpci_chip *chip) >> +{ >> + if (IS_ERR_OR_NULL(chip->vbus_reg)) { >> + chip->vbus_reg = devm_regulator_get_exclusive(chip->dev, >> + "vbus"); > Sorry to go back to this, but why can't you just get the regulator in > max_tcpci_probe()? Thanks for calling this out. This was an intentional design decision to break a circular dependency. The charger driver is guaranteed to probe after the TCPC driver due to a power supply dependency (the TCPC is a supplier of power for the Battery Charger). However, the charger driver is also the regulator provider for VBUS out (when Type-C goes into source mode). Because of this, the regulator handle will not be available during the TCPC driver's probe. If we tried to fetch it in max_tcpci_probe() and returned -EPROBE_DEFER, it would create a probe deadlock, as the charger would then never probe. Therefore, I made the decision to get the regulator handle lazily and on-demand. Thanks, Amit > > thanks, > >> + if (IS_ERR_OR_NULL(chip->vbus_reg)) { >> + dev_err(chip->dev, >> + "Failed to get vbus regulator handle\n"); >> + return -ENODEV; >> + } >> + } >> + >> + return 0; >> +}