From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yang Xiwen <forbidden405@outlook.com>,
Yisen Zhuang <yisen.zhuang@huawei.com>,
Salil Mehta <salil.mehta@huawei.com>,
"David S. Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Conor Dooley <conor+dt@kernel.org>,
Yang Xiwen <forbidden405@foxmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Russell King <linux@armlinux.org.uk>
Cc: netdev@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org
Subject: Re: [PATCH 4/6] dt-bindings: net: add hisilicon-femac
Date: Fri, 16 Feb 2024 10:41:45 +0100 [thread overview]
Message-ID: <018144fb-0736-4aff-9622-238f8a98f4e3@linaro.org> (raw)
In-Reply-To: <SEZPR06MB695956C782A434A63501CF89964C2@SEZPR06MB6959.apcprd06.prod.outlook.com>
On 16/02/2024 10:36, Yang Xiwen wrote:
>>
>>> + maxItems: 2
>>> +
>>> + reset-names:
>>> + items:
>>> + - const: mac
>>> + - const: phy
>>> +
>>> + hisilicon,phy-reset-delays-us:
>>> + minItems: 3
>>> + maxItems: 3
>>> + description: |
>>> + The 1st cell is reset pre-delay in micro seconds.
>>> + The 2nd cell is reset pulse in micro seconds.
>>> + The 3rd cell is reset post-delay in micro seconds.
>> items:
>> - description:
>>
>> Anyway, isn't this property of the phy?
> It ought to be. But it seems a bit hard to implement it like this.
Why? You have phy node, so phy should know what to do.
Best regards,
Krzysztof
next prev parent reply other threads:[~2024-02-16 9:41 UTC|newest]
Thread overview: 40+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-02-15 23:48 [PATCH 0/6] net: hisi-femac: add support for Hi3798MV200, remove unmaintained compatibles Yang Xiwen via B4 Relay
2024-02-15 23:48 ` [PATCH 1/6] net: hisilicon: add support for hisi_femac core on Hi3798MV200 Yang Xiwen via B4 Relay
2024-02-15 23:57 ` Andrew Lunn
2024-02-15 23:59 ` Yang Xiwen
2024-02-16 13:49 ` Andrew Lunn
2024-02-16 13:58 ` Yang Xiwen
2024-02-16 13:23 ` Andrew Lunn
2024-02-16 13:41 ` Yang Xiwen
2024-02-16 13:58 ` Andrew Lunn
2024-02-16 14:08 ` Yang Xiwen
2024-02-26 9:13 ` Dan Carpenter
2024-02-15 23:48 ` [PATCH 2/6] net: hisi_femac: remove unused compatible strings Yang Xiwen via B4 Relay
2024-02-16 7:20 ` Krzysztof Kozlowski
2024-02-16 8:21 ` Yang Xiwen
2024-02-16 8:26 ` Krzysztof Kozlowski
2024-02-16 8:39 ` Yang Xiwen
2024-02-16 13:01 ` Andrew Lunn
2024-02-16 20:05 ` Conor Dooley
2024-02-16 20:09 ` Yang Xiwen
2024-02-15 23:48 ` [PATCH 3/6] dt-bindings: net: remove outdated hisilicon-femac Yang Xiwen via B4 Relay
2024-02-16 7:21 ` Krzysztof Kozlowski
2024-02-16 8:03 ` Yang Xiwen
2024-02-16 8:23 ` Krzysztof Kozlowski
2024-02-15 23:48 ` [PATCH 4/6] dt-bindings: net: add hisilicon-femac Yang Xiwen via B4 Relay
2024-02-16 0:06 ` Andrew Lunn
2024-02-16 0:20 ` Yang Xiwen
2024-02-16 2:09 ` Rob Herring
2024-02-16 6:30 ` Yang Xiwen
2024-02-16 7:20 ` Krzysztof Kozlowski
2024-02-16 7:24 ` Krzysztof Kozlowski
2024-02-16 9:36 ` Yang Xiwen
2024-02-16 9:41 ` Krzysztof Kozlowski [this message]
2024-02-16 9:48 ` Yang Xiwen
2024-02-16 13:11 ` Andrew Lunn
2024-02-16 13:33 ` Yang Xiwen
2024-02-16 14:10 ` Andrew Lunn
2024-02-16 14:29 ` Yang Xiwen
2024-02-15 23:48 ` [PATCH 5/6] net: mdio: hisi-femac: make clock optional Yang Xiwen via B4 Relay
2024-02-15 23:48 ` [PATCH 6/6] dt-bindings: net: hisilicon-femac-mdio: " Yang Xiwen via B4 Relay
2024-02-16 7:25 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=018144fb-0736-4aff-9622-238f8a98f4e3@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=forbidden405@foxmail.com \
--cc=forbidden405@outlook.com \
--cc=hkallweit1@gmail.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux@armlinux.org.uk \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=robh+dt@kernel.org \
--cc=salil.mehta@huawei.com \
--cc=yisen.zhuang@huawei.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).