From mboxrd@z Thu Jan 1 00:00:00 1970 From: Jonathan Cameron Subject: Re: [RFC 3/4] dt-bindings: iio: add support for GPIO triggers Date: Sat, 18 Feb 2017 19:22:35 +0000 Message-ID: <01819bd3-3d24-b1fc-04aa-52348ff7f3bf@kernel.org> References: <1487347429-31761-1-git-send-email-fabrice.gasnier@st.com> <1487347429-31761-4-git-send-email-fabrice.gasnier@st.com> Mime-Version: 1.0 Content-Type: text/plain; charset=windows-1252 Content-Transfer-Encoding: 7bit Return-path: In-Reply-To: <1487347429-31761-4-git-send-email-fabrice.gasnier-qxv4g6HH51o@public.gmane.org> Sender: linux-iio-owner-u79uwXL29TY76Z2rM5mHXA@public.gmane.org To: Fabrice Gasnier , linux-I+IVW8TIWO2tmTQ+vhA3Yw@public.gmane.org, robh+dt-DgEjT+Ai2ygdnm+yROfE0A@public.gmane.org, linux-arm-kernel-IAPFreCvJWM7uuMidbF8XUB+6BGkLq7r@public.gmane.org, devicetree-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, linux-kernel-u79uwXL29TY76Z2rM5mHXA@public.gmane.org Cc: linux-iio-u79uwXL29TY76Z2rM5mHXA@public.gmane.org, mark.rutland-5wv7dgnIgG8@public.gmane.org, mcoquelin.stm32-Re5JQEeQqe8AvxtiuMwx3w@public.gmane.org, alexandre.torgue-qxv4g6HH51o@public.gmane.org, lars-Qo5EllUWu/uELgA04lAiVw@public.gmane.org, knaack.h-Mmb7MZpHnFY@public.gmane.org, pmeerw-jW+XmwGofnusTnJN9+BGXg@public.gmane.org, benjamin.gaignard-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org, benjamin.gaignard-qxv4g6HH51o@public.gmane.org, linus.walleij-QSEj5FYQhm4dnm+yROfE0A@public.gmane.org List-Id: devicetree@vger.kernel.org On 17/02/17 16:03, Fabrice Gasnier wrote: > Document Industrial I/O GPIO trigger support. > > Signed-off-by: Fabrice Gasnier Whilst I think this needs redoing for the interrupt trigger driver, please be aware that bindings must be OS agnostic i.e. you can't name things after linux specific subsystem. We get a lot of stick for the iio-hwmon bindings specifically for doing this! Which makes this 'interesting' to describe. Once we have it updated feedback from Rob and Mark will definitely be needed on this one. Jonathan > --- > .../bindings/iio/trigger/iio-trig-gpio.txt | 26 ++++++++++++++++++++++ > 1 file changed, 26 insertions(+) > create mode 100644 Documentation/devicetree/bindings/iio/trigger/iio-trig-gpio.txt > > diff --git a/Documentation/devicetree/bindings/iio/trigger/iio-trig-gpio.txt b/Documentation/devicetree/bindings/iio/trigger/iio-trig-gpio.txt > new file mode 100644 > index 0000000..a8dbf5c > --- /dev/null > +++ b/Documentation/devicetree/bindings/iio/trigger/iio-trig-gpio.txt > @@ -0,0 +1,26 @@ > +Industrial I/O - GPIO based trigger > + > +GPIOs may be used as IIO trigger provider, when trigger is connected to > +GPIO lines. > + > +Required properties: > +- compatible: Should be "iio-gpio-trigger" > +- gpios: Should specify one GPIO line used as trigger source. > + See Documentation/devicetree/bindings/gpio/gpio.txt > +- #io-trigger-cells: Should be 0, as simple trigger provider. > + See Documentation/devicetree/bindings/iio/iio-bindings.txt > + > +Optional properties: > +- label: String to specifiy trigger name. > +- gpio-trigger-rising-edge: A rising edge on GPIO will trigger. > +- gpio-trigger-falling-edge: A falling edge on GPIO will trigger. > + Note: Both rising and falling edge may be used. In case none of > + rising or falling edge is selected, rising edge is selected by > + default. > + > +Example: > + gpiotrig0: iio-gpio-trigger0 { > + #io-trigger-cells = <0>; > + compatible = "iio-gpio-trigger"; > + gpios = <&gpioa 11 0>; > + } >