From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id BBA04C54EE9 for ; Thu, 22 Sep 2022 11:44:39 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231753AbiIVLoi (ORCPT ); Thu, 22 Sep 2022 07:44:38 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:45512 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S231768AbiIVLnk (ORCPT ); Thu, 22 Sep 2022 07:43:40 -0400 Received: from mail-lf1-x12a.google.com (mail-lf1-x12a.google.com [IPv6:2a00:1450:4864:20::12a]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6B7079B846 for ; Thu, 22 Sep 2022 04:43:23 -0700 (PDT) Received: by mail-lf1-x12a.google.com with SMTP id j16so14229506lfg.1 for ; Thu, 22 Sep 2022 04:43:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date; bh=1lx7xaWN/VMT8/i11YzeCiwWdLaukKExWKWlWB5fc9Q=; b=Q1uZ08uW8GXrVjelhj6kNsxoS7+Tru8zfZNaf32otIOdeavcgrNWUq202SV4j99Ce2 oxI9WGirhH/Wm3M6waJTC4RfaHwnOm0mOnIfRTJYsDGyr/SLUZRPz5xMb+b9IiW6PT91 vAxuX1hLXb62hrN6uYe52WCR2hUPOCHSdJpx1mDbzOCpHdm1G4l9nKRMOqh7ykgFdfkG BJACWbDBbpdZo2F2JIvE24LBIAvQr6H+jUxv37rw8JLawmb3I592Ra/wC/EH8W0iraju qHf/mHh63xpRVfckZ5UbWnyoPEnmgkgcTHCP1R0PJsc59LQwA9rQS0GNlPy7rJbcZXqQ sDvQ== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date; bh=1lx7xaWN/VMT8/i11YzeCiwWdLaukKExWKWlWB5fc9Q=; b=E2I7oLuRNM+f6Opt9o96hbyR8BNFuJDwPeBc5AIdzCgos6LX0+00WZAVWDCYVzBi6+ ml7oH1rlG+YylSlNdWbpuh8euz3SqxhWpiHEUmSLA+Y75KhFQnQ0fIAIfGP6CCciYnc6 BdakkqnGdDgtZRtrFUFT7ZBkRmNlwkf/lv3U31FSCvARM4Qyu6gLQBTPqr3WcpjQdxCS QXHM96VpnNYTB8qufHEYUEaA6ZDUs1DnygtyEFHdf+0fF2CFqQfnBYIzlEPi6aPvnFK6 YIwNB6FJ0dtLsZZXHCx9apNCNzsMV58avqXyZUxJ7whJoFMrsFRhANnSXW/tX2SY0pdx 1d+Q== X-Gm-Message-State: ACrzQf2Bc2l1cUQGX4PlEIJ1UeXTa1hMSNPInFND73VUn7lMn5raq20d X91RVnbMgGzZzfQoqXn0I81szA== X-Google-Smtp-Source: AMsMyM46dIlSnT/FPiZ4S2E2DFV1GZWwJCBpSvCVWpvp9jDqnOzHv2fDk5DIuwCTyqM/D5NNOBSN9w== X-Received: by 2002:a05:6512:3295:b0:497:a156:795a with SMTP id p21-20020a056512329500b00497a156795amr998895lfe.345.1663847001671; Thu, 22 Sep 2022 04:43:21 -0700 (PDT) Received: from [192.168.0.21] (78-11-189-27.static.ip.netia.com.pl. [78.11.189.27]) by smtp.gmail.com with ESMTPSA id b20-20020a05651c033400b00261ccf566e3sm848937ljp.65.2022.09.22.04.43.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 22 Sep 2022 04:43:21 -0700 (PDT) Message-ID: <01baf27b-8257-aa08-d61f-a427c5056715@linaro.org> Date: Thu, 22 Sep 2022 13:43:20 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.2.2 Subject: Re: [PATCH v7 05/12] dt-bindings: display/msm: move common MDSS properties to mdss-common.yaml Content-Language: en-US To: Dmitry Baryshkov Cc: Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski , Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20220915133742.115218-1-dmitry.baryshkov@linaro.org> <20220915133742.115218-6-dmitry.baryshkov@linaro.org> <84c599c7-421a-78ed-b33e-ce1a4bd4356e@linaro.org> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 22/09/2022 09:53, Dmitry Baryshkov wrote: > On Thu, 22 Sept 2022 at 10:05, Krzysztof Kozlowski > wrote: >> >> On 15/09/2022 15:37, Dmitry Baryshkov wrote: >>> Move properties common to all MDSS DT nodes to the mdss-common.yaml. >>> >>> This extends qcom,msm8998-mdss schema to allow interconnect nodes, which >>> will be added later, once msm8998 gains interconnect support. >>> >>> Signed-off-by: Dmitry Baryshkov >>> --- >>> .../bindings/display/msm/dpu-msm8998.yaml | 41 +-------- >>> .../bindings/display/msm/dpu-qcm2290.yaml | 51 ++---------- >>> .../bindings/display/msm/dpu-sc7180.yaml | 50 ++--------- >>> .../bindings/display/msm/dpu-sc7280.yaml | 50 ++--------- >>> .../bindings/display/msm/dpu-sdm845.yaml | 54 ++---------- >>> .../bindings/display/msm/mdss-common.yaml | 83 +++++++++++++++++++ >>> 6 files changed, 111 insertions(+), 218 deletions(-) >>> create mode 100644 Documentation/devicetree/bindings/display/msm/mdss-common.yaml >>> >>> diff --git a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml >>> index 200eeace1c71..67791dbc3b5d 100644 >>> --- a/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml >>> +++ b/Documentation/devicetree/bindings/display/msm/dpu-msm8998.yaml >>> @@ -14,20 +14,13 @@ description: | >>> sub-blocks like DPU display controller, DSI and DP interfaces etc. Device tree >>> bindings of MDSS and DPU are mentioned for MSM8998 target. >>> >> >> missing allOf > > Rob asked to remove this while reviewing v6 ([1]). And indeed the > allOf's around a single $ref do not seem to be necessary He commented on one of properties, not top-level, maybe it is different case for dtschema. In the past it was required, so are you sure something changed in dtschema? Best regards, Krzysztof