From: Philipp Zabel <p.zabel@pengutronix.de>
To: Rob Herring <robh@kernel.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>
Cc: devicetree@vger.kernel.org,
Linux Media Mailing List <linux-media@vger.kernel.org>
Subject: Re: [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties'
Date: Tue, 17 Nov 2020 15:07:24 +0100 [thread overview]
Message-ID: <01cdd884e890f337a315362008cba05b10525b54.camel@pengutronix.de> (raw)
In-Reply-To: <CAL_Jsq+L4TOYWLgk=_xihtw_Jxfjigbn=h3J0LLXiPrMy0gjMA@mail.gmail.com>
On Tue, 2020-11-17 at 07:48 -0600, Rob Herring wrote:
> On Thu, Nov 12, 2020 at 4:49 PM Rob Herring <robh@kernel.org> wrote:
> > 'additionalProperties' is now required by the meta-schema. Add it for
> > coda.
> >
> > Cc: Philipp Zabel <p.zabel@pengutronix.de>
> > Cc: Mauro Carvalho Chehab <mchehab@kernel.org>
> > Cc: linux-media@vger.kernel.org
> > Signed-off-by: Rob Herring <robh@kernel.org>
> > ---
> > Documentation/devicetree/bindings/media/coda.yaml | 2 ++
> > 1 file changed, 2 insertions(+)
>
> I missed an error this introduces:
>
> /home/rob/proj/git/linux-dt/.build-arm/Documentation/devicetree/bindings/media/coda.example.dt.yaml:
> video-codec@63ff4000: 'interrupts' does not match any of the regexes:
> 'pinctrl-[0-9]+'
> From schema:
> /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/media/coda.yaml
Right, because interrupts are only specified conditionally:
allOf:
- if:
properties:
compatible:
contains:
const: cnm,coda960
then:
properties:
interrupts:
items:
- description: BIT processor interrupt
- description: JPEG unit interrupt
interrupt-names:
items:
- const: bit
- const: jpeg
else:
properties:
interrupts:
items:
- description: BIT processor interrupt
What is the proper way to fix this?
regards
Philipp
prev parent reply other threads:[~2020-11-17 14:08 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-11-12 22:49 [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties' Rob Herring
2020-11-13 9:03 ` Philipp Zabel
2020-11-17 13:48 ` Rob Herring
2020-11-17 14:07 ` Philipp Zabel [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01cdd884e890f337a315362008cba05b10525b54.camel@pengutronix.de \
--to=p.zabel@pengutronix.de \
--cc=devicetree@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).