From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-6.7 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,MAILING_LIST_MULTI,SIGNED_OFF_BY,SPF_HELO_NONE, SPF_PASS,URIBL_BLOCKED autolearn=no autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 94762C64E7D for ; Tue, 17 Nov 2020 14:08:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 550302083E for ; Tue, 17 Nov 2020 14:08:29 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S2387564AbgKQOH3 convert rfc822-to-8bit (ORCPT ); Tue, 17 Nov 2020 09:07:29 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38326 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1729706AbgKQOH3 (ORCPT ); Tue, 17 Nov 2020 09:07:29 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 19D98C0613CF for ; Tue, 17 Nov 2020 06:07:29 -0800 (PST) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1kf1dl-00022x-4X; Tue, 17 Nov 2020 15:07:25 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1kf1dk-00072q-SF; Tue, 17 Nov 2020 15:07:24 +0100 Message-ID: <01cdd884e890f337a315362008cba05b10525b54.camel@pengutronix.de> Subject: Re: [PATCH] media: dt-bindings: coda: Add missing 'additionalProperties' From: Philipp Zabel To: Rob Herring , Mauro Carvalho Chehab Cc: devicetree@vger.kernel.org, Linux Media Mailing List Date: Tue, 17 Nov 2020 15:07:24 +0100 In-Reply-To: References: <20201112224917.165544-1-robh@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Tue, 2020-11-17 at 07:48 -0600, Rob Herring wrote: > On Thu, Nov 12, 2020 at 4:49 PM Rob Herring wrote: > > 'additionalProperties' is now required by the meta-schema. Add it for > > coda. > > > > Cc: Philipp Zabel > > Cc: Mauro Carvalho Chehab > > Cc: linux-media@vger.kernel.org > > Signed-off-by: Rob Herring > > --- > > Documentation/devicetree/bindings/media/coda.yaml | 2 ++ > > 1 file changed, 2 insertions(+) > > I missed an error this introduces: > > /home/rob/proj/git/linux-dt/.build-arm/Documentation/devicetree/bindings/media/coda.example.dt.yaml: > video-codec@63ff4000: 'interrupts' does not match any of the regexes: > 'pinctrl-[0-9]+' > From schema: > /home/rob/proj/git/linux-dt/Documentation/devicetree/bindings/media/coda.yaml Right, because interrupts are only specified conditionally: allOf: - if: properties: compatible: contains: const: cnm,coda960 then: properties: interrupts: items: - description: BIT processor interrupt - description: JPEG unit interrupt interrupt-names: items: - const: bit - const: jpeg else: properties: interrupts: items: - description: BIT processor interrupt What is the proper way to fix this? regards Philipp