From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail.manjaro.org (mail.manjaro.org [116.203.91.91]) (using TLSv1.2 with cipher DHE-RSA-AES256-GCM-SHA384 (256/256 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 8B6B9323B for ; Fri, 22 Dec 2023 00:54:31 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=quarantine dis=none) header.from=manjaro.org Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=manjaro.org Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=manjaro.org header.i=@manjaro.org header.b="qan48CME" Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=manjaro.org; s=2021; t=1703206461; h=from:from:reply-to:subject:subject:date:date:message-id:message-id: to:to:cc:cc:mime-version:mime-version:content-type:content-type: content-transfer-encoding:content-transfer-encoding: in-reply-to:in-reply-to:references:references; bh=NuBTa6nyail/zrqKK8lmrh3dQC8JpRI3oXn+zqmkFdA=; b=qan48CMEEPn+FcDuKOFbnK++xGU8vvV6cGonQdO52v4BGeWCgDYpLAhJ3cfF8BUJ4MSTFj YNpLu1GoEydg6cwy+h/q2Jn9+uiYo38rOOGlN1/gZiVbalhYz5MyWSicJAxpvbzF/yTsWv 8g61d9Rm23q8gLotqH3Pn/Va5EzY12DovZ+Nx9qVhlIHiK2MiWZR4CYo5q/ovoO/lk7xPT 7fmYNswdzdOM6pO3vP0keypNq3LxaWhfIwrA1I0FYMVzQM4XD/5wC9zj3cYhz5Py4CRWLB v39UtLWkDX39qnoOEuhDPLHT67L3cJM8AQshh+5SwxDIB/uXSWNekZTCug9M3w== Date: Fri, 22 Dec 2023 01:54:21 +0100 From: Dragan Simic To: Shantur Rathore Cc: heiko@sntech.de, linux-rockchip@lists.infradead.org, devicetree@vger.kernel.org Subject: Re: [PATCH v1] dts: rockpro64: Remove usb regulator-always-on In-Reply-To: References: <20231209232109.348999-1-i@shantur.com> <20231209233536.350876-1-i@shantur.com> <43339adb6f98a0b4e59db78f932df0d4@manjaro.org> Message-ID: <01d17a353a1fd8e8f9d19abce3f89393@manjaro.org> X-Sender: dsimic@manjaro.org Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Authentication-Results: ORIGINATING; auth=pass smtp.auth=dsimic@manjaro.org smtp.mailfrom=dsimic@manjaro.org On 2023-12-21 11:11, Shantur Rathore wrote: > On Thu, Dec 14, 2023 at 2:35 PM Dragan Simic > wrote: >> On 2023-12-14 15:24, Shantur Rathore wrote: >> > On Sun, Dec 10, 2023 at 12:08 AM Dragan Simic >> > wrote: >> >> On 2023-12-10 01:03, Shantur Rathore wrote: >> >> > On Sat, Dec 9, 2023 at 11:43 PM Dragan Simic >> >> > wrote: >> >> >> On 2023-12-10 00:35, Shantur Rathore wrote: >> >> >> > USB port regulators should be controlled by PHYs >> >> >> > so we remove always-on property and let PHYs manage the >> >> >> > regulator. >> >> >> > >> >> >> > Typec port has misconfugred phy-supply and now that we are >> >> >> > removing regulator-always-on, we need to fix the phy-supply >> >> >> > so the PHYs are able to turn power to type-c port. >> >> >> > >> >> >> > Signed-off-by: Shantur Rathore >> >> >> > --- >> >> >> > + devicetree >> >> >> > >> >> >> > After this patch the ports were confirmed to power up and down >> >> >> > in u-boot when doing usb start and usb stop. >> >> >> > At boot the regulators were off, the devices connected weren't >> >> >> > powered up, on usb start the PHYs are able to power on the ports >> >> >> > and on usb stop they were powered down. >> >> >> > >> >> >> > At the boot, the ports were powered down which was again powered >> >> >> > up by Linux kernel when booting up. >> >> >> > >> >> >> > >> >> >> > arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi | 4 +--- >> >> >> > 1 file changed, 1 insertion(+), 3 deletions(-) >> >> >> > >> >> >> > diff --git a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi >> >> >> > b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi >> >> >> > index bca2b50e0a..bd2824aa48 100644 >> >> >> > --- a/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi >> >> >> > +++ b/arch/arm64/boot/dts/rockchip/rk3399-rockpro64.dtsi >> >> >> > @@ -192,7 +192,6 @@ vcc5v0_host: vcc5v0-host-regulator { >> >> >> > pinctrl-names = "default"; >> >> >> > pinctrl-0 = <&vcc5v0_host_en>; >> >> >> > regulator-name = "vcc5v0_host"; >> >> >> > - regulator-always-on; >> >> >> > vin-supply = <&vcc5v0_usb>; >> >> >> > }; >> >> >> > >> >> >> > @@ -203,7 +202,6 @@ vcc5v0_typec: vcc5v0-typec-regulator { >> >> >> > pinctrl-names = "default"; >> >> >> > pinctrl-0 = <&vcc5v0_typec_en>; >> >> >> > regulator-name = "vcc5v0_typec"; >> >> >> > - regulator-always-on; >> >> >> > vin-supply = <&vcc5v0_usb>; >> >> >> > }; >> >> >> > >> >> >> > @@ -863,7 +861,7 @@ u2phy0_otg: otg-port { >> >> >> > }; >> >> >> > >> >> >> > u2phy0_host: host-port { >> >> >> > - phy-supply = <&vcc5v0_host>; >> >> >> > + phy-supply = <&vcc5v0_typec>; >> >> >> > status = "okay"; >> >> >> > }; >> >> >> > }; >> >> >> >> >> >> Quite frankly, something doesn't feel right there. Would you mind, >> >> >> please, to place this patch on hold until next week or so, at which >> >> >> point I should have enough time to go through the RockPro64 schematic >> >> >> thoroughly once again, and test the patch in detail? >> >> > >> >> > Sure, no worries. >> >> >> >> Great, thanks. >> >> >> >> > Would you mind letting me know which part doesn't feel right to you? >> >> >> >> Sure, it was about the last change in the patch. >> > >> > The TypeC port VBUS is VBUS_TYPEC on Page 20 of 33 marked for >> > VBUS_[1-4] in schematic here - [0] >> > >> > [0] - https://files.pine64.org/doc/rockpro64/rockpro64_v21-SCH.pdf >> >> I see, thanks, and I already went once again through the RockPro64 >> schematic, but only briefly. I need to do that again, but in detail, >> and compare it thoroughly with the dts(i). > > Ping. Pong. :) I haven't fogotten about this, but I simply haven't had enough time yet, and I really want to have this checked and cleaned up. I'm sorry for the delay.