From: Pierre-Louis Bossart <pierre-louis.bossart@linux.intel.com>
To: "Clément Péron" <peron.clem@gmail.com>,
"Maxime Ripard" <mripard@kernel.org>,
"Chen-Yu Tsai" <wens@csie.org>,
"Rob Herring" <robh+dt@kernel.org>,
"Mark Brown" <broonie@kernel.org>,
"Liam Girdwood" <lgirdwood@gmail.com>
Cc: devicetree@vger.kernel.org,
Jernej Skrabec <jernej.skrabec@siol.net>,
alsa-devel@alsa-project.org, Samuel Holland <samuel@sholland.org>,
linux-kernel@vger.kernel.org, Takashi Iwai <tiwai@suse.com>,
Marcus Cooper <codekipper@gmail.com>,
linux-sunxi@googlegroups.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH v9 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params
Date: Tue, 27 Oct 2020 13:58:02 -0500 [thread overview]
Message-ID: <01e34ad3-c695-c6eb-95dd-76c2cda77c6f@linux.intel.com> (raw)
In-Reply-To: <20201027183149.145165-2-peron.clem@gmail.com>
> @@ -452,11 +454,11 @@ static int sun8i_i2s_set_chan_cfg(const struct sun4i_i2s *i2s,
> case SND_SOC_DAIFMT_DSP_B:
> case SND_SOC_DAIFMT_LEFT_J:
> case SND_SOC_DAIFMT_RIGHT_J:
> - lrck_period = params_physical_width(params) * slots;
> + lrck_period = slot_width * slots;
> break;
>
> case SND_SOC_DAIFMT_I2S:
> - lrck_period = params_physical_width(params);
> + lrck_period = slot_width;
> break;
Aren't I2S, LEFT_J and RIGHT_J pretty much the same in terms of lrclk
rate/period? the only thing that can change is the polarity, no?
Not sure why it's handled differently here?
next prev parent reply other threads:[~2020-10-27 18:59 UTC|newest]
Thread overview: 20+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-10-27 18:31 [PATCH v9 00/14] Add Allwinner H3/H5/H6/A64 HDMI audio Clément Péron
2020-10-27 18:31 ` [PATCH v9 01/14] ASoC: sun4i-i2s: Change set_chan_cfg() params Clément Péron
2020-10-27 18:58 ` Pierre-Louis Bossart [this message]
2020-10-27 21:43 ` Clément Péron
2020-10-30 1:20 ` Samuel Holland
2020-10-30 12:58 ` Clément Péron
2020-10-27 18:31 ` [PATCH v9 02/14] ASoC: sun4i-i2s: Add support for H6 I2S Clément Péron
2020-10-27 18:31 ` [PATCH v9 03/14] ASoC: sun4i-i2s: Change get_sr() and get_wss() to be more explicit Clément Péron
2020-10-27 18:31 ` [PATCH v9 04/14] ASoC: sun4i-i2s: Set sign extend sample Clément Péron
2020-10-27 18:31 ` [PATCH v9 05/14] ASoc: sun4i-i2s: Add 20 and 24 bit support Clément Péron
2020-10-27 18:31 ` [PATCH v9 06/14] ASoC: sun4i-i2s: Fix sun8i volatile regs Clément Péron
2020-10-27 18:31 ` [PATCH v9 07/14] ASoC: sun4i-i2s: Fix setting of FIFO modes Clément Péron
2020-10-27 18:31 ` [PATCH v9 08/14] ASoC: sun4i-i2s: fix coding-style for callback definition Clément Péron
2020-10-27 18:31 ` [PATCH v9 09/14] dt-bindings: ASoC: sun4i-i2s: Add H6 compatible Clément Péron
2020-10-27 18:31 ` [PATCH v9 10/14] arm64: dts: allwinner: h6: Add I2S1 node Clément Péron
2020-10-27 18:31 ` [PATCH v9 11/14] arm64: dts: allwinner: a64: Add I2S2 node Clément Péron
2020-10-27 18:31 ` [PATCH v9 12/14] arm64: defconfig: Enable Allwinner i2s driver Clément Péron
2020-10-28 10:18 ` [linux-sunxi] " Chen-Yu Tsai
2020-10-27 18:31 ` [PATCH v9 13/14] dt-bindings: sound: sun4i-i2s: Document H3 with missing RX channel possibility Clément Péron
2020-10-27 18:31 ` [PATCH v9 14/14] arm: dts: sunxi: h3/h5: Add I2S2 node Clément Péron
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=01e34ad3-c695-c6eb-95dd-76c2cda77c6f@linux.intel.com \
--to=pierre-louis.bossart@linux.intel.com \
--cc=alsa-devel@alsa-project.org \
--cc=broonie@kernel.org \
--cc=codekipper@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=jernej.skrabec@siol.net \
--cc=lgirdwood@gmail.com \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-sunxi@googlegroups.com \
--cc=mripard@kernel.org \
--cc=peron.clem@gmail.com \
--cc=robh+dt@kernel.org \
--cc=samuel@sholland.org \
--cc=tiwai@suse.com \
--cc=wens@csie.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).