Re: [PATCH 3/3] arm64: dts: qcom: qcs6490-rb3gen2: describe secondary USB port

[Konrad Dybcio <konradybcio@kernel.org>]

On 4.09.2024 1:16 PM, Caleb Connolly wrote:
> The secondary USB controller on the rb3gen2 is routed directly to a
> mico-USB port where it can be used for EUD debugging or in OTG mode.
> 
> Configure the controller to prefer peripheral mode (as this is almost
> always more useful) and describe the connector, vbus supply, and ID pin.
> 
> OTG/Host mode is untested as I don't have micro-USB OTG cables to hand.
> 
> Signed-off-by: Caleb Connolly <caleb.connolly@linaro.org>
> ---
>  arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts | 69 ++++++++++++++++++++++++++++
>  1 file changed, 69 insertions(+)
> 
> diff --git a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> index 513d5265bb13..fe66f589cb5b 100644
> --- a/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> +++ b/arch/arm64/boot/dts/qcom/qcs6490-rb3gen2.dts
> @@ -62,8 +62,30 @@ hdmi_con: endpoint {
>  			};
>  		};
>  	};
>  
> +	connector-usb2 {
> +		compatible = "gpio-usb-b-connector";
> +		vbus-gpio = <&pm7325_gpios 9 GPIO_ACTIVE_HIGH>;
> +		id-gpio = <&tlmm 61 GPIO_ACTIVE_HIGH>;

I don't think this is right, what's the revision of the board you have?

Konrad