From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-qt1-f173.google.com (mail-qt1-f173.google.com [209.85.160.173]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 51CA71DF73C for ; Mon, 2 Jun 2025 15:37:59 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.160.173 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748878681; cv=none; b=MOXl2x7cusJtCOGvKC3fvS5Jiq3Svl4xZgh8DQRDRt3GKN9q3+8F+MYQ3bnlMAlkCQbB2kIIUcuvXZrYB5sL+gizz+K5mK0yeztr8CyJ+0dg3haDgNakU3r4eQnHOlt8hpaE2i/I5b3HaHLvKu+zT82uPa1LbMKSzmgZQPyIMlY= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1748878681; c=relaxed/simple; bh=46RA2zg9WevoEZjwKKYlv3xRBsM9MZ2ghSOKjuqtL64=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=mhAPYh/4kFo8ogY06QUOYsNg7BiLxAKnxn8ddbAtrezHeAAM8LOZbtbkczAffZ1tWkCMUehBrEkUtDPIUNf3bkrWeCaWiLxDLXpm865NNIAXzWFh2EboJNUwYnlDayQBJOSpR/6ioY2todjPnnasqY5SzHR1i63sYBJcgUMf31M= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca; spf=pass smtp.mailfrom=ndufresne.ca; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b=G3wPYItD; arc=none smtp.client-ip=209.85.160.173 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=ndufresne.ca Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=ndufresne-ca.20230601.gappssmtp.com header.i=@ndufresne-ca.20230601.gappssmtp.com header.b="G3wPYItD" Received: by mail-qt1-f173.google.com with SMTP id d75a77b69052e-4a4323fe8caso29938441cf.2 for ; Mon, 02 Jun 2025 08:37:59 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=ndufresne-ca.20230601.gappssmtp.com; s=20230601; t=1748878678; x=1749483478; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=x1dHqucytNvJE5sOBJHQ1JgixIBWN/66qkZtbhARHsQ=; b=G3wPYItDtNQPMB7L8VdHb9an4fLg1TqZ9cugyafGcfmJ5bXSTU5fxvDneyxFAFGUA8 4+dT08njpHTAT4RaE7ch+V4PgQBKr5Cyba2zljN59hSmRTGmPPQ7afNh8lwNIP0LZgSc 1QcIkDJ75qmvkcKGKjIxJ3D0lMwkYWL13UstteynaAGSVvhxdY2eI3X8b1VP56zebBd6 UmO39SISNXkkKZ4tESBDcaPCWT5qolCsOqk/QZRfxysEHNAaMocQjFtnlFYZL7L0m2pg h6UMGbTknV/F6mzSXRncBu1KqNUmiLubh1wm6w8/1vO6WzzhGFAY5yUUNoyCcI6kZvUH P41A== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1748878678; x=1749483478; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=x1dHqucytNvJE5sOBJHQ1JgixIBWN/66qkZtbhARHsQ=; b=ASbTn4TQm7evwBE3QPfiOfc+rY/sQYv1ZducwzQmbZ3Tvuxl2uF1OAACBfFl+pjGdS jvaI05MP+Zoa1Ue2mvE1oR5YQtyOezu9o4BKgWgs2f/foy91aq3dSB9U/dcO2V7thajN SqtSdb4+wr4xOBbgOGewVHt5eoMPK/8pZG8P67W+CoiapvRWfySovek8HHiGhvePTVe6 PYDy8CsI1HrxaAOkXNPTZOgqPhApoTIrC5/g87NSsmXQzUEDOcNnAssCS7abG7FOx3LK goDSnnKPFfTDfWaAtlP4kPUd05N5t3CoC0qabt+WOERz1snT02slET2FPDLUXoB5ftDM rrFg== X-Forwarded-Encrypted: i=1; AJvYcCV8tCK4b1gTCnvi9W7oQcgMx9ATMHYyKseIrv4KRz24n2a6AlmXhnpf6qdsPTlqrrhqtGERNhBIsohK@vger.kernel.org X-Gm-Message-State: AOJu0YzrEaRlu2l0XlQSH9eyv652pnJl9KR1t+PatcNdySHsUVXr2n6O YfGvMn8lWrJzR1DMVPKmDQrHGUv/ZPCYrne25OvLYLjLuvFfFDqjx8QpFsiDTCv01Rw= X-Gm-Gg: ASbGnctXBD111X/Hx3hwzabPbvJAh8RBBgoVCjzfs07RCEg9dYW+o/K1c7bppi9IJow oeMUGQxSKLHv584CgwaKM48G7oPrp4V0T6mur2jQe8XSa3+cVw9OOdEi0vSZ7jE7O5e90jVsUUn m3T+1px9iwZvIylbA9EXewJuIVtk7dCi3gFcJFVuuFJzb6hvLqOBg1HyRQxl/6RIKgJgU6l8+Qx b+OOAMCzDSCzDaTjkBVTNQDaUgUh+CIqf3qqDC+hz4NKSYGzfmiGNfZnDAbxc9ZMd2LM0O6XxRz xgVgp0+7t9/s88WsClNnSeTybP6ve/tx0HI0+cGSWNW3Oa/0V/5Xits9 X-Google-Smtp-Source: AGHT+IFAxvbyts/4W1PU88jgJRJyPWsVyM/w1Qedjlhc5oIe8j+5+JXf7JzKMu2VMp0D7TLMJ22XCQ== X-Received: by 2002:a05:622a:5598:b0:4a4:3d27:77a0 with SMTP id d75a77b69052e-4a4a5ec583fmr144502391cf.2.1748878677932; Mon, 02 Jun 2025 08:37:57 -0700 (PDT) Received: from ?IPv6:2606:6d00:10:5285::5ac? ([2606:6d00:10:5285::5ac]) by smtp.gmail.com with ESMTPSA id d75a77b69052e-4a435772fb1sm56762721cf.8.2025.06.02.08.37.56 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 02 Jun 2025 08:37:57 -0700 (PDT) Message-ID: <01ee4dbe14917dff1e0d256dde6724f81a23ba4b.camel@ndufresne.ca> Subject: Re: [PATCH v6 17/20] media: platform: mtk-mdp3: Use cmdq_pkt_jump_rel() without shift_pa From: Nicolas Dufresne To: Jason-JH Lin , Rob Herring , Krzysztof Kozlowski , Conor Dooley , Jassi Brar , Chun-Kuang Hu , AngeloGioacchino Del Regno , Mauro Carvalho Chehab Cc: Matthias Brugger , Nancy Lin , Singo Chang , Paul-PL Chen , Moudy Ho , Xavier Chang , Xiandong Wang , Sirius Wang , Fei Shao , Chen-yu Tsai , Project_Global_Chrome_Upstream_Group@mediatek.com, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, dri-devel@lists.freedesktop.org, linux-mediatek@lists.infradead.org, linux-arm-kernel@lists.infradead.org, linux-media@vger.kernel.org Date: Mon, 02 Jun 2025 11:37:56 -0400 In-Reply-To: <20250601173355.1731140-18-jason-jh.lin@mediatek.com> References: <20250601173355.1731140-1-jason-jh.lin@mediatek.com> <20250601173355.1731140-18-jason-jh.lin@mediatek.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.56.2 (3.56.2-1.fc42) Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi, Le lundi 02 juin 2025 =C3=A0 01:31 +0800, Jason-JH Lin a =C3=A9crit=C2=A0: > With the removal of the shift_pa parameter, cmdq_pkt_jump_rel_temp() > can be replaced by the new cmdq_pkt_jump_rel() without shift_pa. >=20 > Then, remove the cmdq_shift_pa variable in the mdp_dev structure for > each mbox client. >=20 > Fixes: ade176534112 ("soc: mediatek: cmdq: Add parameter shift_pa to cmdq= _pkt_jump()") > Signed-off-by: Jason-JH Lin > --- > =C2=A0drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c | 2 +- > =C2=A0drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c | 2 -- > =C2=A0drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h | 1 - > =C2=A03 files changed, 1 insertion(+), 4 deletions(-) >=20 > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c b/drive= rs/media/platform/mediatek/mdp3/mtk-mdp3- > cmdq.c > index 7575ec376367..c35fe0e3a4d5 100644 > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c > +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-cmdq.c > @@ -638,7 +638,7 @@ static struct mdp_cmdq_cmd *mdp_cmdq_prepare(struct m= dp_dev *mdp, > =C2=A0 goto err_free_path; > =C2=A0 } > =C2=A0 cmdq_pkt_eoc(&cmd->pkt); > - cmdq_pkt_jump_rel_temp(&cmd->pkt, CMDQ_INST_SIZE, mdp->cmdq_shift_pa[pp= _idx]); > + cmdq_pkt_jump_rel(&cmd->pkt, CMDQ_INST_SIZE); Did I miss something or this reverts the change made in 15/20 ? I'm also unsure if its correct to ask for backports of this with Fixes tag. Isn't th= is for MT8196, a new board ? Nicolas > =C2=A0 > =C2=A0 for (i =3D 0; i < num_comp; i++) { > =C2=A0 s32 inner_id =3D MDP_COMP_NONE; > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c b/drive= rs/media/platform/mediatek/mdp3/mtk-mdp3- > core.c > index 8de2c8e4d333..2f8147481bd6 100644 > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c > +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.c > @@ -293,8 +293,6 @@ static int mdp_probe(struct platform_device *pdev) > =C2=A0 ret =3D PTR_ERR(mdp->cmdq_clt[i]); > =C2=A0 goto err_mbox_destroy; > =C2=A0 } > - > - mdp->cmdq_shift_pa[i] =3D cmdq_get_shift_pa(mdp->cmdq_clt[i]->chan); > =C2=A0 } > =C2=A0 > =C2=A0 init_waitqueue_head(&mdp->callback_wq); > diff --git a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h b/drive= rs/media/platform/mediatek/mdp3/mtk-mdp3- > core.h > index 05cade1d098e..430251f63754 100644 > --- a/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h > +++ b/drivers/media/platform/mediatek/mdp3/mtk-mdp3-core.h > @@ -126,7 +126,6 @@ struct mdp_dev { > =C2=A0 u32 id_count; > =C2=A0 struct ida mdp_ida; > =C2=A0 struct cmdq_client *cmdq_clt[MDP_PP_MAX]; > - u8 cmdq_shift_pa[MDP_PP_MAX]; > =C2=A0 wait_queue_head_t callback_wq; > =C2=A0 > =C2=A0 struct v4l2_device v4l2_dev;