From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 6A979C7EE23 for ; Mon, 8 May 2023 10:33:38 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S234702AbjEHKdg (ORCPT ); Mon, 8 May 2023 06:33:36 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:33218 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S234761AbjEHKdP (ORCPT ); Mon, 8 May 2023 06:33:15 -0400 Received: from mail-lj1-x22e.google.com (mail-lj1-x22e.google.com [IPv6:2a00:1450:4864:20::22e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8F0FD2ABDA for ; Mon, 8 May 2023 03:32:24 -0700 (PDT) Received: by mail-lj1-x22e.google.com with SMTP id 38308e7fff4ca-2ac733b813fso47887701fa.1 for ; Mon, 08 May 2023 03:32:24 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683541941; x=1686133941; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ScXfOKBt81Z5zV2cG1662UPRXJFST6VZnBC6VouOjSc=; b=GrmDkGJvrRaoi7LAewDtfUAM0YYBpgUMUKRpSX8RbK2obuLwBwfJlk2QZkc/b7PuJo HYWBbWCm6V2TXoHPv+iyQppf1PoYXtBvLAsZFcz5WgJI/QqSZMMF/sXoRZRS7bYhTX7u WwtTxeGprytGUZBpLQVgODKMSnmy8v6+XsCbjnm8J1ZIdM6GP0mN3E6/WvSHAO2l0AWe sgYQkjyPLeHPI4DErBPWlFeYnfWDxB7oN+SGqAUhJRzN1kmhH4kHm55/TPs4VUZPBhBn wWV+Y/Fk3TjSwEnn4WENzWiF0nqRTD6pmpzZdeH9eLGTDKYDM2MpSVAm9Qp2xLqeIZOt wnnA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683541941; x=1686133941; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ScXfOKBt81Z5zV2cG1662UPRXJFST6VZnBC6VouOjSc=; b=Y9vL4M30W0mhRd7tD4UDnhpLnbTRXFZoeY2dadVlrnO73L3PmzN+hisrm4ej2GNYtL va4GZ8gcHUU1S38UbCCgk+EXCMp8jOXdFJkmTwNIiM6IlXAdXnxjPvdTScv/W55tL7ko b8pVVDpQqPSWhceFuBxYyvfevV2CtLK9FDNy3Bije/D5lofPnTaAglGnSuw8j9rBXcgO 1Od4bUR7M/1BOZdzLWvsMgxeRn470/sLfxUY9A8mScdkd5eHOuIXnPyo6fSjEPqLAvcW FlTVAvi8HcNcp2ulniQ97sADIs49h59VESIDvncaWJPbn4QM5bkPHQsV6RpYguYLQ4K0 68Jw== X-Gm-Message-State: AC+VfDxeOA6IoibR8vWyiU4IOExbhioiewLm3WB02fQ6jZWvFqbJE2Dc TndKx1uE0cLRnkRp5kL1AD3WVBWtk/P4tVye0Cw= X-Google-Smtp-Source: ACHHUZ4gpZuq2LgpGp2cEbClw5qjF/b0rPeJcLA8iwjKT4SpwOE0zQ62tK/5XBVkS0mkN6iyEv87UA== X-Received: by 2002:a05:651c:236:b0:295:9be0:212b with SMTP id z22-20020a05651c023600b002959be0212bmr2763621ljn.8.1683541941628; Mon, 08 May 2023 03:32:21 -0700 (PDT) Received: from ?IPV6:2001:14ba:a0db:1f00::8a5? (dzdqv0yyyyyyyyyyybcwt-3.rev.dnainternet.fi. [2001:14ba:a0db:1f00::8a5]) by smtp.gmail.com with ESMTPSA id l11-20020a2e3e0b000000b002a8dce82cf6sm1127122lja.32.2023.05.08.03.32.20 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Mon, 08 May 2023 03:32:21 -0700 (PDT) Message-ID: <01fc4065-681f-daba-1c73-cc57768f880e@linaro.org> Date: Mon, 8 May 2023 13:32:20 +0300 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.10.0 Subject: Re: [PATCH 1/4] ARM: dts: qcom: msm8974: add ocmem clock to GPU Content-Language: en-GB To: Konrad Dybcio , Andy Gross , Bjorn Andersson , Rob Clark , Sean Paul , Abhinav Kumar , Rob Herring , Krzysztof Kozlowski Cc: Stephen Boyd , David Airlie , Daniel Vetter , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, dri-devel@lists.freedesktop.org, freedreno@lists.freedesktop.org References: <20230507190735.2333145-1-dmitry.baryshkov@linaro.org> <20230507190735.2333145-2-dmitry.baryshkov@linaro.org> <8cdecc51-2a42-4b82-9eb3-2ab77860c5d4@linaro.org> From: Dmitry Baryshkov In-Reply-To: Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 08/05/2023 13:28, Konrad Dybcio wrote: > > > On 8.05.2023 12:24, Dmitry Baryshkov wrote: >> On 08/05/2023 11:30, Konrad Dybcio wrote: >>> >>> >>> On 7.05.2023 21:07, Dmitry Baryshkov wrote: >>>> To get GPU working with the OCMEM, the oxili_ocmemgx_clk clock should be >>>> enabled. Pass it to the GPU to get it to work on apq8074/msm8974 boards. >>>> >>>> Fixes: fe079442db63 ("ARM: dts: qcom: msm8974: add gpu support") >>>> Signed-off-by: Dmitry Baryshkov >>>> --- >>> Uhh.. this clock should be managed by RPM with: >>> >>> type = MEM >>> id = 2 >>> >>> just like it's defined for 8994 today. >>> >>> Could you try adding it in rpmcc and confirming? >> >> There is an RPM_SMD_OCMEMGX_CLK clk already, it is a bus clock for the ocmemnoc. > It's wrong. Can you possibly be more specific here? On 8974 RPM_SMD_OCMEMGX_CLK is a core clock for ocmem and a bus clock for ocmemnoc. On 8994 this clocks is just a core clock for ocmem, there is no ocmemnoc. > > Konrad >> >>> >>> Konrad >>>>   arch/arm/boot/dts/qcom-msm8974.dtsi | 3 ++- >>>>   1 file changed, 2 insertions(+), 1 deletion(-) >>>> >>>> diff --git a/arch/arm/boot/dts/qcom-msm8974.dtsi b/arch/arm/boot/dts/qcom-msm8974.dtsi >>>> index 834ad95515b1..fb661c1bd3d5 100644 >>>> --- a/arch/arm/boot/dts/qcom-msm8974.dtsi >>>> +++ b/arch/arm/boot/dts/qcom-msm8974.dtsi >>>> @@ -2104,8 +2104,9 @@ gpu: adreno@fdb00000 { >>>>                 clocks = <&mmcc OXILI_GFX3D_CLK>, >>>>                    <&mmcc OXILICX_AHB_CLK>, >>>> +                 <&mmcc OXILI_OCMEMGX_CLK>, >>>>                    <&mmcc OXILICX_AXI_CLK>; >>>> -            clock-names = "core", "iface", "mem_iface"; >>>> +            clock-names = "core", "iface", "mem", "mem_iface"; >>>>                 sram = <&gmu_sram>; >>>>               power-domains = <&mmcc OXILICX_GDSC>; >> -- With best wishes Dmitry