From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Elad Nachman <enachman@marvell.com>,
robh+dt@kernel.org, krzysztof.kozlowski+dt@linaro.org,
conor+dt@kernel.org, andrew@lunn.ch, gregory.clement@bootlin.com,
sebastian.hesselbarth@gmail.com, pali@kernel.org,
mrkiko.rs@gmail.com, chris.packham@alliedtelesis.co.nz,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
linux-arm-kernel@lists.infradead.org
Cc: cyuval@marvell.com
Subject: Re: [PATCH v4 2/3] dt-bindings: arm64: dts: add dt-bindings for Marvell COM Express boards
Date: Mon, 30 Oct 2023 14:31:38 +0100 [thread overview]
Message-ID: <02040f13-22ae-4ea5-9119-99bf778c27bf@linaro.org> (raw)
In-Reply-To: <20231029174814.559583-3-enachman@marvell.com>
On 29/10/2023 18:48, Elad Nachman wrote:
> From: Elad Nachman <enachman@marvell.com>
>
A nit, subject: drop second/last, redundant "dt-bindings for". The
"dt-bindings" prefix is already stating that these are bindings.
> Add dt bindings for:
> CN9130 COM Express CPU module
> CN9131 COM Express CPU module
> AC5X RD COM Express Type 7 carrier board.
> AC5X RD COM Express board with a CN9131 COM Express Type 7 CPU module.
>
> Signed-off-by: Elad Nachman <enachman@marvell.com>
> ---
> .../bindings/arm/marvell/armada-7k-8k.yaml | 15 +++++++++++++++
> .../bindings/arm/marvell/marvell,ac5.yaml | 14 ++++++++++++++
> 2 files changed, 29 insertions(+)
>
> diff --git a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> index 52d78521e412..7e0ac5110eef 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/armada-7k-8k.yaml
> @@ -60,4 +60,19 @@ properties:
> - const: marvell,armada-ap807-quad
> - const: marvell,armada-ap807
>
> + - description: Armada CN9130 SoC without external CP as COM Express CPU module
> + items:
> + - const: marvell,cn9130-cpu-module
How CPU module can be used alone?
> + - const: marvell,cn9130
> + - const: marvell,armada-ap807-quad
> + - const: marvell,armada-ap807
> +
> + - description: Armada CN9131 SoC with one external CP as COM Express CPU module
> + items:
> + - const: marvell,cn9131-cpu-module
> + - const: marvell,cn9131
> + - const: marvell,cn9130
> + - const: marvell,armada-ap807-quad
> + - const: marvell,armada-ap807
> +
> additionalProperties: true
> diff --git a/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml b/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml
> index 8960fb8b2b2f..734e1716a3e9 100644
> --- a/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml
> +++ b/Documentation/devicetree/bindings/arm/marvell/marvell,ac5.yaml
> @@ -27,6 +27,20 @@ properties:
> - const: marvell,ac5x
> - const: marvell,ac5
>
> + - description: Alleycat5X (98DX35xx) Reference Design as COM Express Carrier
> + items:
> + - enum:
> + - marvell,rd-ac5x-carrier
> + - const: marvell,ac5x
> +
> + - description:
> + Alleycat5X (98DX35xx) Reference Design as COM Express Carrier plus
> + Armada CN9131 COM Express CPU module
> + items:
> + - enum:
> + - marvell,rd-ac5x-carrier-with-cn9131
> + - const: marvell,ac5x
You never responded to me concerns, so I still do not know what's this.
This claims it has CN9131, but compatibles are missing.
Can anyone help us understand why AC5 has CN9130 but these are in
different files?
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-10-30 13:31 UTC|newest]
Thread overview: 10+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-10-29 17:48 [PATCH v4 0/3] arm64: dts: cn913x: add COM Express boards Elad Nachman
2023-10-29 17:48 ` [PATCH v4 1/3] MAINTAINERS: add ac5 to list of maintained Marvell dts files Elad Nachman
2023-10-29 17:52 ` Andrew Lunn
2023-10-29 17:48 ` [PATCH v4 2/3] dt-bindings: arm64: dts: add dt-bindings for Marvell COM Express boards Elad Nachman
2023-10-30 12:48 ` Rob Herring
2023-10-30 13:22 ` Rob Herring
2023-10-30 13:31 ` Krzysztof Kozlowski [this message]
2023-10-29 17:48 ` [PATCH v4 3/3] arm64: dts: cn913x: add device trees for " Elad Nachman
2023-10-29 18:03 ` Andrew Lunn
2023-10-30 13:32 ` Krzysztof Kozlowski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02040f13-22ae-4ea5-9119-99bf778c27bf@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=chris.packham@alliedtelesis.co.nz \
--cc=conor+dt@kernel.org \
--cc=cyuval@marvell.com \
--cc=devicetree@vger.kernel.org \
--cc=enachman@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mrkiko.rs@gmail.com \
--cc=pali@kernel.org \
--cc=robh+dt@kernel.org \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox