From: Marek Vasut <marex@denx.de>
To: Geert Uytterhoeven <geert@linux-m68k.org>
Cc: "Niklas Söderlund" <niklas.soderlund+renesas@ragnatech.se>,
"Rob Herring" <robh@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
linux-renesas-soc@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] arm64: dts: renesas: white-hawk-cpu: Move avb0 reset gpio to mdio node
Date: Wed, 30 Oct 2024 15:45:30 +0100 [thread overview]
Message-ID: <021aee32-795a-42c8-80e7-89cb8a45f935@denx.de> (raw)
In-Reply-To: <CAMuHMdVnJPMLx=39=f+7S4vdRAC-0q0hKS6Ww=ELYEaLBx+gZw@mail.gmail.com>
On 10/29/24 9:26 AM, Geert Uytterhoeven wrote:
[...]
>>>>>> revision, we can revisit this discussion ? Maybe bootloader-applied DTOs
>>>>>> could work then ?
>>>>>
>>>>> So, what would you suggest when the PHY nodes would not have compatible
>>>>> strings?
>>>> I hope I already answered that question before.
>>>
>>> Sorry, I may have missed that?
>>>
>>> I really prefer not having the PHY compatible strings, as DT should
>>> describe only what cannot be auto-detected.
>> See paragraph above (*). My take on this is the exact opposite, better
>> describe the PHY in DT fully, including compatible strings, so that if
>> the PHY driver needs to do some sort of bring up tweak/fix/errata
>> workaround/... , it can do so by matching on the compatible string
>> without trying to bring the PHY up in some generic and potentially
>> problematic way.
>>
>> The MDIO bus is not discoverable the same way as PCIe or USB is, so I
>> don't think the "DT should describe only what cannot be detected" is
>> really applicable to MDIO bus the same way it applies to PCIe or USB.
>
> So you think this is similar to SPI NOR, where most FLASHes can be
> discovered with the JEDEC READ ID opcode?
Possibly, if you take broken-flash-reset DT property into account
somehow. Even SPI NOR does require a proper reset after all, else the
READ ID opcode may not work.
> See commit 4b0cb4e7ab2f777c
> ("dt-bindings: mtd: spi-nor: clarify the need for spi-nor compatibles"),
> which clarified why no new compatible values are accepted.
This works as long as your SPI NOR reset works.
next prev parent reply other threads:[~2024-10-30 16:52 UTC|newest]
Thread overview: 17+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-07-04 15:26 [PATCH] arm64: dts: renesas: white-hawk-cpu: Move avb0 reset gpio to mdio node Niklas Söderlund
2024-08-02 8:33 ` Geert Uytterhoeven
2024-08-02 17:16 ` Marek Vasut
2024-08-22 13:56 ` Geert Uytterhoeven
2024-09-06 13:52 ` Niklas Söderlund
2024-09-06 18:09 ` Marek Vasut
2024-10-15 14:48 ` Niklas Söderlund
2024-10-20 22:16 ` Marek Vasut
2024-10-21 7:13 ` Geert Uytterhoeven
2024-10-21 21:31 ` Marek Vasut
2024-10-22 7:38 ` Geert Uytterhoeven
2024-10-27 15:21 ` Marek Vasut
2024-10-28 10:13 ` Geert Uytterhoeven
2024-10-28 18:18 ` Marek Vasut
2024-10-29 8:26 ` Geert Uytterhoeven
2024-10-30 14:45 ` Marek Vasut [this message]
2025-01-23 13:18 ` Niklas Söderlund
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=021aee32-795a-42c8-80e7-89cb8a45f935@denx.de \
--to=marex@denx.de \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=geert@linux-m68k.org \
--cc=krzk+dt@kernel.org \
--cc=linux-renesas-soc@vger.kernel.org \
--cc=niklas.soderlund+renesas@ragnatech.se \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).