From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 8EE6DC433F5 for ; Mon, 3 Oct 2022 21:06:45 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229880AbiJCVGo (ORCPT ); Mon, 3 Oct 2022 17:06:44 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:46968 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229803AbiJCVFp (ORCPT ); Mon, 3 Oct 2022 17:05:45 -0400 Received: from relay07.th.seeweb.it (relay07.th.seeweb.it [IPv6:2001:4b7a:2000:18::168]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B21A819C11 for ; Mon, 3 Oct 2022 14:05:18 -0700 (PDT) Received: from [IPV6:2a00:f41:18f3:7ee6:a401:45d0:c41f:c16e] (unknown [IPv6:2a00:f41:18f3:7ee6:a401:45d0:c41f:c16e]) (using TLSv1.3 with cipher TLS_AES_128_GCM_SHA256 (128/128 bits) key-exchange X25519 server-signature RSA-PSS (2048 bits) server-digest SHA256) (No client certificate requested) by m-r2.th.seeweb.it (Postfix) with ESMTPSA id 11D0A3F0AB; Mon, 3 Oct 2022 23:05:12 +0200 (CEST) Message-ID: <02365772-de32-56ab-65a2-0a2fbccb5e2e@somainline.org> Date: Mon, 3 Oct 2022 23:05:11 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Macintosh; Intel Mac OS X 10.15; rv:102.0) Gecko/20100101 Thunderbird/102.3.1 Subject: Re: [PATCH v5 0/3] arm64: dts: qcom: add dts for sa8540p-ride board To: Parikshit Pareek , Andy Gross , Bjorn Andersson , Rob Herring , Krzysztof Kozlowski Cc: linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, Andrew Halaney , Shazad Hussain , Brian Masney , Johan Hovold References: <20221003125444.12975-1-quic_ppareek@quicinc.com> From: Konrad Dybcio In-Reply-To: <20221003125444.12975-1-quic_ppareek@quicinc.com> Content-Type: text/plain; charset=UTF-8; format=flowed Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 03/10/2022 14:54, Parikshit Pareek wrote: > Change in v5: > - Moved the usb and ufs nodes from sa8540p-adp.dtsi file to respective > board specific dts files: sa8295p-adp.dts and sa8540p-adp-ride.dts. Is there any benefit in this? USB0/2 and UFS (not UFS card) nodes are identical in the 2 files. Konrad > Took inputs from Shazad Hussain in this regard(John) > - Added more description of the board differences(John) > - Not including Reviewed-by for Krzysztof, because of the new changes to > be reviewed. > - Removed Reported-by tag(John). > > Changes in v4: > - Removed the ufs_card_hc node, as it is not mounted on Qdrive-3 board. > - Removed usb_1 relared nodes, as usb1 doesn't have any port connected on > Qdrive3 board. > - Added Reported-by tag for Shazad(for ufs and usb_1 node removals) > > Changes in v3: > - Added Acked-by tag (Krzysztof) > - Renamed dtsi to sa8540p-adp.dtsi (John) > - Removed copyright from sa8295-adp.dts and sa8295-adp.dtsi(John) > - Added cover letter > > change in v2: > - Make dt-binding patch as the first one in the patch set > - Add , after year 2022, in the license header > > Initial version: > - Move the common nodes to sa8540p-adp.dtsi, and create qrive-3 board > specific file sa8540p-adp-ride.dts. > > > Parikshit Pareek (3): > dt-bindings: arm: qcom: Document additional sa8540p device > arm64: dts: qcom: sa8295p: move common nodes to dtsi > arm64: dts: qcom: introduce sa8540p-ride dts > > .../devicetree/bindings/arm/qcom.yaml | 1 + > arch/arm64/boot/dts/qcom/Makefile | 1 + > arch/arm64/boot/dts/qcom/sa8295p-adp.dts | 528 +++++------------- > arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts | 71 +++ > .../{sa8295p-adp.dts => sa8540p-adp.dtsi} | 133 ----- > 5 files changed, 219 insertions(+), 515 deletions(-) > rewrite arch/arm64/boot/dts/qcom/sa8295p-adp.dts (70%) > create mode 100644 arch/arm64/boot/dts/qcom/sa8540p-adp-ride.dts > copy arch/arm64/boot/dts/qcom/{sa8295p-adp.dts => sa8540p-adp.dtsi} (72%) >