From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f51.google.com (mail-ej1-f51.google.com [209.85.218.51]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 393E616C6B0 for ; Fri, 9 Aug 2024 06:29:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.51 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723184964; cv=none; b=t5VF/KwjtRuj6oLciMHAB0wz7gVmK73AqrEbGoeURA+djnivSDfzz568VSl1GP/uwIC19+VwNyc2xj6cSsZTGPs9n/HIdsi4QkeENOcYp9zpfrkbrIbjAa0aEAaZ95x6+vRuLWRaldxdoHigONlOE27N2tehC6h1QPrTiqajDh4= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1723184964; c=relaxed/simple; bh=qvpbFtmY/ki2GI1uWwjSh+qxSPj3FgUENtOITCdjfm0=; h=Message-ID:Date:MIME-Version:Subject:To:Cc:References:From: In-Reply-To:Content-Type; b=ZO6mXRKnT7ZpPPxwz6h5rNPfY8YzoTShHRzrmUpfCFtvx+CYX+fYovHFOYSo2sURY+M5faIYhVJdfillIGePfdwBtFwCCoxdItY1zXVqhpPy2w0FehVuRMuISIOFMPBRmLyln1BgK/NNjfxNtvREaLIQounzO3S3Qm2zT6mMKkg= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev; spf=pass smtp.mailfrom=tuxon.dev; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b=peYTN0NF; arc=none smtp.client-ip=209.85.218.51 Authentication-Results: smtp.subspace.kernel.org; dmarc=none (p=none dis=none) header.from=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=tuxon.dev Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=tuxon.dev header.i=@tuxon.dev header.b="peYTN0NF" Received: by mail-ej1-f51.google.com with SMTP id a640c23a62f3a-a7a94478a4eso454415866b.1 for ; Thu, 08 Aug 2024 23:29:23 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=tuxon.dev; s=google; t=1723184961; x=1723789761; darn=vger.kernel.org; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ttC+1PaF0ZwcJ1arsMSLD6uLKFV2ZfWm/Rhj6c+k6zI=; b=peYTN0NFhFgf6bfbNbJIuVlBIwJ97uINJSfm8ztLPVzwR5DtKz7M1kEBvyrjwLDE1O Rws0gmvFM9VKIjoqWD7sBJnS5yv/ZJmuUcwSwHQpSgljfLaw7GL4K7xo/AsguHgIH7dx L8IP+qtxLx7lulEnMDd1ovZNtpkv58eGKNZepjjqEUFOOun2dF/4O5UImFm5RYbatPf9 kBpLwk8L1HFNdLIK/OoxhZycy6fBeTI0mH2zNlVbNbqaOAau80YlBrhdYu2jMecPPkdT 7NXobCnIOqn7dU67SrWAFJKCv8rAqLeKyWW9nLjDbuvFFhHBVyionTv7MzjYLWHL5cmi F5ZA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1723184961; x=1723789761; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ttC+1PaF0ZwcJ1arsMSLD6uLKFV2ZfWm/Rhj6c+k6zI=; b=n19Lh9kPn66BsnXO8onRAk5AIRnyz/03OnBZ5DsF5i2CHR7A13FdD0x8FJ8ZNia0Ag 61DGQXDRMTFK7YPe9it/7n8c6wmb8zxsAov0+lB8DuWE1UvFBz0EQ6qdeFgVmIautn81 FZxnm2yJsqSJVOmFMMfcevd1Q+D/PHWhnbiHuw0mHH9iHKcSH4HGz41goz0uAuywTyuv /MH53Up7iRrudUjsvrcTbAH/vZm/X1An7Xs2RA/23NvOD9t4JF+cZ2aMXYwdwd1XZrU9 XsaAMJo4EBq7KwgtidxsLawiGco+rT8Fiki51qpTdz3DfdSODBM0jVci98XnfVoOHWrh G4oQ== X-Gm-Message-State: AOJu0YxKWUsWqjW2ymVfuw+9mrJVEFmTRsMJhtwrz5d1EYQQuHgPyuWa YC18uArnASt1lSmfeGbGv4aMEqS9XFn1hAHA0EJXgE0dwzk1FXdOyVDACvCsPwA= X-Google-Smtp-Source: AGHT+IHn91yTtxdiFLGjMBp8Q9AOGhfmakKBLnjKcJSGhqNNNr8lDAE3/RoU+AZcnkm3AXka08ZHTA== X-Received: by 2002:a17:907:7e84:b0:a7a:b18a:6c with SMTP id a640c23a62f3a-a8091f19b40mr357318466b.16.1723184961354; Thu, 08 Aug 2024 23:29:21 -0700 (PDT) Received: from [192.168.50.4] ([82.78.167.180]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-a7dc9c0c7bfsm810220866b.70.2024.08.08.23.29.19 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 08 Aug 2024 23:29:20 -0700 (PDT) Message-ID: <026fa7ad-f8d2-49a3-8a1a-0efdae343504@tuxon.dev> Date: Fri, 9 Aug 2024 09:29:19 +0300 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 User-Agent: Mozilla Thunderbird Subject: Re: [PATCH] ARM: dts: microchip: Rename node, sub-node, and clean up spacing Content-Language: en-US To: Andrei.Simion@microchip.com, robh@kernel.org, krzk+dt@kernel.org, conor+dt@kernel.org, Nicolas.Ferre@microchip.com, alexandre.belloni@bootlin.com Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-arm-kernel@lists.infradead.org References: <20240723131228.189308-1-andrei.simion@microchip.com> <89f51615-0dee-4ab0-ab72-e3c057fee1e7@tuxon.dev> <4a8c31bf-7524-4f8c-b998-701b721f5001@microchip.com> From: claudiu beznea In-Reply-To: <4a8c31bf-7524-4f8c-b998-701b721f5001@microchip.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Hi, Andrei, On 08.08.2024 17:25, Andrei.Simion@microchip.com wrote: >>> diff --git a/arch/arm/boot/dts/microchip/at91sam9g25-gardena-smart-gateway.dts b/arch/arm/boot/dts/microchip/at91sam9g25-gardena-smart-gateway.dts >>> index af70eb8a3a02..60560e4c1696 100644 >>> --- a/arch/arm/boot/dts/microchip/at91sam9g25-gardena-smart-gateway.dts >>> +++ b/arch/arm/boot/dts/microchip/at91sam9g25-gardena-smart-gateway.dts >>> @@ -37,71 +37,71 @@ button { >>> leds { >>> compatible = "gpio-leds"; >>> >>> - power_blue { >>> + led-0 { >>> label = "smartgw:power:blue"; >>> gpios = <&pioC 21 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> }; >>> >>> - power_green { >>> + led-1 { >>> label = "smartgw:power:green"; >>> gpios = <&pioC 20 GPIO_ACTIVE_HIGH>; >>> default-state = "on"; >>> }; >>> >>> - power_red { >>> + led-2 { >>> label = "smartgw:power:red"; >>> gpios = <&pioC 19 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> }; >>> >>> - radio_blue { >>> + led-3 { >>> label = "smartgw:radio:blue"; >>> gpios = <&pioC 18 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> }; >>> >>> - radio_green { >>> + led-4 { >>> label = "smartgw:radio:green"; >>> gpios = <&pioC 17 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> }; >>> >>> - radio_red { >>> + led-5 { >>> label = "smartgw:radio:red"; >>> gpios = <&pioC 16 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> }; >>> >>> - internet_blue { >>> + led-6 { >>> label = "smartgw:internet:blue"; >>> gpios = <&pioC 15 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> }; >>> >>> - internet_green { >>> + led-7 { >>> label = "smartgw:internet:green"; >>> gpios = <&pioC 14 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> }; >>> >>> - internet_red { >>> + led-8 { >>> label = "smartgw:internet:red"; >>> gpios = <&pioC 13 GPIO_ACTIVE_HIGH>; >>> default-state = "off"; >>> }; >>> >>> - heartbeat { >>> + led-9 { >>> label = "smartgw:heartbeat"; >>> gpios = <&pioB 8 GPIO_ACTIVE_HIGH>; >>> linux,default-trigger = "heartbeat"; >>> }; >>> >>> - pb18 { >>> + led-pb18 { >>> status = "disabled"; >>> }; >>> >>> - pd21 { >>> + led-pd21 { >> Why used led- for some leds and led- for other? Valid >> for other files. >> > I could have done either rule led- or led- > but we ended up with the old label being quite long. > So, I use led- when is too long. > I don't think it was the best rule to rename. > In your opinion, how would it be correct to rename these subnodes? Keeping old label is OK. FYI, these particular changes were already integrated with old labels being kept. See https://git.kernel.org/pub/scm/linux/kernel/git/at91/linux.git/commit/?id=b39c457205d0a3513fed1c3863e7cf9b6d72bf86 Thank you, Claudiu Beznea > > > PS: It is a problem on our side with the mail server. The e-mails may not arrive on the linux-arm-kernel mailing list. > > BR, > Andrei Simion