From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 01DBBC77B7C for ; Thu, 11 May 2023 14:50:21 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S238149AbjEKOuT (ORCPT ); Thu, 11 May 2023 10:50:19 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:42466 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S238763AbjEKOt7 (ORCPT ); Thu, 11 May 2023 10:49:59 -0400 Received: from mail-ed1-x533.google.com (mail-ed1-x533.google.com [IPv6:2a00:1450:4864:20::533]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 9DC9B1163A for ; Thu, 11 May 2023 07:49:04 -0700 (PDT) Received: by mail-ed1-x533.google.com with SMTP id 4fb4d7f45d1cf-50bc0117683so15499943a12.1 for ; Thu, 11 May 2023 07:49:04 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; t=1683816543; x=1686408543; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=rfmScQuHDtUIzeUlR/F8RZSBPxoOFtpMv619WIBm4+4=; b=IU/f7ixl4zdQ8gsbp48DMo1UmGVuGpNZ5gaqKJjMdSLL310e9oSEwrSrf1IJSel89i RjJiE8dLS5FK/iGLtLEuc1KerE/Vhyj9vN85P5QnUJZMRwME2z74verzU9vi4X8WVEni oGAI6sw76v3WXcYss1Ydt/FmzjDfoYJ4eC4IpwBXnKz+CzOmxGTNqeYw0bMaBuwOOYlv xVPFnJ8XnKGTCHClOu+c0zKcTGw9bxj3CuZ/foq4YK6Ioen3ScrHZAdJwLhyVzgD13id ePWIF9xgxz1dWKu/QM6n1035+xbe7LxK78DSPzgtMMDYToTzjy0nNEOat2whYE5ONXid UHkw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20221208; t=1683816543; x=1686408543; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=rfmScQuHDtUIzeUlR/F8RZSBPxoOFtpMv619WIBm4+4=; b=TXFLGQXdHS3O+BAHDGSlnN3jiYJ3hAAUxlCtorzXmfUV7s40lCCrVU/e6dGCVUx5iy VAgiRnUVpBvuHXLwsKl4QGFV7aO+vPPNzFjSRZRdPf6L5U+SBpdcOZVf9ka/In1hRfvZ t26EjMHIDpimfP2S2Uh5clrqI+j/lXLq0l/olMJPDSALcCoQgpr/NBDULiWtaA8Wd0AA +efo724F9HMGGSqKPSrnw75lx0rrGKPhl3Z/qrWd5y90NE6+eOoacFMqWdMLDo+gEkK+ 9kHsBt2K64ctUuNqoJIManzaI4MX1A/q51RdWbn5b1+kG3yT9tcLXo5gd9lNig0sBKE3 p3qg== X-Gm-Message-State: AC+VfDyb1FHEO4v5dZp/hEO4vBKAKEFig/c8xDiFK9J3YhzV62nafLy7 R6wMEjgIAAMG9h8fEArc25j85g== X-Google-Smtp-Source: ACHHUZ7r3REokTqrU9qR/UYBky+WbyZ6zPRRmQvruQaNLoxgGEpLy1LeSp4bpsryPfyslW+zo8qhrA== X-Received: by 2002:a17:907:2687:b0:961:a67:29c with SMTP id bn7-20020a170907268700b009610a67029cmr18117774ejc.70.1683816543309; Thu, 11 May 2023 07:49:03 -0700 (PDT) Received: from ?IPV6:2a02:810d:15c0:828:d7cd:1be6:f89d:7218? ([2a02:810d:15c0:828:d7cd:1be6:f89d:7218]) by smtp.gmail.com with ESMTPSA id bz1-20020a1709070aa100b00969e316d8dbsm3810210ejc.225.2023.05.11.07.49.02 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 11 May 2023 07:49:02 -0700 (PDT) Message-ID: <028fb8ac-d6cc-6fee-f50b-b965e69e7d0c@linaro.org> Date: Thu, 11 May 2023 16:49:01 +0200 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.11.0 Subject: Re: [PATCH v2 1/2] dt-bindings: cdns,usb3: Add clock and reset Content-Language: en-US To: Roger Quadros , Minda Chen , Rob Herring , Krzysztof Kozlowski , Pawel Laszczak , Greg Kroah-Hartman , Peter Chen , Philipp Zabel Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, linux-usb@vger.kernel.org References: <20230510132816.108820-1-minda.chen@starfivetech.com> <20230510132816.108820-2-minda.chen@starfivetech.com> <9cf5965a-8290-dfff-9f92-07ed2df66650@linaro.org> <05057f6d-cb38-8e4a-5d30-82863e0cda44@kernel.org> From: Krzysztof Kozlowski In-Reply-To: <05057f6d-cb38-8e4a-5d30-82863e0cda44@kernel.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 11/05/2023 14:16, Roger Quadros wrote: > > > On 11/05/2023 12:26, Krzysztof Kozlowski wrote: >> On 10/05/2023 15:28, Minda Chen wrote: >>> To support generic clock and reset init in Cadence USBSS >>> controller, add clock and reset dts configuration. >>> >>> Signed-off-by: Minda Chen >>> --- >>> .../devicetree/bindings/usb/cdns,usb3.yaml | 14 ++++++++++++++ >>> 1 file changed, 14 insertions(+) >>> >>> diff --git a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>> index cae46c4982ad..623c6b34dee3 100644 >>> --- a/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>> +++ b/Documentation/devicetree/bindings/usb/cdns,usb3.yaml >>> @@ -42,6 +42,18 @@ properties: >>> - const: otg >>> - const: wakeup >>> >>> + clocks: >>> + minItems: 1 >>> + maxItems: 8 >>> + description: >>> + USB controller clocks. >> >> You need to list the items. And why is it variable? Your clock choice in >> the example is poor, I doubt it is real. >> >>> + >>> + resets: >>> + minItems: 1 >>> + maxItems: 8 >>> + description: >>> + USB controller generic resets. >> >> Here as well. >> >> You had one clock last time, thus the review was - drop the names. Now >> you changed it to 8 clocks... I don't understand. >> > > Different platforms may have different number of clocks/resets or none. > So I don't think minItems/maxItems should be specified. Yeah, but we want the clocks to be specific per platform. Not anything anywhere. Best regards, Krzysztof