From: Nicolas Ferre <nicolas.ferre@microchip.com>
To: Lee Jones <lee.jones@linaro.org>,
Ludovic Desroches <ludovic.desroches@microchip.com>
Cc: devicetree@vger.kernel.org, boris.brezillon@free-electrons.com,
linux-kernel@vger.kernel.org,
alexandre.belloni@free-electrons.com,
linux-mtd@lists.infradead.org, computersforpeace@gmail.com,
linux-arm-kernel@lists.infradead.org
Subject: Re: [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout
Date: Tue, 18 Jul 2017 11:23:43 +0200 [thread overview]
Message-ID: <02a0c390-610c-d38b-e6a3-f04120c6fbb3@microchip.com> (raw)
In-Reply-To: <20170718091238.wweaobzccdlgv5dh@dell>
On 18/07/2017 at 11:12, Lee Jones wrote:
> On Tue, 18 Jul 2017, Lee Jones wrote:
>
>> On Tue, 11 Jul 2017, Ludovic Desroches wrote:
>>
>>> For HSMC controller, the register layout depends on the device i.e. the
>>> offset of setup, pulse, cycle, mode and timings registers is not the
>>> same. An helper is added to provide the correct register layout.
>>>
>>> Fixes: fe9d7cb22ef3 ("mfd: syscon: atmel-smc: Add new helpers to ease
>>> SMC regs manipulation")
>>> Suggested-by: Boris Brezillon <boris.brezillon@free-electrons.com>
>>> Signed-off-by: Ludovic Desroches <ludovic.desroches@microchip.com>
>>> ---
>>> drivers/memory/atmel-ebi.c | 13 +++++--
>>> drivers/mfd/atmel-smc.c | 67 +++++++++++++++++++++++++-------
>>> drivers/mtd/nand/atmel/nand-controller.c | 10 +++--
>>> include/linux/mfd/syscon/atmel-smc.h | 32 ++++++++++-----
>>> 4 files changed, 92 insertions(+), 30 deletions(-)
>>
>> Applied, thanks.
>
> Apologies, it looks like this needs 2 more Acks before I can even
> consider taking it.
>
> Unapplied.
If mine is missing, here it is:
For the whole series:
Acked-by: Nicolas Ferre <nicolas.ferre@microchip.com>
And I think that Alexandre seemed okay by discussing the path those
patches should take...
Thanks, bye,
--
Nicolas Ferre
next prev parent reply other threads:[~2017-07-18 9:23 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2017-07-11 7:40 [PATCH 0/3] Fix SMC layout register for sama5d2 Ludovic Desroches
[not found] ` <20170711074015.30440-1-ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2017-07-11 7:40 ` [PATCH 1/3] mfd: syscon: update Atmel SMC binding doc Ludovic Desroches
[not found] ` <20170711074015.30440-2-ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2017-07-14 16:06 ` Rob Herring
2017-07-18 8:10 ` Lee Jones
2017-07-11 7:40 ` [PATCH 2/3] mfd: syscon: atmel-smc: add helper to retrieve register layout Ludovic Desroches
[not found] ` <20170711074015.30440-3-ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2017-07-11 8:07 ` Boris Brezillon
2017-07-18 8:15 ` Lee Jones
2017-07-18 9:12 ` Lee Jones
2017-07-18 9:23 ` Nicolas Ferre [this message]
[not found] ` <02a0c390-610c-d38b-e6a3-f04120c6fbb3-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2017-07-18 9:37 ` Lee Jones
2017-07-18 9:56 ` Ludovic Desroches
2017-07-18 9:24 ` Alexandre Belloni
2017-07-11 7:40 ` [PATCH 3/3] ARM: dts: at91: sama5d2: use sama5d2 compatible string for SMC Ludovic Desroches
[not found] ` <20170711074015.30440-4-ludovic.desroches-UWL1GkI3JZL3oGB3hsPCZA@public.gmane.org>
2017-07-11 7:52 ` Nicolas Ferre
2017-07-11 7:58 ` Ludovic Desroches
[not found] ` <20170711075829.5rzdrjgao6efiuj2-fC2aZbRiGnsAAwgTK2POJVCF2YAvjlIb@public.gmane.org>
2017-07-11 8:07 ` Nicolas Ferre
2017-07-11 8:08 ` Ludovic Desroches
[not found] ` <20170711080853.uxdmxocq5nhrp7vq-fC2aZbRiGnsAAwgTK2POJVCF2YAvjlIb@public.gmane.org>
2017-07-11 9:25 ` Lee Jones
2017-07-12 13:59 ` Alexandre Belloni
2017-07-13 7:59 ` Lee Jones
2017-07-17 9:17 ` Alexandre Belloni
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=02a0c390-610c-d38b-e6a3-f04120c6fbb3@microchip.com \
--to=nicolas.ferre@microchip.com \
--cc=alexandre.belloni@free-electrons.com \
--cc=boris.brezillon@free-electrons.com \
--cc=computersforpeace@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=lee.jones@linaro.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-mtd@lists.infradead.org \
--cc=ludovic.desroches@microchip.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).