From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [alsa-devel] [PATCH RESEND] ARM: dts: Support audio on Exynos5422-odroidxu3 using simple-audio-card Date: Tue, 24 Mar 2015 21:58:29 +0900 Message-ID: <02cf01d06632$39be11a0$ad3a34e0$@kernel.org> References: <1427079093-28483-1-git-send-email-ideal.song@samsung.com> <550FF0FF.4000604@samsung.com> Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-reply-to: <550FF0FF.4000604@samsung.com> Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org To: 'Sylwester Nawrocki' , 'Inha Song' Cc: broonie@kernel.org, kgene@kernel.org, robh+dt@kernel.org, pawel.moll@arm.com, mark.rutland@arm.com, galak@codeaurora.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-samsung-soc@vger.kernel.org, cw00.choi@samsung.com List-Id: devicetree@vger.kernel.org Sylwester Nawrocki wrote: > > On 23/03/15 03:51, Inha Song wrote: > > Add MAX98090 audio codec, I2S interface and the sound nodes to support > > audio on Exynos5422 SoC Based Odroid-XU3 board. Now we can support audio > > in Odroid-XU3 board using simple-audio-card DT binding. > > > > Signed-off-by: Inha Song > > --- > > arch/arm/boot/dts/exynos5420.dtsi | 9 +++++ > > arch/arm/boot/dts/exynos5422-odroidxu3.dts | 57 ++++++++++++++++++++++++++++++ > > 2 files changed, 66 insertions(+) > > > > diff --git a/arch/arm/boot/dts/exynos5420.dtsi b/arch/arm/boot/dts/exynos5420.dtsi > > index 4eaeabe..e459c1d 100644 > > --- a/arch/arm/boot/dts/exynos5420.dtsi > > +++ b/arch/arm/boot/dts/exynos5420.dtsi > > @@ -415,6 +415,9 @@ > > <&clock_audss EXYNOS_I2S_BUS>, > > <&clock_audss EXYNOS_SCLK_I2S>; > > clock-names = "iis", "i2s_opclk0", "i2s_opclk1"; > > + #clock-cells = <1>; > > + clock-output-names = "i2s_cdclk0"; > > + #sound-dai-cells = <1>; > > samsung,idma-addr = <0x03000000>; > > pinctrl-names = "default"; > > pinctrl-0 = <&i2s0_bus>; > > @@ -429,6 +432,9 @@ > > dma-names = "tx", "rx"; > > clocks = <&clock CLK_I2S1>, <&clock CLK_SCLK_I2S1>; > > clock-names = "iis", "i2s_opclk0"; > > + #clock-cells = <1>; > > + clock-output-names = "i2s_cdclk1"; > > + #sound-dai-cells = <1>; > > pinctrl-names = "default"; > > pinctrl-0 = <&i2s1_bus>; > > status = "disabled"; > > @@ -442,6 +448,9 @@ > > dma-names = "tx", "rx"; > > clocks = <&clock CLK_I2S2>, <&clock CLK_SCLK_I2S2>; > > clock-names = "iis", "i2s_opclk0"; > > + #clock-cells = <1>; > > + clock-output-names = "i2s_cdclk2"; > > + #sound-dai-cells = <1>; > > pinctrl-names = "default"; > > pinctrl-0 = <&i2s2_bus>; > > status = "disabled"; > > diff --git a/arch/arm/boot/dts/exynos5422-odroidxu3.dts b/arch/arm/boot/dts/exynos5422-odroidxu3.dts > > index edc25cf..9275ad6 100644 > > --- a/arch/arm/boot/dts/exynos5422-odroidxu3.dts > > +++ b/arch/arm/boot/dts/exynos5422-odroidxu3.dts > > @@ -11,6 +11,7 @@ > > */ > > > > /dts-v1/; > > +#include > > #include "exynos5800.dtsi" > > > > / { > > @@ -285,6 +286,62 @@ > > rtc@101E0000 { > > status = "okay"; > > }; > > + > > + sound: sound { > > + compatible = "simple-audio-card"; > > + assigned-clocks = <&clock_audss EXYNOS_MOUT_AUDSS>, > > + <&clock_audss EXYNOS_MOUT_I2S>, > > + <&clock_audss EXYNOS_DOUT_AUD_BUS>; > > + assigned-clock-parents = <&clock CLK_FIN_PLL>, > > + <&clock_audss EXYNOS_MOUT_AUDSS>; > > + assigned-clock-rates = <0>, > > + <0>, > > + <19200000>; > > The patch looks good, except it would be more appropriate to move the > above properties to &clock_audss { }; node in this file. > With that change feel free to add: > Reviewed-by: Sylwester Nawrocki > > As a side note, this is a dts patch and of course Kukjin maintains that. > You would likely get it applied sooner if you would have addressed it > directly to Kukjin, rather than Mark or me. > Yes, please. I'll apply this once you address comments per Sylwester's suggestion. Thanks, Kukjin