* [PATCH V2 1/7] ARM: dts: bcm283x: Fix pinctrl groups
2023-06-17 13:36 [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Stefan Wahren
@ 2023-06-17 13:36 ` Stefan Wahren
2023-06-23 20:59 ` Florian Fainelli
2023-06-17 13:36 ` [PATCH V2 2/7] dt-bindings: dma: convert bcm2835-dma bindings to YAML Stefan Wahren
` (7 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: Stefan Wahren @ 2023-06-17 13:36 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden, Jassi Brar,
Thierry Reding, Uwe Kleine-König, Daniel Lezcano,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Stefan Wahren
Currently the dtbs_check for bcm2837 generates warnings like this:
gpio@7e200000: 'pinctrl-0' is a dependency of 'pinctrl-names'
This is caused by the definition of pinctrl-names without matching
pinctrl group and vice versa. So defining both at the same place
make the dts files easier to review.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
arch/arm/boot/dts/bcm2835-rpi-a-plus.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-a.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-b-plus.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-b.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-cm1-io1.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi-zero-w.dts | 2 ++
arch/arm/boot/dts/bcm2835-rpi-zero.dts | 1 +
arch/arm/boot/dts/bcm2835-rpi.dtsi | 2 --
arch/arm/boot/dts/bcm2836-rpi-2-b.dts | 1 +
arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts | 1 +
arch/arm/boot/dts/bcm2837-rpi-zero-2-w.dts | 2 ++
12 files changed, 13 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
index 02ce817868ba..069b48272aa5 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-a-plus.dts
@@ -81,6 +81,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0 &i2s_alt0>;
/* I2S interface */
diff --git a/arch/arm/boot/dts/bcm2835-rpi-a.dts b/arch/arm/boot/dts/bcm2835-rpi-a.dts
index 3fdf60eb11dc..2726c00431e8 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-a.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-a.dts
@@ -83,6 +83,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0 &i2s_alt2>;
/* I2S interface */
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
index 9956fd06a4b6..c57b999a4520 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-plus.dts
@@ -83,6 +83,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0 &i2s_alt0>;
/* I2S interface */
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
index 4e1770afb145..ae6d3a9586ab 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b-rev2.dts
@@ -83,6 +83,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0 &i2s_alt2>;
/* I2S interface */
diff --git a/arch/arm/boot/dts/bcm2835-rpi-b.dts b/arch/arm/boot/dts/bcm2835-rpi-b.dts
index eec1d0892d33..72764be75a79 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-b.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-b.dts
@@ -83,6 +83,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0>;
};
diff --git a/arch/arm/boot/dts/bcm2835-rpi-cm1-io1.dts b/arch/arm/boot/dts/bcm2835-rpi-cm1-io1.dts
index 87958a96c3e0..3f9d198ac3ab 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-cm1-io1.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-cm1-io1.dts
@@ -73,6 +73,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0>;
};
diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
index dbf825985ec0..1f0b163e400c 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-zero-w.dts
@@ -97,6 +97,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0>;
};
@@ -111,6 +112,7 @@ &led_act {
};
&sdhci {
+ pinctrl-names = "default";
pinctrl-0 = <&emmc_gpio34 &gpclk2_gpio43>;
};
diff --git a/arch/arm/boot/dts/bcm2835-rpi-zero.dts b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
index f80e65a825fd..539c19c10946 100644
--- a/arch/arm/boot/dts/bcm2835-rpi-zero.dts
+++ b/arch/arm/boot/dts/bcm2835-rpi-zero.dts
@@ -85,6 +85,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0 &i2s_alt0>;
/* I2S interface */
diff --git a/arch/arm/boot/dts/bcm2835-rpi.dtsi b/arch/arm/boot/dts/bcm2835-rpi.dtsi
index ee9ee9d1fe65..f0acc9390f31 100644
--- a/arch/arm/boot/dts/bcm2835-rpi.dtsi
+++ b/arch/arm/boot/dts/bcm2835-rpi.dtsi
@@ -26,8 +26,6 @@ vchiq: mailbox@7e00b840 {
};
&gpio {
- pinctrl-names = "default";
-
gpioout: gpioout {
brcm,pins = <6>;
brcm,function = <BCM2835_FSEL_GPIO_OUT>;
diff --git a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
index 6068ec390081..79918033750e 100644
--- a/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
+++ b/arch/arm/boot/dts/bcm2836-rpi-2-b.dts
@@ -82,6 +82,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0 &i2s_alt0>;
/* I2S interface */
diff --git a/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts b/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts
index cf84e69fced8..72d26d130efa 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-cm3-io3.dts
@@ -72,6 +72,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0>;
};
diff --git a/arch/arm/boot/dts/bcm2837-rpi-zero-2-w.dts b/arch/arm/boot/dts/bcm2837-rpi-zero-2-w.dts
index b9cc4594398b..85cf594724ef 100644
--- a/arch/arm/boot/dts/bcm2837-rpi-zero-2-w.dts
+++ b/arch/arm/boot/dts/bcm2837-rpi-zero-2-w.dts
@@ -95,6 +95,7 @@ &gpio {
"SD_DATA2_R",
"SD_DATA3_R";
+ pinctrl-names = "default";
pinctrl-0 = <&gpioout &alt0>;
};
@@ -109,6 +110,7 @@ &led_act {
};
&sdhci {
+ pinctrl-names = "default";
pinctrl-0 = <&emmc_gpio34 &gpclk2_gpio43>;
};
--
2.34.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH V2 1/7] ARM: dts: bcm283x: Fix pinctrl groups
2023-06-17 13:36 ` [PATCH V2 1/7] ARM: dts: bcm283x: Fix pinctrl groups Stefan Wahren
@ 2023-06-23 20:59 ` Florian Fainelli
0 siblings, 0 replies; 21+ messages in thread
From: Florian Fainelli @ 2023-06-23 20:59 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Stefan Wahren, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, Ray Jui,
Scott Branden, Jassi Brar, Thierry Reding, Uwe Kleine-König,
Daniel Lezcano, Thomas Gleixner
Cc: Florian Fainelli, linux-arm-kernel, dmaengine, devicetree,
linux-mmc, linux-pwm, linux-pm
[-- Attachment #1: Type: text/plain, Size: 601 bytes --]
From: Florian Fainelli <f.fainelli@gmail.com>
On Sat, 17 Jun 2023 15:36:14 +0200, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> Currently the dtbs_check for bcm2837 generates warnings like this:
>
> gpio@7e200000: 'pinctrl-0' is a dependency of 'pinctrl-names'
>
> This is caused by the definition of pinctrl-names without matching
> pinctrl group and vice versa. So defining both at the same place
> make the dts files easier to review.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH V2 2/7] dt-bindings: dma: convert bcm2835-dma bindings to YAML
2023-06-17 13:36 [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Stefan Wahren
2023-06-17 13:36 ` [PATCH V2 1/7] ARM: dts: bcm283x: Fix pinctrl groups Stefan Wahren
@ 2023-06-17 13:36 ` Stefan Wahren
2023-06-19 22:49 ` Rob Herring
2023-06-20 14:38 ` Rob Herring
2023-06-17 13:36 ` [PATCH V2 3/7] ARM: dts: bcm2835: adjust DMA node names Stefan Wahren
` (6 subsequent siblings)
8 siblings, 2 replies; 21+ messages in thread
From: Stefan Wahren @ 2023-06-17 13:36 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden, Jassi Brar,
Thierry Reding, Uwe Kleine-König, Daniel Lezcano,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Stefan Wahren
Convert the DT binding document for bcm2835-dma from .txt to YAML.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
.../bindings/dma/brcm,bcm2835-dma.txt | 83 --------------
.../bindings/dma/brcm,bcm2835-dma.yaml | 102 ++++++++++++++++++
2 files changed, 102 insertions(+), 83 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
create mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
deleted file mode 100644
index b6a8cc0978cd..000000000000
--- a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
+++ /dev/null
@@ -1,83 +0,0 @@
-* BCM2835 DMA controller
-
-The BCM2835 DMA controller has 16 channels in total.
-Only the lower 13 channels have an associated IRQ.
-Some arbitrary channels are used by the firmware
-(1,3,6,7 in the current firmware version).
-The channels 0,2 and 3 have special functionality
-and should not be used by the driver.
-
-Required properties:
-- compatible: Should be "brcm,bcm2835-dma".
-- reg: Should contain DMA registers location and length.
-- interrupts: Should contain the DMA interrupts associated
- to the DMA channels in ascending order.
-- interrupt-names: Should contain the names of the interrupt
- in the form "dmaXX".
- Use "dma-shared-all" for the common interrupt line
- that is shared by all dma channels.
-- #dma-cells: Must be <1>, the cell in the dmas property of the
- client device represents the DREQ number.
-- brcm,dma-channel-mask: Bit mask representing the channels
- not used by the firmware in ascending order,
- i.e. first channel corresponds to LSB.
-
-Example:
-
-dma: dma@7e007000 {
- compatible = "brcm,bcm2835-dma";
- reg = <0x7e007000 0xf00>;
- interrupts = <1 16>,
- <1 17>,
- <1 18>,
- <1 19>,
- <1 20>,
- <1 21>,
- <1 22>,
- <1 23>,
- <1 24>,
- <1 25>,
- <1 26>,
- /* dma channel 11-14 share one irq */
- <1 27>,
- <1 27>,
- <1 27>,
- <1 27>,
- /* unused shared irq for all channels */
- <1 28>;
- interrupt-names = "dma0",
- "dma1",
- "dma2",
- "dma3",
- "dma4",
- "dma5",
- "dma6",
- "dma7",
- "dma8",
- "dma9",
- "dma10",
- "dma11",
- "dma12",
- "dma13",
- "dma14",
- "dma-shared-all";
-
- #dma-cells = <1>;
- brcm,dma-channel-mask = <0x7f35>;
-};
-
-
-DMA clients connected to the BCM2835 DMA controller must use the format
-described in the dma.txt file, using a two-cell specifier for each channel.
-
-Example:
-
-bcm2835_i2s: i2s@7e203000 {
- compatible = "brcm,bcm2835-i2s";
- reg = < 0x7e203000 0x24>;
- clocks = <&clocks BCM2835_CLOCK_PCM>;
-
- dmas = <&dma 2>,
- <&dma 3>;
- dma-names = "tx", "rx";
-};
diff --git a/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
new file mode 100644
index 000000000000..5de8421e933a
--- /dev/null
+++ b/Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
@@ -0,0 +1,102 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/dma/brcm,bcm2835-dma.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: BCM2835 DMA controller
+
+maintainers:
+ - Nicolas Saenz Julienne <nsaenz@kernel.org>
+
+description:
+ The BCM2835 DMA controller has 16 channels in total. Only the lower
+ 13 channels have an associated IRQ. Some arbitrary channels are used by the
+ VideoCore firmware (1,3,6,7 in the current firmware version). The channels
+ 0, 2 and 3 have special functionality and should not be used by the driver.
+
+allOf:
+ - $ref: dma-controller.yaml#
+
+properties:
+ compatible:
+ const: brcm,bcm2835-dma
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ description:
+ Should contain the DMA interrupts associated to the DMA channels in
+ ascending order.
+ minItems: 1
+ maxItems: 16
+
+ interrupt-names:
+ minItems: 1
+ maxItems: 16
+
+ '#dma-cells':
+ description: The single cell represents the DREQ number.
+ const: 1
+
+ brcm,dma-channel-mask:
+ $ref: /schemas/types.yaml#/definitions/uint32
+ description:
+ Bitmask of available DMA channels in ascending order that are
+ not reserved by firmware and are available to the
+ kernel. i.e. first channel corresponds to LSB.
+
+unevaluatedProperties: false
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - "#dma-cells"
+ - brcm,dma-channel-mask
+
+examples:
+ - |
+ dma-controller@7e007000 {
+ compatible = "brcm,bcm2835-dma";
+ reg = <0x7e007000 0xf00>;
+ interrupts = <1 16>,
+ <1 17>,
+ <1 18>,
+ <1 19>,
+ <1 20>,
+ <1 21>,
+ <1 22>,
+ <1 23>,
+ <1 24>,
+ <1 25>,
+ <1 26>,
+ /* dma channel 11-14 share one irq */
+ <1 27>,
+ <1 27>,
+ <1 27>,
+ <1 27>,
+ /* unused shared irq for all channels */
+ <1 28>;
+ interrupt-names = "dma0",
+ "dma1",
+ "dma2",
+ "dma3",
+ "dma4",
+ "dma5",
+ "dma6",
+ "dma7",
+ "dma8",
+ "dma9",
+ "dma10",
+ "dma11",
+ "dma12",
+ "dma13",
+ "dma14",
+ "dma-shared-all";
+ #dma-cells = <1>;
+ brcm,dma-channel-mask = <0x7f35>;
+ };
+
+...
--
2.34.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH V2 2/7] dt-bindings: dma: convert bcm2835-dma bindings to YAML
2023-06-17 13:36 ` [PATCH V2 2/7] dt-bindings: dma: convert bcm2835-dma bindings to YAML Stefan Wahren
@ 2023-06-19 22:49 ` Rob Herring
2023-06-20 4:50 ` Stefan Wahren
2023-06-20 14:38 ` Rob Herring
1 sibling, 1 reply; 21+ messages in thread
From: Rob Herring @ 2023-06-19 22:49 UTC (permalink / raw)
To: Stefan Wahren
Cc: Daniel Lezcano, Thierry Reding, Scott Branden, Florian Fainelli,
bcm-kernel-feedback-list, dmaengine, Thomas Gleixner, linux-pm,
Jassi Brar, devicetree, Uwe Kleine-König, Vinod Koul,
Rob Herring, Conor Dooley, linux-mmc, Krzysztof Kozlowski,
linux-arm-kernel, Ray Jui, linux-pwm
On Sat, 17 Jun 2023 15:36:15 +0200, Stefan Wahren wrote:
> Convert the DT binding document for bcm2835-dma from .txt to YAML.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> .../bindings/dma/brcm,bcm2835-dma.txt | 83 --------------
> .../bindings/dma/brcm,bcm2835-dma.yaml | 102 ++++++++++++++++++
> 2 files changed, 102 insertions(+), 83 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
> create mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
>
Please add Acked-by/Reviewed-by tags when posting new versions. However,
there's no need to repost patches *only* to add the tags. The upstream
maintainer will do that for acks received on the version they apply.
If a tag was not added on purpose, please state why and what changed.
Missing tags:
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH V2 2/7] dt-bindings: dma: convert bcm2835-dma bindings to YAML
2023-06-19 22:49 ` Rob Herring
@ 2023-06-20 4:50 ` Stefan Wahren
0 siblings, 0 replies; 21+ messages in thread
From: Stefan Wahren @ 2023-06-20 4:50 UTC (permalink / raw)
To: Rob Herring
Cc: Daniel Lezcano, Thierry Reding, Scott Branden, Florian Fainelli,
bcm-kernel-feedback-list, dmaengine, Thomas Gleixner, linux-pm,
Jassi Brar, devicetree, Uwe Kleine-König, Vinod Koul,
Rob Herring, Conor Dooley, linux-mmc, Krzysztof Kozlowski,
linux-arm-kernel, Ray Jui, linux-pwm
Hi Rob,
Am 20.06.23 um 00:49 schrieb Rob Herring:
> On Sat, 17 Jun 2023 15:36:15 +0200, Stefan Wahren wrote:
>> Convert the DT binding document for bcm2835-dma from .txt to YAML.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> ---
>> .../bindings/dma/brcm,bcm2835-dma.txt | 83 --------------
>> .../bindings/dma/brcm,bcm2835-dma.yaml | 102 ++++++++++++++++++
>> 2 files changed, 102 insertions(+), 83 deletions(-)
>> delete mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
>> create mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
>>
>
>
> Please add Acked-by/Reviewed-by tags when posting new versions. However,
> there's no need to repost patches *only* to add the tags. The upstream
> maintainer will do that for acks received on the version they apply.
>
> If a tag was not added on purpose, please state why and what changed.
i was uncertain after replacing the generic dma-channel-mask with the
vendor ones. So i decided to drop the reviewed-by.
Best regards
>
> Missing tags:
>
> Reviewed-by: Rob Herring <robh@kernel.org>
>
>
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH V2 2/7] dt-bindings: dma: convert bcm2835-dma bindings to YAML
2023-06-17 13:36 ` [PATCH V2 2/7] dt-bindings: dma: convert bcm2835-dma bindings to YAML Stefan Wahren
2023-06-19 22:49 ` Rob Herring
@ 2023-06-20 14:38 ` Rob Herring
1 sibling, 0 replies; 21+ messages in thread
From: Rob Herring @ 2023-06-20 14:38 UTC (permalink / raw)
To: Stefan Wahren
Cc: Scott Branden, Conor Dooley, linux-pm, Ray Jui, devicetree,
Florian Fainelli, linux-mmc, Daniel Lezcano, dmaengine,
Vinod Koul, Jassi Brar, linux-arm-kernel, Thierry Reding,
linux-pwm, Krzysztof Kozlowski, Thomas Gleixner,
bcm-kernel-feedback-list, Rob Herring, Uwe Kleine-König
On Sat, 17 Jun 2023 15:36:15 +0200, Stefan Wahren wrote:
> Convert the DT binding document for bcm2835-dma from .txt to YAML.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> .../bindings/dma/brcm,bcm2835-dma.txt | 83 --------------
> .../bindings/dma/brcm,bcm2835-dma.yaml | 102 ++++++++++++++++++
> 2 files changed, 102 insertions(+), 83 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.txt
> create mode 100644 Documentation/devicetree/bindings/dma/brcm,bcm2835-dma.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH V2 3/7] ARM: dts: bcm2835: adjust DMA node names
2023-06-17 13:36 [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Stefan Wahren
2023-06-17 13:36 ` [PATCH V2 1/7] ARM: dts: bcm283x: Fix pinctrl groups Stefan Wahren
2023-06-17 13:36 ` [PATCH V2 2/7] dt-bindings: dma: convert bcm2835-dma bindings to YAML Stefan Wahren
@ 2023-06-17 13:36 ` Stefan Wahren
2023-06-23 20:59 ` Florian Fainelli
2023-06-17 13:36 ` [PATCH V2 4/7] dt-bindings: pwm: convert pwm-bcm2835 bindings to YAML Stefan Wahren
` (5 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: Stefan Wahren @ 2023-06-17 13:36 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden, Jassi Brar,
Thierry Reding, Uwe Kleine-König, Daniel Lezcano,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Stefan Wahren
After converting the bcm2835-dma DT binding to YAML, the DT schema
checks gave warnings like:
$nodename:0: 'dma@7e007000' does not match '^dma-controller(@.*)?$'
So fix them accordingly.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
arch/arm/boot/dts/bcm2711.dtsi | 2 +-
arch/arm/boot/dts/bcm2835-common.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
index 097e9f252235..d30c19311145 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -76,7 +76,7 @@ thermal: thermal {
};
};
- dma: dma@7e007000 {
+ dma: dma-controller@7e007000 {
compatible = "brcm,bcm2835-dma";
reg = <0x7e007000 0xb00>;
interrupts = <GIC_SPI 80 IRQ_TYPE_LEVEL_HIGH>,
diff --git a/arch/arm/boot/dts/bcm2835-common.dtsi b/arch/arm/boot/dts/bcm2835-common.dtsi
index bb7e8f7facaf..9261b67dbee1 100644
--- a/arch/arm/boot/dts/bcm2835-common.dtsi
+++ b/arch/arm/boot/dts/bcm2835-common.dtsi
@@ -8,7 +8,7 @@ / {
interrupt-parent = <&intc>;
soc {
- dma: dma@7e007000 {
+ dma: dma-controller@7e007000 {
compatible = "brcm,bcm2835-dma";
reg = <0x7e007000 0xf00>;
interrupts = <1 16>,
--
2.34.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH V2 3/7] ARM: dts: bcm2835: adjust DMA node names
2023-06-17 13:36 ` [PATCH V2 3/7] ARM: dts: bcm2835: adjust DMA node names Stefan Wahren
@ 2023-06-23 20:59 ` Florian Fainelli
0 siblings, 0 replies; 21+ messages in thread
From: Florian Fainelli @ 2023-06-23 20:59 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Stefan Wahren, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, Ray Jui,
Scott Branden, Jassi Brar, Thierry Reding, Uwe Kleine-König,
Daniel Lezcano, Thomas Gleixner
Cc: Florian Fainelli, linux-arm-kernel, dmaengine, devicetree,
linux-mmc, linux-pwm, linux-pm
[-- Attachment #1: Type: text/plain, Size: 488 bytes --]
From: Florian Fainelli <f.fainelli@gmail.com>
On Sat, 17 Jun 2023 15:36:16 +0200, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> After converting the bcm2835-dma DT binding to YAML, the DT schema
> checks gave warnings like:
>
> $nodename:0: 'dma@7e007000' does not match '^dma-controller(@.*)?$'
>
> So fix them accordingly.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH V2 4/7] dt-bindings: pwm: convert pwm-bcm2835 bindings to YAML
2023-06-17 13:36 [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Stefan Wahren
` (2 preceding siblings ...)
2023-06-17 13:36 ` [PATCH V2 3/7] ARM: dts: bcm2835: adjust DMA node names Stefan Wahren
@ 2023-06-17 13:36 ` Stefan Wahren
2023-06-17 13:36 ` [PATCH V2 5/7] ARM: dts: bcm283x: Increase pwm-cells Stefan Wahren
` (4 subsequent siblings)
8 siblings, 0 replies; 21+ messages in thread
From: Stefan Wahren @ 2023-06-17 13:36 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden, Jassi Brar,
Thierry Reding, Uwe Kleine-König, Daniel Lezcano,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Stefan Wahren, Rob Herring
Convert the DT binding document for pwm-bcm2835 from .txt to YAML.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Rob Herring <robh@kernel.org>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
.../devicetree/bindings/pwm/pwm-bcm2835.txt | 30 -------------
.../devicetree/bindings/pwm/pwm-bcm2835.yaml | 43 +++++++++++++++++++
2 files changed, 43 insertions(+), 30 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt
create mode 100644 Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml
diff --git a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt
deleted file mode 100644
index f5753b3f79df..000000000000
--- a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.txt
+++ /dev/null
@@ -1,30 +0,0 @@
-BCM2835 PWM controller (Raspberry Pi controller)
-
-Required properties:
-- compatible: should be "brcm,bcm2835-pwm"
-- reg: physical base address and length of the controller's registers
-- clocks: This clock defines the base clock frequency of the PWM hardware
- system, the period and the duty_cycle of the PWM signal is a multiple of
- the base period.
-- #pwm-cells: Should be 3. See pwm.yaml in this directory for a description of
- the cells format.
-
-Examples:
-
-pwm@2020c000 {
- compatible = "brcm,bcm2835-pwm";
- reg = <0x2020c000 0x28>;
- clocks = <&clk_pwm>;
- #pwm-cells = <3>;
-};
-
-clocks {
- ....
- clk_pwm: pwm {
- compatible = "fixed-clock";
- reg = <3>;
- #clock-cells = <0>;
- clock-frequency = <9200000>;
- };
- ....
-};
diff --git a/Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml
new file mode 100644
index 000000000000..15e7fd98defc
--- /dev/null
+++ b/Documentation/devicetree/bindings/pwm/pwm-bcm2835.yaml
@@ -0,0 +1,43 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/pwm/pwm-bcm2835.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: BCM2835 PWM controller (Raspberry Pi controller)
+
+maintainers:
+ - Stefan Wahren <stefan.wahren@i2se.com>
+
+allOf:
+ - $ref: pwm.yaml#
+
+properties:
+ compatible:
+ const: brcm,bcm2835-pwm
+
+ reg:
+ maxItems: 1
+
+ clocks:
+ maxItems: 1
+
+ "#pwm-cells":
+ const: 3
+
+required:
+ - compatible
+ - reg
+ - clocks
+ - "#pwm-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ pwm@2020c000 {
+ compatible = "brcm,bcm2835-pwm";
+ reg = <0x2020c000 0x28>;
+ clocks = <&clk_pwm>;
+ #pwm-cells = <3>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* [PATCH V2 5/7] ARM: dts: bcm283x: Increase pwm-cells
2023-06-17 13:36 [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Stefan Wahren
` (3 preceding siblings ...)
2023-06-17 13:36 ` [PATCH V2 4/7] dt-bindings: pwm: convert pwm-bcm2835 bindings to YAML Stefan Wahren
@ 2023-06-17 13:36 ` Stefan Wahren
2023-06-23 21:00 ` Florian Fainelli
2023-06-17 13:36 ` [PATCH V2 6/7] dt-bindings: mailbox: convert bcm2835-mbox bindings to YAML Stefan Wahren
` (3 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: Stefan Wahren @ 2023-06-17 13:36 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden, Jassi Brar,
Thierry Reding, Uwe Kleine-König, Daniel Lezcano,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Stefan Wahren
The pwm-bcm2835 supports PWM polarity, so adjust the affected dtsi
files accordingly and fix the dtbs_check warning:
pwm@7e20c000: #pwm-cells:0:0: 3 was expected
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
---
arch/arm/boot/dts/bcm2711.dtsi | 2 +-
arch/arm/boot/dts/bcm283x.dtsi | 2 +-
2 files changed, 2 insertions(+), 2 deletions(-)
diff --git a/arch/arm/boot/dts/bcm2711.dtsi b/arch/arm/boot/dts/bcm2711.dtsi
index d30c19311145..4a379a14966d 100644
--- a/arch/arm/boot/dts/bcm2711.dtsi
+++ b/arch/arm/boot/dts/bcm2711.dtsi
@@ -278,7 +278,7 @@ pwm1: pwm@7e20c800 {
clocks = <&clocks BCM2835_CLOCK_PWM>;
assigned-clocks = <&clocks BCM2835_CLOCK_PWM>;
assigned-clock-rates = <10000000>;
- #pwm-cells = <2>;
+ #pwm-cells = <3>;
status = "disabled";
};
diff --git a/arch/arm/boot/dts/bcm283x.dtsi b/arch/arm/boot/dts/bcm283x.dtsi
index c9c52a19ef3b..2ca8a2505a4d 100644
--- a/arch/arm/boot/dts/bcm283x.dtsi
+++ b/arch/arm/boot/dts/bcm283x.dtsi
@@ -416,7 +416,7 @@ pwm: pwm@7e20c000 {
clocks = <&clocks BCM2835_CLOCK_PWM>;
assigned-clocks = <&clocks BCM2835_CLOCK_PWM>;
assigned-clock-rates = <10000000>;
- #pwm-cells = <2>;
+ #pwm-cells = <3>;
status = "disabled";
};
--
2.34.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH V2 5/7] ARM: dts: bcm283x: Increase pwm-cells
2023-06-17 13:36 ` [PATCH V2 5/7] ARM: dts: bcm283x: Increase pwm-cells Stefan Wahren
@ 2023-06-23 21:00 ` Florian Fainelli
0 siblings, 0 replies; 21+ messages in thread
From: Florian Fainelli @ 2023-06-23 21:00 UTC (permalink / raw)
To: bcm-kernel-feedback-list, Stefan Wahren, Vinod Koul, Rob Herring,
Krzysztof Kozlowski, Conor Dooley, Florian Fainelli, Ray Jui,
Scott Branden, Jassi Brar, Thierry Reding, Uwe Kleine-König,
Daniel Lezcano, Thomas Gleixner
Cc: Florian Fainelli, linux-arm-kernel, dmaengine, devicetree,
linux-mmc, linux-pwm, linux-pm
[-- Attachment #1: Type: text/plain, Size: 524 bytes --]
From: Florian Fainelli <f.fainelli@gmail.com>
On Sat, 17 Jun 2023 15:36:18 +0200, Stefan Wahren <stefan.wahren@i2se.com> wrote:
> The pwm-bcm2835 supports PWM polarity, so adjust the affected dtsi
> files accordingly and fix the dtbs_check warning:
>
> pwm@7e20c000: #pwm-cells:0:0: 3 was expected
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Reviewed-by: Uwe Kleine-König <u.kleine-koenig@pengutronix.de>
> ---
Applied to https://github.com/Broadcom/stblinux/commits/devicetree/next, thanks!
--
Florian
[-- Attachment #2: S/MIME Cryptographic Signature --]
[-- Type: application/pkcs7-signature, Size: 4221 bytes --]
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH V2 6/7] dt-bindings: mailbox: convert bcm2835-mbox bindings to YAML
2023-06-17 13:36 [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Stefan Wahren
` (4 preceding siblings ...)
2023-06-17 13:36 ` [PATCH V2 5/7] ARM: dts: bcm283x: Increase pwm-cells Stefan Wahren
@ 2023-06-17 13:36 ` Stefan Wahren
2023-06-20 14:39 ` Rob Herring
2023-06-17 13:36 ` [PATCH V2 7/7] dt-bindings: timer: convert bcm2835-system-timer " Stefan Wahren
` (2 subsequent siblings)
8 siblings, 1 reply; 21+ messages in thread
From: Stefan Wahren @ 2023-06-17 13:36 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden, Jassi Brar,
Thierry Reding, Uwe Kleine-König, Daniel Lezcano,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Stefan Wahren
Convert the DT binding document for bcm2835-mbox from .txt to YAML.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
---
.../bindings/mailbox/brcm,bcm2835-mbox.txt | 26 ------------
.../bindings/mailbox/brcm,bcm2835-mbox.yaml | 40 +++++++++++++++++++
2 files changed, 40 insertions(+), 26 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt
create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.yaml
diff --git a/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt b/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt
deleted file mode 100644
index b48d7d30012c..000000000000
--- a/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt
+++ /dev/null
@@ -1,26 +0,0 @@
-Broadcom BCM2835 VideoCore mailbox IPC
-
-Required properties:
-
-- compatible: Should be "brcm,bcm2835-mbox"
-- reg: Specifies base physical address and size of the registers
-- interrupts: The interrupt number
- See bindings/interrupt-controller/brcm,bcm2835-armctrl-ic.txt
-- #mbox-cells: Specifies the number of cells needed to encode a mailbox
- channel. The value shall be 0, since there is only one
- mailbox channel implemented by the device.
-
-Example:
-
-mailbox: mailbox@7e00b880 {
- compatible = "brcm,bcm2835-mbox";
- reg = <0x7e00b880 0x40>;
- interrupts = <0 1>;
- #mbox-cells = <0>;
-};
-
-firmware: firmware {
- compatible = "raspberrypi,firmware";
- mboxes = <&mailbox>;
- #power-domain-cells = <1>;
-};
diff --git a/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.yaml b/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.yaml
new file mode 100644
index 000000000000..9588817f4511
--- /dev/null
+++ b/Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.yaml
@@ -0,0 +1,40 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/mailbox/brcm,bcm2835-mbox.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: Broadcom BCM2835 VideoCore mailbox IPC
+
+maintainers:
+ - Stefan Wahren <stefan.wahren@i2se.com>
+
+properties:
+ compatible:
+ const: brcm,bcm2835-mbox
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ maxItems: 1
+
+ "#mbox-cells":
+ const: 0
+
+required:
+ - compatible
+ - reg
+ - interrupts
+ - "#mbox-cells"
+
+additionalProperties: false
+
+examples:
+ - |
+ mailbox@7e00b880 {
+ compatible = "brcm,bcm2835-mbox";
+ reg = <0x7e00b880 0x40>;
+ interrupts = <0 1>;
+ #mbox-cells = <0>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH V2 6/7] dt-bindings: mailbox: convert bcm2835-mbox bindings to YAML
2023-06-17 13:36 ` [PATCH V2 6/7] dt-bindings: mailbox: convert bcm2835-mbox bindings to YAML Stefan Wahren
@ 2023-06-20 14:39 ` Rob Herring
0 siblings, 0 replies; 21+ messages in thread
From: Rob Herring @ 2023-06-20 14:39 UTC (permalink / raw)
To: Stefan Wahren
Cc: linux-arm-kernel, devicetree, linux-pm, linux-pwm,
Krzysztof Kozlowski, Uwe Kleine-König, Thierry Reding,
Conor Dooley, Ray Jui, Daniel Lezcano, Florian Fainelli,
linux-mmc, Vinod Koul, Jassi Brar, bcm-kernel-feedback-list,
Rob Herring, dmaengine, Thomas Gleixner, Scott Branden
On Sat, 17 Jun 2023 15:36:19 +0200, Stefan Wahren wrote:
> Convert the DT binding document for bcm2835-mbox from .txt to YAML.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> ---
> .../bindings/mailbox/brcm,bcm2835-mbox.txt | 26 ------------
> .../bindings/mailbox/brcm,bcm2835-mbox.yaml | 40 +++++++++++++++++++
> 2 files changed, 40 insertions(+), 26 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.txt
> create mode 100644 Documentation/devicetree/bindings/mailbox/brcm,bcm2835-mbox.yaml
>
Reviewed-by: Rob Herring <robh@kernel.org>
^ permalink raw reply [flat|nested] 21+ messages in thread
* [PATCH V2 7/7] dt-bindings: timer: convert bcm2835-system-timer bindings to YAML
2023-06-17 13:36 [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Stefan Wahren
` (5 preceding siblings ...)
2023-06-17 13:36 ` [PATCH V2 6/7] dt-bindings: mailbox: convert bcm2835-mbox bindings to YAML Stefan Wahren
@ 2023-06-17 13:36 ` Stefan Wahren
2023-06-19 17:00 ` Daniel Lezcano
2023-06-23 14:51 ` (subset) [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Thierry Reding
2023-07-11 16:43 ` Vinod Koul
8 siblings, 1 reply; 21+ messages in thread
From: Stefan Wahren @ 2023-06-17 13:36 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden, Jassi Brar,
Thierry Reding, Uwe Kleine-König, Daniel Lezcano,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Stefan Wahren, Rob Herring
Convert the DT binding document for bcm2835-system-timer from .txt
to YAML.
Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
Reviewed-by: Rob Herring <robh@kernel.org>
---
.../timer/brcm,bcm2835-system-timer.txt | 22 ---------
.../timer/brcm,bcm2835-system-timer.yaml | 48 +++++++++++++++++++
2 files changed, 48 insertions(+), 22 deletions(-)
delete mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
create mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
deleted file mode 100644
index 844bd5fbd04c..000000000000
--- a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
+++ /dev/null
@@ -1,22 +0,0 @@
-BCM2835 System Timer
-
-The System Timer peripheral provides four 32-bit timer channels and a
-single 64-bit free running counter. Each channel has an output compare
-register, which is compared against the 32 least significant bits of the
-free running counter values, and generates an interrupt.
-
-Required properties:
-
-- compatible : should be "brcm,bcm2835-system-timer"
-- reg : Specifies base physical address and size of the registers.
-- interrupts : A list of 4 interrupt sinks; one per timer channel.
-- clock-frequency : The frequency of the clock that drives the counter, in Hz.
-
-Example:
-
-timer {
- compatible = "brcm,bcm2835-system-timer";
- reg = <0x7e003000 0x1000>;
- interrupts = <1 0>, <1 1>, <1 2>, <1 3>;
- clock-frequency = <1000000>;
-};
diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
new file mode 100644
index 000000000000..227b44788a48
--- /dev/null
+++ b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
@@ -0,0 +1,48 @@
+# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
+%YAML 1.2
+---
+$id: http://devicetree.org/schemas/timer/brcm,bcm2835-system-timer.yaml#
+$schema: http://devicetree.org/meta-schemas/core.yaml#
+
+title: BCM2835 System Timer
+
+maintainers:
+ - Stefan Wahren <stefan.wahren@i2se.com>
+
+description:
+ The System Timer peripheral provides four 32-bit timer channels and a
+ single 64-bit free running counter. Each channel has an output compare
+ register, which is compared against the 32 least significant bits of the
+ free running counter values, and generates an interrupt.
+
+properties:
+ compatible:
+ const: brcm,bcm2835-system-timer
+
+ reg:
+ maxItems: 1
+
+ interrupts:
+ items:
+ - description: System Timer Compare 0 match (used by VideoCore GPU)
+ - description: System Timer Compare 1 match (usable for ARM core)
+ - description: System Timer Compare 2 match (used by VideoCore GPU)
+ - description: System Timer Compare 3 match (usable for ARM core)
+
+ clock-frequency: true
+
+required:
+ - compatible
+ - reg
+ - interrupts
+
+additionalProperties: false
+
+examples:
+ - |
+ timer@7e003000 {
+ compatible = "brcm,bcm2835-system-timer";
+ reg = <0x7e003000 0x1000>;
+ interrupts = <1 0>, <1 1>, <1 2>, <1 3>;
+ clock-frequency = <1000000>;
+ };
--
2.34.1
^ permalink raw reply related [flat|nested] 21+ messages in thread* Re: [PATCH V2 7/7] dt-bindings: timer: convert bcm2835-system-timer bindings to YAML
2023-06-17 13:36 ` [PATCH V2 7/7] dt-bindings: timer: convert bcm2835-system-timer " Stefan Wahren
@ 2023-06-19 17:00 ` Daniel Lezcano
2023-06-19 18:57 ` Stefan Wahren
0 siblings, 1 reply; 21+ messages in thread
From: Daniel Lezcano @ 2023-06-19 17:00 UTC (permalink / raw)
To: Stefan Wahren, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Florian Fainelli, Ray Jui, Scott Branden,
Jassi Brar, Thierry Reding, Uwe Kleine-König,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Rob Herring
On 17/06/2023 15:36, Stefan Wahren wrote:
> Convert the DT binding document for bcm2835-system-timer from .txt
> to YAML.
>
> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
> Reviewed-by: Rob Herring <robh@kernel.org>
> ---
> .../timer/brcm,bcm2835-system-timer.txt | 22 ---------
> .../timer/brcm,bcm2835-system-timer.yaml | 48 +++++++++++++++++++
> 2 files changed, 48 insertions(+), 22 deletions(-)
> delete mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
> create mode 100644 Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
>
> diff --git a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
> deleted file mode 100644
> index 844bd5fbd04c..000000000000
> --- a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
Appliedp patch #7
Thanks
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH V2 7/7] dt-bindings: timer: convert bcm2835-system-timer bindings to YAML
2023-06-19 17:00 ` Daniel Lezcano
@ 2023-06-19 18:57 ` Stefan Wahren
2023-06-19 20:00 ` Daniel Lezcano
2023-06-26 18:16 ` Stefan Wahren
0 siblings, 2 replies; 21+ messages in thread
From: Stefan Wahren @ 2023-06-19 18:57 UTC (permalink / raw)
To: Daniel Lezcano, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Florian Fainelli, Ray Jui, Scott Branden,
Jassi Brar, Thierry Reding, Uwe Kleine-König,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Rob Herring
Hi Daniel,
Am 19.06.23 um 19:00 schrieb Daniel Lezcano:
> On 17/06/2023 15:36, Stefan Wahren wrote:
>> Convert the DT binding document for bcm2835-system-timer from .txt
>> to YAML.
>>
>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>> Reviewed-by: Rob Herring <robh@kernel.org>
>> ---
>> .../timer/brcm,bcm2835-system-timer.txt | 22 ---------
>> .../timer/brcm,bcm2835-system-timer.yaml | 48 +++++++++++++++++++
>> 2 files changed, 48 insertions(+), 22 deletions(-)
>> delete mode 100644
>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>> create mode 100644
>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
>>
>> diff --git
>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>> deleted file mode 100644
>> index 844bd5fbd04c..000000000000
>> ---
>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>
> Appliedp patch #7
i'm so sorry but i accidentially added a Reviewed-by from Rob, which is
wrong here. I should have added to the patch 6 :-(
Regards Stefan
>
> Thanks
>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH V2 7/7] dt-bindings: timer: convert bcm2835-system-timer bindings to YAML
2023-06-19 18:57 ` Stefan Wahren
@ 2023-06-19 20:00 ` Daniel Lezcano
2023-06-26 18:16 ` Stefan Wahren
1 sibling, 0 replies; 21+ messages in thread
From: Daniel Lezcano @ 2023-06-19 20:00 UTC (permalink / raw)
To: Stefan Wahren, Vinod Koul, Rob Herring, Krzysztof Kozlowski,
Conor Dooley, Florian Fainelli, Ray Jui, Scott Branden,
Jassi Brar, Thierry Reding, Uwe Kleine-König,
Thomas Gleixner
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list, Rob Herring
On 19/06/2023 20:57, Stefan Wahren wrote:
> Hi Daniel,
>
> Am 19.06.23 um 19:00 schrieb Daniel Lezcano:
>> On 17/06/2023 15:36, Stefan Wahren wrote:
>>> Convert the DT binding document for bcm2835-system-timer from .txt
>>> to YAML.
>>>
>>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../timer/brcm,bcm2835-system-timer.txt | 22 ---------
>>> .../timer/brcm,bcm2835-system-timer.yaml | 48 +++++++++++++++++++
>>> 2 files changed, 48 insertions(+), 22 deletions(-)
>>> delete mode 100644
>>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>> create mode 100644
>>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>> deleted file mode 100644
>>> index 844bd5fbd04c..000000000000
>>> ---
>>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>
>> Appliedp patch #7
>
> i'm so sorry but i accidentially added a Reviewed-by from Rob, which is
> wrong here. I should have added to the patch 6 :-(
No worries, I'll drop the patch and wait for its Acked-by
--
<http://www.linaro.org/> Linaro.org │ Open source software for ARM SoCs
Follow Linaro: <http://www.facebook.com/pages/Linaro> Facebook |
<http://twitter.com/#!/linaroorg> Twitter |
<http://www.linaro.org/linaro-blog/> Blog
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: [PATCH V2 7/7] dt-bindings: timer: convert bcm2835-system-timer bindings to YAML
2023-06-19 18:57 ` Stefan Wahren
2023-06-19 20:00 ` Daniel Lezcano
@ 2023-06-26 18:16 ` Stefan Wahren
1 sibling, 0 replies; 21+ messages in thread
From: Stefan Wahren @ 2023-06-26 18:16 UTC (permalink / raw)
To: Rob Herring, Rob Herring
Cc: linux-arm-kernel, Ray Jui, dmaengine, Florian Fainelli,
devicetree, linux-mmc, linux-pwm, Jassi Brar, Daniel Lezcano,
Thomas Gleixner, Thierry Reding, Uwe Kleine-König,
Krzysztof Kozlowski, linux-pm, bcm-kernel-feedback-list,
Vinod Koul, Conor Dooley, Scott Branden
Hi Rob,
Am 19.06.23 um 20:57 schrieb Stefan Wahren:
> Hi Daniel,
>
> Am 19.06.23 um 19:00 schrieb Daniel Lezcano:
>> On 17/06/2023 15:36, Stefan Wahren wrote:
>>> Convert the DT binding document for bcm2835-system-timer from .txt
>>> to YAML.
>>>
>>> Signed-off-by: Stefan Wahren <stefan.wahren@i2se.com>
>>> Reviewed-by: Rob Herring <robh@kernel.org>
>>> ---
>>> .../timer/brcm,bcm2835-system-timer.txt | 22 ---------
>>> .../timer/brcm,bcm2835-system-timer.yaml | 48 +++++++++++++++++++
>>> 2 files changed, 48 insertions(+), 22 deletions(-)
>>> delete mode 100644
>>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>> create mode 100644
>>> Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.yaml
>>>
>>> diff --git
>>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt b/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>> deleted file mode 100644
>>> index 844bd5fbd04c..000000000000
>>> ---
>>> a/Documentation/devicetree/bindings/timer/brcm,bcm2835-system-timer.txt
>>
>> Appliedp patch #7
>
> i'm so sorry but i accidentially added a Reviewed-by from Rob, which is
> wrong here. I should have added to the patch 6 :-(
did you noticed the problem about the accidentially wrong added Reviewed-by?
Best regards
>
> Regards Stefan
>
>>
>> Thanks
>>
^ permalink raw reply [flat|nested] 21+ messages in thread
* Re: (subset) [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings
2023-06-17 13:36 [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Stefan Wahren
` (6 preceding siblings ...)
2023-06-17 13:36 ` [PATCH V2 7/7] dt-bindings: timer: convert bcm2835-system-timer " Stefan Wahren
@ 2023-06-23 14:51 ` Thierry Reding
2023-07-11 16:43 ` Vinod Koul
8 siblings, 0 replies; 21+ messages in thread
From: Thierry Reding @ 2023-06-23 14:51 UTC (permalink / raw)
To: Vinod Koul, Rob Herring, Krzysztof Kozlowski, Conor Dooley,
Florian Fainelli, Ray Jui, Scott Branden, Jassi Brar,
Uwe Kleine-König, Daniel Lezcano, Thomas Gleixner,
Stefan Wahren
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list
On Sat, 17 Jun 2023 15:36:13 +0200, Stefan Wahren wrote:
> This series fix some dtbs_check warning for the Raspberry Pi boards
> and convert 4 txt DT bindings for BCM2835 to YAML.
>
> Changes in V2:
> - drop already applied patches (bcm2835-sdhost, bcm2835-thermal)
> - drop patch "dmaengine: bcm2835: also support generic dma-channel-mask"
> - keep brcm,bcm2835-dma for ABI compatibility which also resolve
> dependency between patch 2 and 3
> - drop quotes in patch 2 as noted by Rob Herring
> - add interrupt description as suggested by Rob
> - add Rob's and Uwe's Reviewed-by
>
> [...]
Applied, thanks!
[4/7] dt-bindings: pwm: convert pwm-bcm2835 bindings to YAML
commit: 92554cdd428fce212d2a71a06939e7cab90f7c77
Best regards,
--
Thierry Reding <thierry.reding@gmail.com>
^ permalink raw reply [flat|nested] 21+ messages in thread* Re: (subset) [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings
2023-06-17 13:36 [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Stefan Wahren
` (7 preceding siblings ...)
2023-06-23 14:51 ` (subset) [PATCH V2 0/7] ARM: dts: bcm283x: Improve device-trees and bindings Thierry Reding
@ 2023-07-11 16:43 ` Vinod Koul
8 siblings, 0 replies; 21+ messages in thread
From: Vinod Koul @ 2023-07-11 16:43 UTC (permalink / raw)
To: Rob Herring, Krzysztof Kozlowski, Conor Dooley, Florian Fainelli,
Ray Jui, Scott Branden, Jassi Brar, Thierry Reding,
Uwe Kleine-König, Daniel Lezcano, Thomas Gleixner,
Stefan Wahren
Cc: linux-arm-kernel, dmaengine, devicetree, linux-mmc, linux-pwm,
linux-pm, bcm-kernel-feedback-list
On Sat, 17 Jun 2023 15:36:13 +0200, Stefan Wahren wrote:
> This series fix some dtbs_check warning for the Raspberry Pi boards
> and convert 4 txt DT bindings for BCM2835 to YAML.
>
> Changes in V2:
> - drop already applied patches (bcm2835-sdhost, bcm2835-thermal)
> - drop patch "dmaengine: bcm2835: also support generic dma-channel-mask"
> - keep brcm,bcm2835-dma for ABI compatibility which also resolve
> dependency between patch 2 and 3
> - drop quotes in patch 2 as noted by Rob Herring
> - add interrupt description as suggested by Rob
> - add Rob's and Uwe's Reviewed-by
>
> [...]
Applied, thanks!
[2/7] dt-bindings: dma: convert bcm2835-dma bindings to YAML
commit: c60d5060b019e8095df7eebd1716747edfbd192a
Best regards,
--
~Vinod
^ permalink raw reply [flat|nested] 21+ messages in thread