devicetree.vger.kernel.org archive mirror
 help / color / mirror / Atom feed
From: "Li, Hua Qian" <HuaQian.Li@siemens.com>
To: "wim@linux-watchdog.org" <wim@linux-watchdog.org>,
	"linux@roeck-us.net" <linux@roeck-us.net>,
	"conor+dt@kernel.org" <conor+dt@kernel.org>,
	"krzysztof.kozlowski+dt@linaro.org" 
	<krzysztof.kozlowski+dt@linaro.org>,
	"krzysztof.kozlowski@linaro.org" <krzysztof.kozlowski@linaro.org>,
	"robh+dt@kernel.org" <robh+dt@kernel.org>
Cc: "kristo@kernel.org" <kristo@kernel.org>,
	"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
	"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
	"huaqianlee@gmail.com" <huaqianlee@gmail.com>,
	"nm@ti.com" <nm@ti.com>, "vigneshr@ti.com" <vigneshr@ti.com>,
	"Kiszka, Jan" <jan.kiszka@siemens.com>,
	"linux-arm-kernel@lists.infradead.org" 
	<linux-arm-kernel@lists.infradead.org>,
	"Su, Bao Cheng" <baocheng.su@siemens.com>,
	"linux-watchdog@vger.kernel.org" <linux-watchdog@vger.kernel.org>
Subject: Re: [PATCH v2 2/3] arm64: dts: ti: Add reserved memory for watchdog
Date: Wed, 12 Jul 2023 01:48:09 +0000	[thread overview]
Message-ID: <02dfb5562da08fa95c8eba9c727dfc8bbaad07be.camel@siemens.com> (raw)
In-Reply-To: <7e1332bc-0757-bbe8-e087-7a0e52d6b97b@linaro.org>

On Tue, 2023-07-11 at 11:24 +0200, Krzysztof Kozlowski wrote:
> On 11/07/2023 11:17, huaqian.li@siemens.com wrote:
> > From: Li Hua Qian <huaqian.li@siemens.com>
> > 
> > This patch adds a reserved memory for the TI AM65X platform
> > watchdog to
> > reserve the specific info, triggering the watchdog reset in last
> > boot,
> > to know if the board reboot is due to a watchdog reset.
> > 
> > Signed-off-by: Li Hua Qian <huaqian.li@siemens.com>
> > ---
> >  arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi | 11
> > +++++++++++
> >  1 file changed, 11 insertions(+)
> > 
> > diff --git a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > index e26bd988e522..77380e52a334 100644
> > --- a/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > +++ b/arch/arm64/boot/dts/ti/k3-am65-iot2050-common.dtsi
> > @@ -63,6 +63,12 @@ rtos_ipc_memory_region: ipc-memories@a2000000 {
> >                         alignment = <0x1000>;
> >                         no-map;
> >                 };
> > +
> > +               /* To reserve the power-on(PON) reason for watchdog
> > reset */
> > +               wdt_reset_memory_region: wdt-memory@a2200000 {
> > +                       reg = <0x00 0xa2200000 0x00 0x00001000>;
> > +                       no-map;
> > +               };
> >         };
> >  
> >         leds {
> > @@ -718,3 +724,8 @@ &mcu_r5fss0_core1 {
> >                         <&mcu_r5fss0_core1_memory_region>;
> >         mboxes = <&mailbox0_cluster1>, <&mbox_mcu_r5fss0_core1>;
> >  };
> > +
> > +&mcu_rti1 {
> > +       reg = <0x0 0x40610000 0x0 0x100>,
> > +             <0x0 0xa2200000 0x0 0x1000>;
> 
> That's a total mess. reserved memory and IO address space. Nope.
> 
> 
> 
> Best regards,
> Krzysztof
> 
Yes, I misunderstood the advice. I intend to roll back as I mentioned
in my last email. Any new suggestions please let me know, thank you!

Best regards,
Li Hua Qian


  reply	other threads:[~2023-07-12  1:48 UTC|newest]

Thread overview: 15+ messages / expand[flat|nested]  mbox.gz  Atom feed  top
2023-07-11  9:17 [PATCH v2 0/3] Add support for WDIOF_CARDRESET on TI AM65x huaqian.li
2023-07-11  9:17 ` [PATCH v2 1/3] dt-bindings: watchdog: ti,rti-wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-11  9:23   ` Krzysztof Kozlowski
2023-07-12  1:40     ` Li, Hua Qian
2023-07-11 10:13   ` Rob Herring
2023-07-12  1:42     ` Li, Hua Qian
2023-07-11  9:17 ` [PATCH v2 2/3] arm64: dts: ti: Add reserved memory for watchdog huaqian.li
2023-07-11  9:24   ` Krzysztof Kozlowski
2023-07-12  1:48     ` Li, Hua Qian [this message]
2023-07-11  9:17 ` [PATCH v2 3/3] watchdog:rit_wdt: Add support for WDIOF_CARDRESET huaqian.li
2023-07-12  2:32   ` Guenter Roeck
2023-07-12  4:03     ` Li, Hua Qian
2023-07-12  5:01       ` Guenter Roeck
2023-07-12  6:05         ` Li, Hua Qian
2023-07-12  9:34           ` Jan Kiszka

Reply instructions:

You may reply publicly to this message via plain-text email
using any one of the following methods:

* Save the following mbox file, import it into your mail client,
  and reply-to-all from there: mbox

  Avoid top-posting and favor interleaved quoting:
  https://en.wikipedia.org/wiki/Posting_style#Interleaved_style

* Reply using the --to, --cc, and --in-reply-to
  switches of git-send-email(1):

  git send-email \
    --in-reply-to=02dfb5562da08fa95c8eba9c727dfc8bbaad07be.camel@siemens.com \
    --to=huaqian.li@siemens.com \
    --cc=baocheng.su@siemens.com \
    --cc=conor+dt@kernel.org \
    --cc=devicetree@vger.kernel.org \
    --cc=huaqianlee@gmail.com \
    --cc=jan.kiszka@siemens.com \
    --cc=kristo@kernel.org \
    --cc=krzysztof.kozlowski+dt@linaro.org \
    --cc=krzysztof.kozlowski@linaro.org \
    --cc=linux-arm-kernel@lists.infradead.org \
    --cc=linux-kernel@vger.kernel.org \
    --cc=linux-watchdog@vger.kernel.org \
    --cc=linux@roeck-us.net \
    --cc=nm@ti.com \
    --cc=robh+dt@kernel.org \
    --cc=vigneshr@ti.com \
    --cc=wim@linux-watchdog.org \
    /path/to/YOUR_REPLY

  https://kernel.org/pub/software/scm/git/docs/git-send-email.html

* If your mail client supports setting the In-Reply-To header
  via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).