Re: [PATCH v2 4/4] crypto: jz4780-rng: Enable PRNG support in CI20 defconfig

[Harvey Hunt <Harvey.Hunt@imgtec.com>]

Hi PrasannaKumar,

On 23/08/17 15:50, PrasannaKumar Muralidharan wrote:
> Hi Harvey,
> 
> On 23 August 2017 at 14:39, Harvey Hunt <Harvey.Hunt@imgtec.com> wrote:
>> Hi PrasannaKumar,
>>
>> On 23/08/17 03:57, PrasannaKumar Muralidharan wrote:
>>>
>>> Enable PRNG driver support in MIPS Creator CI20 default config.
>>>
>>> Signed-off-by: PrasannaKumar Muralidharan <prasannatsmkumar@gmail.com>
>>> ---
>>> No changes in v2
>>>
>>>    arch/mips/configs/ci20_defconfig | 5 +++++
>>>    1 file changed, 5 insertions(+)
>>>
>>> diff --git a/arch/mips/configs/ci20_defconfig
>>> b/arch/mips/configs/ci20_defconfig
>>> index b42cfa7..9f48f2c 100644
>>> --- a/arch/mips/configs/ci20_defconfig
>>> +++ b/arch/mips/configs/ci20_defconfig
>>> @@ -88,6 +88,11 @@ CONFIG_SERIAL_8250_RUNTIME_UARTS=5
>>>    CONFIG_SERIAL_8250_INGENIC=y
>>>    CONFIG_SERIAL_OF_PLATFORM=y
>>>    # CONFIG_HW_RANDOM is not set
>>> +CONFIG_CRYPTO_USER=y
>>> +CONFIG_CRYPTO_USER_API=y
>>> +CONFIG_CRYPTO_USER_API_RNG=y
>>> +CONFIG_CRYPTO_HW=y
>>> +CONFIG_CRYPTO_DEV_JZ4780_RNG=y
>>>    CONFIG_I2C=y
>>>    CONFIG_I2C_JZ4780=y
>>>    CONFIG_GPIO_SYSFS=y
>>>
>>
>> You need to regenerate your defconfig as it is missing CONFIG_MFD_SYSCON.
>>
>> Thanks,
>>
>> Harvey
> 
> CONFIG_MFD_SYSCON gets selected when CONFIG_CRYPTO_DEV_JZ4780_RNG is
> selected. Please see the Kconfig changes. Given that should I add it
> in ci20_defconfig? If it is required I will add and send a new
> version.

Oops, I hadn't noticed that - just skimmed the patches before my morning 
coffee. :-)

It's fine as is, excuse the noise.

> 
> Thanks,
> PrasannaKumar
> 

Thanks,

Harvey