From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4B9F7EB64D9 for ; Fri, 30 Jun 2023 01:57:09 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S229793AbjF3B5I (ORCPT ); Thu, 29 Jun 2023 21:57:08 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:47472 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S229730AbjF3B5H (ORCPT ); Thu, 29 Jun 2023 21:57:07 -0400 Received: from fd01.gateway.ufhost.com (fd01.gateway.ufhost.com [61.152.239.71]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 67985C0; Thu, 29 Jun 2023 18:57:05 -0700 (PDT) Received: from EXMBX165.cuchost.com (unknown [175.102.18.54]) (using TLSv1 with cipher DHE-RSA-AES256-SHA (256/256 bits)) (Client CN "EXMBX165", Issuer "EXMBX165" (not verified)) by fd01.gateway.ufhost.com (Postfix) with ESMTP id 0DD8124DE30; Fri, 30 Jun 2023 09:57:04 +0800 (CST) Received: from EXMBX172.cuchost.com (172.16.6.92) by EXMBX165.cuchost.com (172.16.6.75) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 09:57:04 +0800 Received: from [192.168.125.93] (183.27.97.206) by EXMBX172.cuchost.com (172.16.6.92) with Microsoft SMTP Server (TLS) id 15.0.1497.42; Fri, 30 Jun 2023 09:57:03 +0800 Message-ID: <0312262c-28c0-9445-c6f7-2079a57db8c7@starfivetech.com> Date: Fri, 30 Jun 2023 09:57:02 +0800 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (Windows NT 10.0; Win64; x64; rv:102.0) Gecko/20100101 Thunderbird/102.3.2 Subject: Re: [PATCH v1 1/5] ASoC: dt-bindings: Add StarFive JH7110 dummy PWM-DAC transmitter Content-Language: en-US To: Krzysztof Kozlowski , Mark Brown , Liam Girdwood , Jaroslav Kysela , Takashi Iwai , Rob Herring , Krzysztof Kozlowski , Conor Dooley , "Walker Chen" , Xingyu Wu , Emil Renner Berthing CC: , , , References: <20230626110909.38718-1-hal.feng@starfivetech.com> <20230626110909.38718-2-hal.feng@starfivetech.com> <006ddacd-0496-70d1-3310-99b16706de84@linaro.org> From: Hal Feng In-Reply-To: <006ddacd-0496-70d1-3310-99b16706de84@linaro.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 7bit X-Originating-IP: [183.27.97.206] X-ClientProxiedBy: EXCAS066.cuchost.com (172.16.6.26) To EXMBX172.cuchost.com (172.16.6.92) X-YovoleRuleAgent: yovoleflag Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Mon, 26 Jun 2023 17:34:56 +0200, Krzysztof Kozlowski wrote: > On 26/06/2023 13:09, Hal Feng wrote: >> Add bindings for StarFive JH7110 dummy PWM-DAC transmitter. > > ... > >> +required: >> + - compatible >> + - "#sound-dai-cells" >> + >> +additionalProperties: false >> + >> +examples: >> + - | >> + pwmdac-dit { >> + compatible = "starfive,jh7110-pwmdac-dit"; >> + #sound-dai-cells = <0>; > > BTW, I don't see any resources here. Neither in the driver. I think you > just added this for driver, not for a real hardware. Yes, this is a dummy PWM-DAC transmitter as described in the title. The StarFive JH7110 PWM-DAC module doesn't need a hardware codec, but a dummy codec is needed for the driver. For a similar implementation, you can refer to sound/soc/codecs/spdif_transmitter.c Best regards, Hal