Re: [PATCH 7/7] dt-bindings: display: mediatek: tdshp: Add support for MT8196

Jay Liu (刘博)
2025-02-26T11:37:49Z

On Wed, 2025-02-19 at 10:25 +0100, Krzysztof Kozlowski wrote:
> External email : Please do not click links or open attachments until
> you have verified the sender or the content.
>
>
> On 19/02/2025 10:20, Jay Liu wrote:
> > Add a compatible string for MediaTek MT8196 SoC
>
> No, this is just bogus commit msg.
>
> You did not try enough, just pasted same useless and incorrect
> message
> to every patch.
>

hi Krzysztof ,I will try fix those issue in next version

Thanks a lot
JAY

> >
> > Signed-off-by: Jay Liu <jay.liu@mediatek.com>
> > ---
> > .../display/mediatek/mediatek,tdshp.yaml | 51
> > +++++++++++++++++++
> > 1 file changed, 51 insertions(+)
> > create mode 100644
> > Documentation/devicetree/bindings/display/mediatek/mediatek,tdshp.y
> > aml
> >
> > diff --git
> > a/Documentation/devicetree/bindings/display/mediatek/mediatek,tdshp
> > .yaml
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,tdshp
> > .yaml
> > new file mode 100644
> > index 000000000000..5ed7bdd53d0e
> > --- /dev/null
> > +++
> > b/Documentation/devicetree/bindings/display/mediatek/mediatek,tdshp
> > .yaml
>
> Filename matching exactly compatible.
>
> > @@ -0,0 +1,51 @@
> > +# SPDX-License-Identifier: (GPL-2.0-only OR BSD-2-Clause)
> > +%YAML 1.2
> > +---
> > +$id:
> > https://urldefense.com/v3/__http://devicetree.org/schemas/display/mediatek/mediatek,tdshp.yaml*__;Iw!!CTRNKA9wMg0ARbw!nr5z3xMTBUfbNfmzkP2P4_gs0hHjv8OXemH52ipgq-YNOW4IVHIMa1cYYnYmYWdanFFaigHTwloX$
> > +$schema:
> > https://urldefense.com/v3/__http://devicetree.org/meta-schemas/core.yaml*__;Iw!!CTRNKA9wMg0ARbw!nr5z3xMTBUfbNfmzkP2P4_gs0hHjv8OXemH52ipgq-YNOW4IVHIMa1cYYnYmYWdanFFairWCuJ_4$
> > +
> > +title: MediaTek display clarity correction
> > +
> > +maintainers:
> > + - Chun-Kuang Hu <chunkuang.hu@kernel.org>
> > + - Philipp Zabel <p.zabel@pengutronix.de>
> > +
> > +description: |
>
> Do not need '|' unless you need to preserve formatting.
>
> > + MediaTek display clarity correction, namely TDSHP, provides a
> > + operation used to adjust sharpness in display system.
> > + TDSHP device node must be siblings to the central MMSYS_CONFIG
> > node.
> > + For a description of the MMSYS_CONFIG binding, see
> > + Documentation/devicetree/bindings/arm/mediatek/mediatek,mmsys.ya
> > ml
> > + for details.
>
> Missing blank line. Do not introduce own style.
>
> > +properties:
> > + compatible:
> > + oneOf:
>
> Drop, unless this is already going to grow?
>
>
> > + - enum:
> > + - mediatek,mt8196-disp-tdshp
> > +
> > + reg:
> > + maxItems: 1
> > +
> > + clocks:
> > + maxItems: 1
> > +
> > +required:
> > + - compatible
> > + - reg
> > + - clocks
> > +
> > +additionalProperties: false
> > +
> > +examples:
> > + - |
> > +
>
> Drop
>
>
> Best regards,
> Krzysztof