From: Krzysztof Kozlowski <krzk@kernel.org>
To: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>,
Konrad Dybcio <konrad.dybcio@oss.qualcomm.com>,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <konradybcio@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Michael Turquette <mturquette@baylibre.com>,
Stephen Boyd <sboyd@kernel.org>
Cc: Ajit Pandey <quic_ajipan@quicinc.com>,
Imran Shaik <quic_imrashai@quicinc.com>,
Taniya Das <quic_tdas@quicinc.com>,
Jagadeesh Kona <quic_jkona@quicinc.com>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, linux-clk@vger.kernel.org
Subject: Re: [PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible
Date: Tue, 1 Jul 2025 15:27:37 +0200 [thread overview]
Message-ID: <0323b9eb-9a3d-4d17-bad8-f9052fb30b57@kernel.org> (raw)
In-Reply-To: <6d44e289-a20d-4dcd-871f-20b1854cbbf0@quicinc.com>
On 01/07/2025 14:09, Satya Priya Kakitapalli wrote:
>
> On 7/1/2025 5:23 PM, Konrad Dybcio wrote:
>>
>> On 01-Jul-25 13:40, Satya Priya Kakitapalli wrote:
>>> The sc8180x video clock controller block is identical to that
>>> of sm8150. Add a new compatible string for sc8180x videocc and
>>> use sm8150 as fallback.
>>>
>>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>>> ---
>> The yaml checker throws a warning:
>>
>> make ARCH=arm64 LLVM=1 -j$(nproc) dt_binding_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/clock/qcom,videocc.yaml"
>>
>> CHKDT ./Documentation/devicetree/bindings
>> LINT ./Documentation/devicetree/bindings
>> ./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>> ./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:35:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>> DTEX Documentation/devicetree/bindings/clock/qcom,videocc.example.dts
>> DTC [C] Documentation/devicetree/bindings/clock/qcom,videocc.example.dtb
>
>
> I somehow didn't get these warning when I ran the DT checker.
>
> I am able to reproduce these warnings by running the yamllint tool
> directly, will fix them and resend, thanks.
>
>
> $ yamllint Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> Documentation/devicetree/bindings/clock/qcom,videocc.yaml
> 28:9 error wrong indentation: expected 10 but
> found 8 (indentation)
> 35:9 error wrong indentation: expected 10 but
> found 8 (indentation)
>
Qualcomm needs to stop using Ubuntu 18.04 or 20.04 or whatever ancient
is there for development... These errors are part of standard check but
broken or crazy old system would explain why it does not work.
Plus you get huge speed up on new Python.
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-07-01 13:27 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-07-01 11:40 [PATCH v2 0/2] Add video clock controller DT support for sc8180x Satya Priya Kakitapalli
2025-07-01 11:40 ` [PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible Satya Priya Kakitapalli
2025-07-01 11:44 ` Krzysztof Kozlowski
2025-07-01 11:53 ` Konrad Dybcio
2025-07-01 12:09 ` Satya Priya Kakitapalli
2025-07-01 13:27 ` Krzysztof Kozlowski [this message]
2025-07-01 12:31 ` Rob Herring (Arm)
2025-07-01 11:40 ` [PATCH v2 2/2] arm64: dts: qcom: sc8180x: Add video clock controller node Satya Priya Kakitapalli
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=0323b9eb-9a3d-4d17-bad8-f9052fb30b57@kernel.org \
--to=krzk@kernel.org \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=konrad.dybcio@oss.qualcomm.com \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-clk@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=mturquette@baylibre.com \
--cc=quic_ajipan@quicinc.com \
--cc=quic_imrashai@quicinc.com \
--cc=quic_jkona@quicinc.com \
--cc=quic_skakitap@quicinc.com \
--cc=quic_tdas@quicinc.com \
--cc=robh@kernel.org \
--cc=sboyd@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).