[PATCH v2 0/2] Add video clock controller DT support for sc8180x

[PATCH v2 0/2] Add video clock controller DT support for sc8180x

[Satya Priya Kakitapalli]

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
Changes in v2:
- Introduce new compatible for sc8180x videocc and use sm8150 as
  fallback. 
- Add new patch to update the bindings accordingly.
- Link to v1: https://lore.kernel.org/r/20250623-sc8180x-videocc-dt-v1-1-9d210c140600@quicinc.com

---
Satya Priya Kakitapalli (2):
      dt-bindings: clock: qcom,videocc: Add sc8180x compatible
      arm64: dts: qcom: sc8180x: Add video clock controller node

 .../devicetree/bindings/clock/qcom,videocc.yaml       | 19 ++++++++++++-------
 arch/arm64/boot/dts/qcom/sc8180x.dtsi                 | 15 +++++++++++++++
 2 files changed, 27 insertions(+), 7 deletions(-)
---
base-commit: 5d4809e25903ab8e74034c1f23c787fd26d52934
change-id: 20250623-sc8180x-videocc-dt-4ec3c0761f8d

Best regards,
-- 
Satya Priya Kakitapalli <quic_skakitap@quicinc.com>

[PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Satya Priya Kakitapalli]

The sc8180x video clock controller block is identical to that
of sm8150. Add a new compatible string for sc8180x videocc and
use sm8150 as fallback.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 .../devicetree/bindings/clock/qcom,videocc.yaml       | 19 ++++++++++++-------
 1 file changed, 12 insertions(+), 7 deletions(-)

diff --git a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
index 5f7738d6835c4ba999402e163fc85a07e3a47a5a..25379f2f6a867f9559516730a257e49b77ec4028 100644
--- a/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
+++ b/Documentation/devicetree/bindings/clock/qcom,videocc.yaml
@@ -23,13 +23,17 @@ description: |
 
 properties:
   compatible:
-    enum:
-      - qcom,sc7180-videocc
-      - qcom,sc7280-videocc
-      - qcom,sdm845-videocc
-      - qcom,sm6350-videocc
-      - qcom,sm8150-videocc
-      - qcom,sm8250-videocc
+    oneOf:
+      - enum:
+        - qcom,sc7180-videocc
+        - qcom,sc7280-videocc
+        - qcom,sdm845-videocc
+        - qcom,sm6350-videocc
+        - qcom,sm8150-videocc
+        - qcom,sm8250-videocc
+      - items:
+        - const: qcom,sc8180x-videocc
+        - const: qcom,sm8150-videocc
 
   clocks:
     minItems: 1
@@ -111,6 +115,7 @@ allOf:
       properties:
         compatible:
           enum:
+            - qcom,sc8180x-videocc
             - qcom,sm8150-videocc
     then:
       properties:

-- 
2.25.1

[PATCH v2 2/2] arm64: dts: qcom: sc8180x: Add video clock controller node

[Satya Priya Kakitapalli]

Add device node for video clock controller on Qualcomm
sc8180x platform.

Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
---
 arch/arm64/boot/dts/qcom/sc8180x.dtsi | 15 +++++++++++++++
 1 file changed, 15 insertions(+)

diff --git a/arch/arm64/boot/dts/qcom/sc8180x.dtsi b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
index b74ce3175d209b569e634073662307964158b340..e0dfa1eae8202881a02cc8531111792e7c962fa6 100644
--- a/arch/arm64/boot/dts/qcom/sc8180x.dtsi
+++ b/arch/arm64/boot/dts/qcom/sc8180x.dtsi
@@ -10,6 +10,7 @@
 #include <dt-bindings/clock/qcom,gpucc-sm8150.h>
 #include <dt-bindings/clock/qcom,rpmh.h>
 #include <dt-bindings/clock/qcom,sc8180x-camcc.h>
+#include <dt-bindings/clock/qcom,videocc-sm8150.h>
 #include <dt-bindings/interconnect/qcom,icc.h>
 #include <dt-bindings/interconnect/qcom,osm-l3.h>
 #include <dt-bindings/interconnect/qcom,sc8180x.h>
@@ -2943,6 +2944,20 @@ usb_sec_dwc3_ss: endpoint {
 			};
 		};
 
+		videocc: clock-controller@ab00000 {
+			compatible = "qcom,sc8180x-videocc",
+				     "qcom,sm8150-videocc";
+			reg = <0 0x0ab00000 0 0x10000>;
+			clocks = <&gcc GCC_VIDEO_AHB_CLK>,
+				 <&rpmhcc RPMH_CXO_CLK>;
+			clock-names = "iface", "bi_tcxo";
+			power-domains = <&rpmhpd SC8180X_MMCX>;
+			required-opps = <&rpmhpd_opp_low_svs>;
+			#clock-cells = <1>;
+			#reset-cells = <1>;
+			#power-domain-cells = <1>;
+		};
+
 		camcc: clock-controller@ad00000 {
 			compatible = "qcom,sc8180x-camcc";
 			reg = <0 0x0ad00000 0 0x20000>;

-- 
2.25.1

Re: [PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Krzysztof Kozlowski]

On 01/07/2025 13:40, Satya Priya Kakitapalli wrote:
> The sc8180x video clock controller block is identical to that
> of sm8150. Add a new compatible string for sc8180x videocc and
> use sm8150 as fallback.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  .../devicetree/bindings/clock/qcom,videocc.yaml       | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)

Never tested. Please don't send untested patches.

Best regards,
Krzysztof

Re: [PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Konrad Dybcio]

On 01-Jul-25 13:40, Satya Priya Kakitapalli wrote:
> The sc8180x video clock controller block is identical to that
> of sm8150. Add a new compatible string for sc8180x videocc and
> use sm8150 as fallback.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---

The yaml checker throws a warning:

make ARCH=arm64 LLVM=1 -j$(nproc) dt_binding_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/clock/qcom,videocc.yaml"

  CHKDT   ./Documentation/devicetree/bindings
  LINT    ./Documentation/devicetree/bindings
./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:35:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
  DTEX    Documentation/devicetree/bindings/clock/qcom,videocc.example.dts
  DTC [C] Documentation/devicetree/bindings/clock/qcom,videocc.example.dtb

Konrad

Re: [PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Satya Priya Kakitapalli]

On 7/1/2025 5:23 PM, Konrad Dybcio wrote:
>
> On 01-Jul-25 13:40, Satya Priya Kakitapalli wrote:
>> The sc8180x video clock controller block is identical to that
>> of sm8150. Add a new compatible string for sc8180x videocc and
>> use sm8150 as fallback.
>>
>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>> ---
> The yaml checker throws a warning:
>
> make ARCH=arm64 LLVM=1 -j$(nproc) dt_binding_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/clock/qcom,videocc.yaml"
>
>    CHKDT   ./Documentation/devicetree/bindings
>    LINT    ./Documentation/devicetree/bindings
> ./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
> ./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:35:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>    DTEX    Documentation/devicetree/bindings/clock/qcom,videocc.example.dts
>    DTC [C] Documentation/devicetree/bindings/clock/qcom,videocc.example.dtb


I somehow didn't get these warning when I ran the DT checker.

I am able to reproduce these warnings by running the yamllint tool 
directly, will fix them and resend, thanks.


$ yamllint Documentation/devicetree/bindings/clock/qcom,videocc.yaml
         Documentation/devicetree/bindings/clock/qcom,videocc.yaml
               28:9      error    wrong indentation: expected 10 but 
found 8  (indentation)
               35:9      error    wrong indentation: expected 10 but 
found 8  (indentation)

Re: [PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Rob Herring (Arm)]

On Tue, 01 Jul 2025 17:10:18 +0530, Satya Priya Kakitapalli wrote:
> The sc8180x video clock controller block is identical to that
> of sm8150. Add a new compatible string for sc8180x videocc and
> use sm8150 as fallback.
> 
> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
> ---
>  .../devicetree/bindings/clock/qcom,videocc.yaml       | 19 ++++++++++++-------
>  1 file changed, 12 insertions(+), 7 deletions(-)
> 

My bot found errors running 'make dt_binding_check' on your patch:

yamllint warnings/errors:
./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:35:9: [warning] wrong indentation: expected 10 but found 8 (indentation)

dtschema/dtc warnings/errors:

doc reference errors (make refcheckdocs):

See https://patchwork.ozlabs.org/project/devicetree-bindings/patch/20250701-sc8180x-videocc-dt-v2-1-b05db66cc1f6@quicinc.com

The base for the series is generally the latest rc1. A different dependency
should be noted in *this* patch.

If you already ran 'make dt_binding_check' and didn't see the above
error(s), then make sure 'yamllint' is installed and dt-schema is up to
date:

pip3 install dtschema --upgrade

Please check and re-submit after running the above command yourself. Note
that DT_SCHEMA_FILES can be set to your schema file to speed up checking
your schema. However, it must be unset to test all examples with your schema.

Re: [PATCH v2 1/2] dt-bindings: clock: qcom,videocc: Add sc8180x compatible

[Krzysztof Kozlowski]

On 01/07/2025 14:09, Satya Priya Kakitapalli wrote:
> 
> On 7/1/2025 5:23 PM, Konrad Dybcio wrote:
>>
>> On 01-Jul-25 13:40, Satya Priya Kakitapalli wrote:
>>> The sc8180x video clock controller block is identical to that
>>> of sm8150. Add a new compatible string for sc8180x videocc and
>>> use sm8150 as fallback.
>>>
>>> Signed-off-by: Satya Priya Kakitapalli <quic_skakitap@quicinc.com>
>>> ---
>> The yaml checker throws a warning:
>>
>> make ARCH=arm64 LLVM=1 -j$(nproc) dt_binding_check DT_SCHEMA_FILES="Documentation/devicetree/bindings/clock/qcom,videocc.yaml"
>>
>>    CHKDT   ./Documentation/devicetree/bindings
>>    LINT    ./Documentation/devicetree/bindings
>> ./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:28:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>> ./Documentation/devicetree/bindings/clock/qcom,videocc.yaml:35:9: [warning] wrong indentation: expected 10 but found 8 (indentation)
>>    DTEX    Documentation/devicetree/bindings/clock/qcom,videocc.example.dts
>>    DTC [C] Documentation/devicetree/bindings/clock/qcom,videocc.example.dtb
> 
> 
> I somehow didn't get these warning when I ran the DT checker.
> 
> I am able to reproduce these warnings by running the yamllint tool 
> directly, will fix them and resend, thanks.
> 
> 
> $ yamllint Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>          Documentation/devicetree/bindings/clock/qcom,videocc.yaml
>                28:9      error    wrong indentation: expected 10 but 
> found 8  (indentation)
>                35:9      error    wrong indentation: expected 10 but 
> found 8  (indentation)
> 

Qualcomm needs to stop using Ubuntu 18.04 or 20.04 or whatever ancient
is there for development... These errors are part of standard check but
broken or crazy old system would explain why it does not work.

Plus you get huge speed up on new Python.

Best regards,
Krzysztof