From: Krzysztof Kozlowski <krzk@kernel.org>
To: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>,
Robert Foss <rfoss@kernel.org>, Todor Tomov <todor.too@gmail.com>,
Vladimir Zapolskiy <vladimir.zapolskiy@linaro.org>,
Mauro Carvalho Chehab <mchehab@kernel.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
Bryan O'Donoghue <bryan.odonoghue@linaro.org>
Cc: linux-arm-msm@vger.kernel.org, linux-media@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
jeyaprakash.soundrapandian@oss.qualcomm.com,
Vijay Kumar Tumati <vijay.tumati@oss.qualcomm.com>
Subject: Re: [PATCH RESEND v2 1/5] media: dt-bindings: Add CAMSS device for SM8750
Date: Thu, 26 Feb 2026 10:59:49 +0100 [thread overview]
Message-ID: <033dcec7-edf0-4c3b-a6ce-14a61d0a0b24@kernel.org> (raw)
In-Reply-To: <20260119-add-support-for-camss-on-sm8750-v2-1-3e06583a0a81@oss.qualcomm.com>
On 20/01/2026 07:42, Hangxiang Ma wrote:
> Add bindings for Camera Subsystem (CAMSS) on the Qualcomm SM8750 platform.
>
> The SM8750 platform provides:
>
> - 3 x VFE (Video Front End), 5 RDI per VFE
> - 2 x VFE Lite, 4 RDI per VFE Lite
> - 3 x CSID (CSI Decoder)
> - 2 x CSID Lite
> - 6 x CSIPHY (CSI Physical Layer)
> - 2 x ICP (Image Control Processor)
> - 1 x IPE (Image Processing Engine)
> - 2 x JPEG DMA & Downscaler
> - 2 x JPEG Encoder
> - 1 x OFE (Offline Front End)
> - 5 x RT CDM (Camera Data Mover)
> - 3 x TPG (Test Pattern Generator)
>
> Reviewed-by: Bryan O'Donoghue <bryan.odonoghue@linaro.org>
> Signed-off-by: Hangxiang Ma <hangxiang.ma@oss.qualcomm.com>
> ---
> .../bindings/media/qcom,sm8750-camss.yaml | 663 +++++++++++++++++++++
> 1 file changed, 663 insertions(+)
Same comment as here:
https://lore.kernel.org/r/7927bdab-9c3b-460d-a2ba-2e5b06ee8804@kernel.org/
Pasting for reference:
Just to be clear, because Bryan posted now x1e80100 camss patches
changing ABI. I was holding this patchset for camss/media maintainers to
come up with driver and any other necessary pieces (like guidance for
bindings) support for split CSI PHY. Finally after long time I gave up
and gave these bindings green light.
Additionally there is some claim that there is policy allowing to change
bindings. No. There is no change of bindings with few exceptions. Decide
now what bindings you want to have. One single node or split CSI PHY,
because you cannot take the first option but then six months later send
complete revamp of the ABI.
So please decide and answer, e.g. by taking this patch, that you
understand above and THIS will be your fixed ABI.
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-02-26 9:59 UTC|newest]
Thread overview: 15+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-20 6:42 [PATCH RESEND v2 0/5] media: qcom: camss: Add SM8750 support Hangxiang Ma
2026-01-20 6:42 ` [PATCH RESEND v2 1/5] media: dt-bindings: Add CAMSS device for SM8750 Hangxiang Ma
2026-01-20 9:35 ` Krzysztof Kozlowski
2026-01-20 18:58 ` Vijay Kumar Tumati
2026-01-20 21:28 ` Bryan O'Donoghue
2026-02-18 20:08 ` Krzysztof Kozlowski
2026-02-19 0:50 ` Bryan O'Donoghue
2026-02-19 1:08 ` Vijay Kumar Tumati
2026-02-19 13:09 ` Bryan O'Donoghue
2026-02-26 9:59 ` Krzysztof Kozlowski [this message]
2026-02-26 10:08 ` Bryan O'Donoghue
2026-01-20 6:42 ` [PATCH RESEND v2 2/5] media: qcom: camss: Add SM8750 compatible camss driver Hangxiang Ma
2026-01-20 6:42 ` [PATCH RESEND v2 3/5] media: qcom: camss: csiphy: Add support for v2.3.0 two-phase CSIPHY Hangxiang Ma
2026-01-20 6:42 ` [PATCH RESEND v2 4/5] media: qcom: camss: csid: Add support for CSID 980 Hangxiang Ma
2026-01-20 6:42 ` [PATCH RESEND v2 5/5] media: qcom: camss: vfe: Add support for VFE 980 Hangxiang Ma
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=033dcec7-edf0-4c3b-a6ce-14a61d0a0b24@kernel.org \
--to=krzk@kernel.org \
--cc=bryan.odonoghue@linaro.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=hangxiang.ma@oss.qualcomm.com \
--cc=jeyaprakash.soundrapandian@oss.qualcomm.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-media@vger.kernel.org \
--cc=mchehab@kernel.org \
--cc=rfoss@kernel.org \
--cc=robh@kernel.org \
--cc=todor.too@gmail.com \
--cc=vijay.tumati@oss.qualcomm.com \
--cc=vladimir.zapolskiy@linaro.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox