From: Kukjin Kim <kgene.kim@samsung.com>
To: 'Tomasz Figa' <t.figa@samsung.com>,
'Sachin Kamat' <sachin.kamat@linaro.org>,
linux-samsung-soc@vger.kernel.org
Cc: linux-arm-kernel@lists.infradead.org, devicetree@vger.kernel.org,
heiko@sntech.de, arnd@arndb.de, robh+dt@kernel.org
Subject: RE: [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings
Date: Fri, 09 May 2014 11:14:07 +0900 [thread overview]
Message-ID: <034b01cf6b2c$5b5d06b0$12171410$@samsung.com> (raw)
In-Reply-To: <536BAE39.70504@samsung.com>
Tomasz Figa wrote:
>
> Hi Sachin,
>
> On 08.05.2014 06:16, Sachin Kamat wrote:
> > Instead of hardcoding the SYSRAM details for each SoC,
> > pass this information through device tree (DT) and make
> > the code SoC agnostic. Generic SRAM bindings are used
> > for achieving this.
> >
> > Signed-off-by: Sachin Kamat <sachin.kamat@linaro.org>
> > Acked-by: Arnd Bergmann <arnd@arndb.de>
> > Acked-by: Heiko Stuebner <heiko@sntech.de>
> > ---
> > Changes since v2.
> > * Updated sysram node for Universal C210 board - Thanks to
> > Tomasz Figa for testing and updating the same.
> > * Added error handling code.
> > * Break if matching node found.
> > * Remove unnecessary error messages.
> >
> > This patch is based on linux next (next-20140501) on top of
> > my Kconfig consolidation patch
> > http://comments.gmane.org/gmane.linux.kernel.samsung-soc/28642
> >
> > Tested on 4210/4412 Origen, 5250/5420 Arndale and SMDK5420 boards.
> > ---
> > arch/arm/Kconfig | 1 +
> > arch/arm/boot/dts/exynos4210-universal_c210.dts | 15 ++++++
> > arch/arm/boot/dts/exynos4210.dtsi | 18 +++++++
> > arch/arm/boot/dts/exynos4x12.dtsi | 18 +++++++
> > arch/arm/boot/dts/exynos5250.dtsi | 18 +++++++
> > arch/arm/boot/dts/exynos5420.dtsi | 18 +++++++
> > arch/arm/mach-exynos/common.h | 1 +
> > arch/arm/mach-exynos/exynos.c | 64
----------------------
> -
> > arch/arm/mach-exynos/firmware.c | 8 ++-
> > arch/arm/mach-exynos/include/mach/map.h | 7 ---
> > arch/arm/mach-exynos/platsmp.c | 56
++++++++++++++++++--
> > 11 files changed, 148 insertions(+), 76 deletions(-)
> >
>
> Looks good, thanks.
>
> Reviewed-by: Tomasz Figa <t.figa@samsung.com>
>
Looks good to me but I think, we need to change the name of 'sram' because
it can cause some confusing, actually it is not matching _real_ sram area on
the SoCs. When we upstreamed regarding patch, I decided the name to use
'SYSRAM', it was called another name in datasheet though. So, I'd like to
use 'sysram' instead of 'sram' as we used before.
I will change the name when I apply this series in this weekend, if you guys
have no objection.
Thanks,
Kukjin
next prev parent reply other threads:[~2014-05-09 2:14 UTC|newest]
Thread overview: 11+ messages / expand[flat|nested] mbox.gz Atom feed top
2014-05-08 4:16 [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings Sachin Kamat
2014-05-08 4:16 ` [PATCH v3 2/2] Documentation: DT: Exynos: Bind SRAM though DT Sachin Kamat
2014-05-08 16:19 ` Tomasz Figa
2014-05-08 16:18 ` [PATCH v3 1/2] ARM: EXYNOS: Map SYSRAM through generic SRAM bindings Tomasz Figa
2014-05-09 2:14 ` Kukjin Kim [this message]
2014-05-09 4:49 ` Tomasz Figa
2014-05-09 13:46 ` Kukjin Kim
2014-05-13 3:12 ` Kukjin Kim
2014-05-13 10:07 ` Paul Bolle
2014-05-14 3:14 ` Tushar Behera
2014-05-14 4:08 ` Kukjin Kim
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='034b01cf6b2c$5b5d06b0$12171410$@samsung.com' \
--to=kgene.kim@samsung.com \
--cc=arnd@arndb.de \
--cc=devicetree@vger.kernel.org \
--cc=heiko@sntech.de \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-samsung-soc@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=sachin.kamat@linaro.org \
--cc=t.figa@samsung.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).