From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 87760C433FE for ; Thu, 3 Nov 2022 22:21:43 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S231304AbiKCWVm (ORCPT ); Thu, 3 Nov 2022 18:21:42 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:43318 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230336AbiKCWVl (ORCPT ); Thu, 3 Nov 2022 18:21:41 -0400 Received: from mail-qt1-x829.google.com (mail-qt1-x829.google.com [IPv6:2607:f8b0:4864:20::829]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6AE851F9C3 for ; Thu, 3 Nov 2022 15:21:39 -0700 (PDT) Received: by mail-qt1-x829.google.com with SMTP id h21so2158533qtu.2 for ; Thu, 03 Nov 2022 15:21:39 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=Vi/pWwgGFs4pXzg7F1f4rBtGcIgo+CI+e4hAiYlYSug=; b=gCQrA1mESAHroZExu5yboI7YitKs8V66ouZfsz1dAghoX9z/eu7dcqx7XxwzfGYq9i dqFz3S3xkBhQWa8DNRIxGDsNVVTFf7ujh1Gl2oFDfdhmI3Z7JY9KTazDjbvMWT6Emqer Eg3U7XlfoN0f6RXzeEZ05D7fWJZ2Is+T/Sdof72bjT5lW3YT5IdwaLgLF1gP57ysFb3x wmUhMCtakRcaI3Mei5/02Q7CYwzXBjwSvUhM8uwZyKusaQs1JeatXu/Lfm0+GrQE4k2x wxYCiGVkcJyA9+YhIC9Qy5+9wdjBQC1yfpGNsYSfRajgctIk7bYVQRSjPXO1YO53tYWA PAzw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=Vi/pWwgGFs4pXzg7F1f4rBtGcIgo+CI+e4hAiYlYSug=; b=OGAAmZYo+VYKZV3qdSW1znJQeQta3OB9292vLGGCg4wcRq6uzihNnNV4UJhGQiI0+7 nkf8Ahs2/WyixMJTUv+EtUrt8KuCyyhnOpH06RrPV9mo7qRzDli53/KKsuzDIgVAyp+S uj2pogUU4iLIAQylGEjLjDTZuIqBagjPBQ33tFB8kJmd8WF6vDgVJ2FXc2P/wHMog5P9 GlPWspY5FbZ3eaR3oX7bZPNuDGrKVAv0nA+uNXUZht/SH8uajYn7dZ846OQxRdekIe32 IUupp+fKTtCFsaBNbIDiPR+0o7i3llrsPFblvJ8ma3KU/stY2yLQhYT927wp8LemqPSM lwfw== X-Gm-Message-State: ACrzQf22U6BiBYkNMNLtDt9dPDvlZCcTr25UUBj6EOiAeTXVlnlkVY0N 3M38ivEecSdu3R7PzFjEpR+wUg== X-Google-Smtp-Source: AMsMyM4dV+l3qpT2GaeRAl+EKAxXhDQLiMQslAFWNumDisNbRwbsB45L9HEavd86pL52uLDz5fe2Dg== X-Received: by 2002:ac8:7651:0:b0:3a5:528c:f326 with SMTP id i17-20020ac87651000000b003a5528cf326mr4491581qtr.586.1667514098561; Thu, 03 Nov 2022 15:21:38 -0700 (PDT) Received: from ?IPV6:2601:586:5000:570:a35d:9f85:e3f7:d9fb? ([2601:586:5000:570:a35d:9f85:e3f7:d9fb]) by smtp.gmail.com with ESMTPSA id k7-20020ac81407000000b0039cd4d87aacsm1264139qtj.15.2022.11.03.15.21.37 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Thu, 03 Nov 2022 15:21:37 -0700 (PDT) Message-ID: <035a66e3-0b21-18de-0899-fb2ee22df15f@linaro.org> Date: Thu, 3 Nov 2022 18:21:36 -0400 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.4.1 Subject: Re: [PATCH v1 2/2] arm64: dts: qcom: msm8916-alcatel-idol347: add LED indicator Content-Language: en-US To: Vincent Knecht , Andy Gross , Bjorn Andersson , Konrad Dybcio , Rob Herring , Krzysztof Kozlowski , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org References: <20221029145557.106920-1-vincent.knecht@mailoo.org> <20221029145557.106920-2-vincent.knecht@mailoo.org> From: Krzysztof Kozlowski In-Reply-To: <20221029145557.106920-2-vincent.knecht@mailoo.org> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 29/10/2022 10:55, Vincent Knecht wrote: > Add si-en,sn3190 LED controller to enable white LED indicator. > > This requires adding the additional "enable" gpio that the OEM > choose to use, despite it not being mentioned in si-en,sn3190 > datasheet nor supported by the driver. > > Signed-off-by: Vincent Knecht > --- > .../boot/dts/qcom/msm8916-alcatel-idol347.dts | 44 +++++++++++++++++++ > 1 file changed, 44 insertions(+) > > diff --git a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts > index 3a0a593899ae..952ae092e6ae 100644 > --- a/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts > +++ b/arch/arm64/boot/dts/qcom/msm8916-alcatel-idol347.dts > @@ -130,6 +130,27 @@ gyroscope@68 { > }; > }; > > +&blsp_i2c6 { > + status = "okay"; > + > + led-controller@68 { > + compatible = "si-en,sn3190"; > + reg = <0x68>; > + shutdown-gpios = <&msmgpio 89 GPIO_ACTIVE_HIGH>; > + pinctrl-names = "default"; > + pinctrl-0 = <&led_enable_default &led_shutdown_default>; > + #address-cells = <1>; > + #size-cells = <0>; > + > + led@1 { > + reg = <1>; > + led-max-microamp = <5000>; > + function = LED_FUNCTION_INDICATOR; > + color = ; > + }; > + }; > +}; > + > &pm8916_resin { > status = "okay"; > linux,code = ; > @@ -306,6 +327,29 @@ gyro_int_default: gyro-int-default { > bias-disable; > }; > > + /* > + * The OEM wired an additional GPIO to be asserted so that > + * the si-en,sn3190 LED IC works. Since this GPIO is not > + * part of the IC datasheet nor supported by the driver, > + * force it asserted here. > + */ > + led_enable_default: led-enable-default { Add suffix to node name: "-state" Same in other places. Bindings require it now. Best regards, Krzysztof