From: Caleb Connolly <caleb@connolly.tech>
To: Steev Klimaszewski <steev@kali.org>
Cc: Andy Gross <agross@kernel.org>,
Bjorn Andersson <bjorn.andersson@linaro.org>,
Rob Herring <robh+dt@kernel.org>,
linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org,
linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org,
~postmarketos/upstreaming@lists.sr.ht
Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel
Date: Wed, 20 Oct 2021 17:24:32 +0000 [thread overview]
Message-ID: <037d2bee-c04d-aa22-c8df-232dda4038a1@connolly.tech> (raw)
In-Reply-To: <19359125-16fa-f9e0-1450-b0e9181064e1@kali.org>
Hi Steev,
On 20/10/2021 18:13, Steev Klimaszewski wrote:
> Hi Caleb,
>
> On 10/20/21 11:36 AM, Caleb Connolly wrote:
>> Like the c630, the OnePlus 6 is also capable of using both antenna
>> channels for 2.4 and 5ghz wifi, however unlike the c630 only the first
>> channel is used for bluetooth.
>>
>> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> index d4355522374a..8bf2430a3af7 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
>> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> };
>>
>> + vreg_l23a_3p3: ldo23 {
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3312000>;
>> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> + };
>> +
>> vdda_qusb_hs0_3p1:
>> vreg_l24a_3p075: ldo24 {
>> regulator-min-microvolt = <3088000>;
>> @@ -647,6 +653,7 @@ &wifi {
>> vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
>> vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
>> vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>> + vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>>
>> qcom,snoc-host-cap-8bit-quirk;
>> };
>> --
>> 2.33.1
>>
>>
> Just for the record, I added it for completeness, as far as I can tell,
> the bluetooth driver itself won't use the second channel.
Ah I see, I can confirm that the bluetooth hardware is only connected to the first channel on the op6, so with wifi off
the second antenna can also be turned off to save power without affecting bluetooth signal strength.
>
>
> -- steev
>
--
Kind Regards,
Caleb
prev parent reply other threads:[~2021-10-20 17:24 UTC|newest]
Thread overview: 3+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-20 16:36 [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel Caleb Connolly
2021-10-20 17:13 ` Steev Klimaszewski
2021-10-20 17:24 ` Caleb Connolly [this message]
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=037d2bee-c04d-aa22-c8df-232dda4038a1@connolly.tech \
--to=caleb@connolly.tech \
--cc=agross@kernel.org \
--cc=bjorn.andersson@linaro.org \
--cc=devicetree@vger.kernel.org \
--cc=linux-arm-msm@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=phone-devel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=steev@kali.org \
--cc=~postmarketos/upstreaming@lists.sr.ht \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).