From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id E0A79C433F5 for ; Wed, 20 Oct 2021 17:24:47 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id BF9F5610EA for ; Wed, 20 Oct 2021 17:24:47 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S230345AbhJTR1B (ORCPT ); Wed, 20 Oct 2021 13:27:01 -0400 Received: from mail-0201.mail-europe.com ([51.77.79.158]:51282 "EHLO mail-0201.mail-europe.com" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S230031AbhJTR1B (ORCPT ); Wed, 20 Oct 2021 13:27:01 -0400 Date: Wed, 20 Oct 2021 17:24:32 +0000 DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=connolly.tech; s=protonmail; t=1634750682; bh=77z2TAz6twFFcjLPzt2kV+UKOHbqTBnqrqy+N6bDW/k=; h=Date:To:From:Cc:Reply-To:Subject:In-Reply-To:References:From; b=qOeFKyQBfqHLSTz41MPxXFO6A2WHcVu9xLb1iy0dUDXfupgvOpbI1jDcH5g8TQcRR trg2pWpGlpFJ0UQOkSjgdl6JCaMR8wQHaqCSJ0pHhgUGbHQs1vZBaBGCmdjkn2yITo a4PGmvE6E1IyGZQGZfpWAKr1OACp++rCbmHnVUhs= To: Steev Klimaszewski From: Caleb Connolly Cc: Andy Gross , Bjorn Andersson , Rob Herring , linux-arm-msm@vger.kernel.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org, phone-devel@vger.kernel.org, ~postmarketos/upstreaming@lists.sr.ht Reply-To: Caleb Connolly Subject: Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel Message-ID: <037d2bee-c04d-aa22-c8df-232dda4038a1@connolly.tech> In-Reply-To: <19359125-16fa-f9e0-1450-b0e9181064e1@kali.org> References: <20211020163557.291803-1-caleb@connolly.tech> <19359125-16fa-f9e0-1450-b0e9181064e1@kali.org> MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org Hi Steev, On 20/10/2021 18:13, Steev Klimaszewski wrote: > Hi Caleb, > > On 10/20/21 11:36 AM, Caleb Connolly wrote: >> Like the c630, the OnePlus 6 is also capable of using both antenna >> channels for 2.4 and 5ghz wifi, however unlike the c630 only the first >> channel is used for bluetooth. >> >> Signed-off-by: Caleb Connolly >> --- >> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++ >> 1 file changed, 7 insertions(+) >> >> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/= arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi >> index d4355522374a..8bf2430a3af7 100644 >> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi >> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi >> @@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 { >> =09=09=09regulator-initial-mode =3D ; >> =09=09}; >> >> +=09=09vreg_l23a_3p3: ldo23 { >> +=09=09=09regulator-min-microvolt =3D <3300000>; >> +=09=09=09regulator-max-microvolt =3D <3312000>; >> +=09=09=09regulator-initial-mode =3D ; >> +=09=09}; >> + >> =09=09vdda_qusb_hs0_3p1: >> =09=09vreg_l24a_3p075: ldo24 { >> =09=09=09regulator-min-microvolt =3D <3088000>; >> @@ -647,6 +653,7 @@ &wifi { >> =09vdd-1.8-xo-supply =3D <&vreg_l7a_1p8>; >> =09vdd-1.3-rfa-supply =3D <&vreg_l17a_1p3>; >> =09vdd-3.3-ch0-supply =3D <&vreg_l25a_3p3>; >> +=09vdd-3.3-ch1-supply =3D <&vreg_l23a_3p3>; >> >> =09qcom,snoc-host-cap-8bit-quirk; >> }; >> -- >> 2.33.1 >> >> > Just for the record, I added it for completeness, as far as I can tell, > the bluetooth driver itself won't use the second channel. Ah I see, I can confirm that the bluetooth hardware is only connected to th= e first channel on the op6, so with wifi off the second antenna can also be turned off to save power without affecting b= luetooth signal strength. > > > -- steev > -- Kind Regards, Caleb