* [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel
@ 2021-10-20 16:36 Caleb Connolly
2021-10-20 17:13 ` Steev Klimaszewski
0 siblings, 1 reply; 3+ messages in thread
From: Caleb Connolly @ 2021-10-20 16:36 UTC (permalink / raw)
To: Caleb Connolly
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming
Like the c630, the OnePlus 6 is also capable of using both antenna
channels for 2.4 and 5ghz wifi, however unlike the c630 only the first
channel is used for bluetooth.
Signed-off-by: Caleb Connolly <caleb@connolly.tech>
---
arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
1 file changed, 7 insertions(+)
diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
index d4355522374a..8bf2430a3af7 100644
--- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
+++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
@@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
};
+ vreg_l23a_3p3: ldo23 {
+ regulator-min-microvolt = <3300000>;
+ regulator-max-microvolt = <3312000>;
+ regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
+ };
+
vdda_qusb_hs0_3p1:
vreg_l24a_3p075: ldo24 {
regulator-min-microvolt = <3088000>;
@@ -647,6 +653,7 @@ &wifi {
vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
+ vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
qcom,snoc-host-cap-8bit-quirk;
};
--
2.33.1
^ permalink raw reply related [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel
2021-10-20 16:36 [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel Caleb Connolly
@ 2021-10-20 17:13 ` Steev Klimaszewski
2021-10-20 17:24 ` Caleb Connolly
0 siblings, 1 reply; 3+ messages in thread
From: Steev Klimaszewski @ 2021-10-20 17:13 UTC (permalink / raw)
To: Caleb Connolly
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming
Hi Caleb,
On 10/20/21 11:36 AM, Caleb Connolly wrote:
> Like the c630, the OnePlus 6 is also capable of using both antenna
> channels for 2.4 and 5ghz wifi, however unlike the c630 only the first
> channel is used for bluetooth.
>
> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
> ---
> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
> 1 file changed, 7 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> index d4355522374a..8bf2430a3af7 100644
> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
> @@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> };
>
> + vreg_l23a_3p3: ldo23 {
> + regulator-min-microvolt = <3300000>;
> + regulator-max-microvolt = <3312000>;
> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
> + };
> +
> vdda_qusb_hs0_3p1:
> vreg_l24a_3p075: ldo24 {
> regulator-min-microvolt = <3088000>;
> @@ -647,6 +653,7 @@ &wifi {
> vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
> vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
> vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
> + vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>
> qcom,snoc-host-cap-8bit-quirk;
> };
> --
> 2.33.1
>
>
Just for the record, I added it for completeness, as far as I can tell,
the bluetooth driver itself won't use the second channel.
-- steev
^ permalink raw reply [flat|nested] 3+ messages in thread* Re: [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel
2021-10-20 17:13 ` Steev Klimaszewski
@ 2021-10-20 17:24 ` Caleb Connolly
0 siblings, 0 replies; 3+ messages in thread
From: Caleb Connolly @ 2021-10-20 17:24 UTC (permalink / raw)
To: Steev Klimaszewski
Cc: Andy Gross, Bjorn Andersson, Rob Herring, linux-arm-msm,
devicetree, linux-kernel, phone-devel, ~postmarketos/upstreaming
Hi Steev,
On 20/10/2021 18:13, Steev Klimaszewski wrote:
> Hi Caleb,
>
> On 10/20/21 11:36 AM, Caleb Connolly wrote:
>> Like the c630, the OnePlus 6 is also capable of using both antenna
>> channels for 2.4 and 5ghz wifi, however unlike the c630 only the first
>> channel is used for bluetooth.
>>
>> Signed-off-by: Caleb Connolly <caleb@connolly.tech>
>> ---
>> arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi | 7 +++++++
>> 1 file changed, 7 insertions(+)
>>
>> diff --git a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> index d4355522374a..8bf2430a3af7 100644
>> --- a/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> +++ b/arch/arm64/boot/dts/qcom/sdm845-oneplus-common.dtsi
>> @@ -248,6 +248,12 @@ vreg_l20a_2p95: ldo20 {
>> regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> };
>>
>> + vreg_l23a_3p3: ldo23 {
>> + regulator-min-microvolt = <3300000>;
>> + regulator-max-microvolt = <3312000>;
>> + regulator-initial-mode = <RPMH_REGULATOR_MODE_HPM>;
>> + };
>> +
>> vdda_qusb_hs0_3p1:
>> vreg_l24a_3p075: ldo24 {
>> regulator-min-microvolt = <3088000>;
>> @@ -647,6 +653,7 @@ &wifi {
>> vdd-1.8-xo-supply = <&vreg_l7a_1p8>;
>> vdd-1.3-rfa-supply = <&vreg_l17a_1p3>;
>> vdd-3.3-ch0-supply = <&vreg_l25a_3p3>;
>> + vdd-3.3-ch1-supply = <&vreg_l23a_3p3>;
>>
>> qcom,snoc-host-cap-8bit-quirk;
>> };
>> --
>> 2.33.1
>>
>>
> Just for the record, I added it for completeness, as far as I can tell,
> the bluetooth driver itself won't use the second channel.
Ah I see, I can confirm that the bluetooth hardware is only connected to the first channel on the op6, so with wifi off
the second antenna can also be turned off to save power without affecting bluetooth signal strength.
>
>
> -- steev
>
--
Kind Regards,
Caleb
^ permalink raw reply [flat|nested] 3+ messages in thread
end of thread, other threads:[~2021-10-20 17:24 UTC | newest]
Thread overview: 3+ messages (download: mbox.gz follow: Atom feed
-- links below jump to the message on this page --
2021-10-20 16:36 [PATCH] arm64: dts: qcom: sdm845-oneplus: enable second wifi channel Caleb Connolly
2021-10-20 17:13 ` Steev Klimaszewski
2021-10-20 17:24 ` Caleb Connolly
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).