[PATCH 1/2] ARM: dts: Fix bootup issue on smdk5250

[PATCH 1/2] ARM: dts: Fix bootup issue on smdk5250

[Yadwinder Singh Brar]

With default config on smdk5250 latest tree throws below message :

[    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
[    2.227840] reboot: Failed to start orderly shutdown: forcing the issue

and hangs randomly because it reads wrong temperature value.

I can't figure out any direct relation between LDO10 and TMU from board
schematics which I have. So making LDO10 always-on to fix issue for now.

Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
---
 arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
 1 files changed, 1 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index bc27cc2..95b5b51 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -190,6 +190,7 @@
 				regulator-name = "P1.8V_LDO_OUT10";
 				regulator-min-microvolt = <1800000>;
 				regulator-max-microvolt = <1800000>;
+				regulator-always-on;
 			};
 
 			ldo11_reg: LDO11 {
-- 
1.7.0.4

[PATCH 2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

[Yadwinder Singh Brar]

This patch adds pinctrl configuration for using configuring gpx3-2 as an
external interrupt from max77686. Though max77686 RTC is enabled and gets
probed by default, it doesnt work as its unable to get interrupt.

This patch makes max77686 RTC work and also configures it as wakeup source.

Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
---
 arch/arm/boot/dts/exynos5250-smdk5250.dts |   12 ++++++++++++
 1 files changed, 12 insertions(+), 0 deletions(-)

diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
index 95b5b51..19cd918 100644
--- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
+++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
@@ -131,6 +131,9 @@
 		reg = <0x09>;
 		interrupt-parent = <&gpx3>;
 		interrupts = <2 IRQ_TYPE_NONE>;
+		pinctrl-names = "default";
+		pinctrl-0 = <&max77686_irq>;
+		wakeup-source;
 
 		voltage-regulators {
 			ldo1_reg: LDO1 {
@@ -411,3 +414,12 @@
 		};
 	};
 };
+
+&pinctrl_0 {
+	max77686_irq: max77686-irq {
+		samsung,pins = "gpx3-2";
+		samsung,pin-function = <0xf>;
+		samsung,pin-pud = <0>;
+		samsung,pin-drv = <0>;
+	};
+};
-- 
1.7.0.4

Re: [PATCH 2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

[Javier Martinez Canillas]

Hello Yadwinder,

On Tue, Nov 18, 2014 at 1:08 PM, Yadwinder Singh Brar
<yadi.brar@samsung.com> wrote:
> This patch adds pinctrl configuration for using configuring gpx3-2 as an
> external interrupt from max77686. Though max77686 RTC is enabled and gets
> probed by default, it doesnt work as its unable to get interrupt.
>

I'm not familiar with this board but the patch looks good to me
assuming the IRQ is the correct one.

Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>

Best regards,
Javier

Re: [2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

[Pankaj Dubey]

Hi,

On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
> This patch adds pinctrl configuration for using configuring gpx3-2 as an
> external interrupt from max77686. Though max77686 RTC is enabled and gets
> probed by default, it doesnt work as its unable to get interrupt.
>
> This patch makes max77686 RTC work and also configures it as wakeup source.
>
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>

Tested this on SMDK5250, and with this PMIC RTC is working fine.

Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>

Thanks,
Pankaj Dubey
> ---
> arch/arm/boot/dts/exynos5250-smdk5250.dts |   12 ++++++++++++
>   1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index 95b5b51..19cd918 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -131,6 +131,9 @@
>   		reg = <0x09>;
>   		interrupt-parent = <&gpx3>;
>   		interrupts = <2 IRQ_TYPE_NONE>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&max77686_irq>;
> +		wakeup-source;
>
>   		voltage-regulators {
>   			ldo1_reg: LDO1 {
> @@ -411,3 +414,12 @@
>   		};
>   	};
>   };
> +
> +&pinctrl_0 {
> +	max77686_irq: max77686-irq {
> +		samsung,pins = "gpx3-2";
> +		samsung,pin-function = <0xf>;
> +		samsung,pin-pud = <0>;
> +		samsung,pin-drv = <0>;
> +	};
> +};
>

Re: [2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

[Pankaj Dubey]

Hi Kukjin,

Any updated for this patch. Without this PMIC RTC is not working on 
SMDK5250.

Thanks,
Pankaj Dubey

On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
> This patch adds pinctrl configuration for using configuring gpx3-2 as an
> external interrupt from max77686. Though max77686 RTC is enabled and gets
> probed by default, it doesnt work as its unable to get interrupt.
>
> This patch makes max77686 RTC work and also configures it as wakeup source.
>
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>
> ---
> arch/arm/boot/dts/exynos5250-smdk5250.dts |   12 ++++++++++++
>   1 files changed, 12 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index 95b5b51..19cd918 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -131,6 +131,9 @@
>   		reg = <0x09>;
>   		interrupt-parent = <&gpx3>;
>   		interrupts = <2 IRQ_TYPE_NONE>;
> +		pinctrl-names = "default";
> +		pinctrl-0 = <&max77686_irq>;
> +		wakeup-source;
>
>   		voltage-regulators {
>   			ldo1_reg: LDO1 {
> @@ -411,3 +414,12 @@
>   		};
>   	};
>   };
> +
> +&pinctrl_0 {
> +	max77686_irq: max77686-irq {
> +		samsung,pins = "gpx3-2";
> +		samsung,pin-function = <0xf>;
> +		samsung,pin-pud = <0>;
> +		samsung,pin-drv = <0>;
> +	};
> +};
>

Re: [2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

[Krzysztof Kozlowski]

W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
> Hi Kukjin,
> 
> Any updated for this patch. Without this PMIC RTC is not working on
> SMDK5250.
> 

Could you resend the patch after rebasing it?

Best regards,
Krzysztof

> Thanks,
> Pankaj Dubey
> 
> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
>> This patch adds pinctrl configuration for using configuring gpx3-2 as an
>> external interrupt from max77686. Though max77686 RTC is enabled and gets
>> probed by default, it doesnt work as its unable to get interrupt.
>>
>> This patch makes max77686 RTC work and also configures it as wakeup
>> source.
>>
>> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>> ---
>> arch/arm/boot/dts/exynos5250-smdk5250.dts |   12 ++++++++++++
>>   1 files changed, 12 insertions(+), 0 deletions(-)
>>
>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> index 95b5b51..19cd918 100644
>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>> @@ -131,6 +131,9 @@
>>           reg = <0x09>;
>>           interrupt-parent = <&gpx3>;
>>           interrupts = <2 IRQ_TYPE_NONE>;
>> +        pinctrl-names = "default";
>> +        pinctrl-0 = <&max77686_irq>;
>> +        wakeup-source;
>>
>>           voltage-regulators {
>>               ldo1_reg: LDO1 {
>> @@ -411,3 +414,12 @@
>>           };
>>       };
>>   };
>> +
>> +&pinctrl_0 {
>> +    max77686_irq: max77686-irq {
>> +        samsung,pins = "gpx3-2";
>> +        samsung,pin-function = <0xf>;
>> +        samsung,pin-pud = <0>;
>> +        samsung,pin-drv = <0>;
>> +    };
>> +};
>>
> -- 
> To unsubscribe from this list: send the line "unsubscribe
> linux-samsung-soc" in
> the body of a message to majordomo@vger.kernel.org
> More majordomo info at  http://vger.kernel.org/majordomo-info.html

Re: [2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

[Krzysztof Kozlowski]

2015-05-02 14:49 GMT+09:00 Krzysztof Kozlowski <k.kozlowski.k@gmail.com>:
> W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
>> Hi Kukjin,
>>
>> Any updated for this patch. Without this PMIC RTC is not working on
>> SMDK5250.
>>
>
> Could you resend the patch after rebasing it?
>
> Best regards,
> Krzysztof

Dear Pankaj and Yadwinder,

Do you plan to do anything with this patch?

Best regards,
Krzysztof


>> Thanks,
>> Pankaj Dubey
>>
>> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
>>> This patch adds pinctrl configuration for using configuring gpx3-2 as an
>>> external interrupt from max77686. Though max77686 RTC is enabled and gets
>>> probed by default, it doesnt work as its unable to get interrupt.
>>>
>>> This patch makes max77686 RTC work and also configures it as wakeup
>>> source.
>>>
>>> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>>
>>> ---
>>> arch/arm/boot/dts/exynos5250-smdk5250.dts |   12 ++++++++++++
>>>   1 files changed, 12 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> index 95b5b51..19cd918 100644
>>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> @@ -131,6 +131,9 @@
>>>           reg = <0x09>;
>>>           interrupt-parent = <&gpx3>;
>>>           interrupts = <2 IRQ_TYPE_NONE>;
>>> +        pinctrl-names = "default";
>>> +        pinctrl-0 = <&max77686_irq>;
>>> +        wakeup-source;
>>>
>>>           voltage-regulators {
>>>               ldo1_reg: LDO1 {
>>> @@ -411,3 +414,12 @@
>>>           };
>>>       };
>>>   };
>>> +
>>> +&pinctrl_0 {
>>> +    max77686_irq: max77686-irq {
>>> +        samsung,pins = "gpx3-2";
>>> +        samsung,pin-function = <0xf>;
>>> +        samsung,pin-pud = <0>;
>>> +        samsung,pin-drv = <0>;
>>> +    };
>>> +};
>>>
>> --
>> To unsubscribe from this list: send the line "unsubscribe
>> linux-samsung-soc" in
>> the body of a message to majordomo@vger.kernel.org
>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>

Re: [2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

[Pankaj Dubey]

Hi Krzysztof,

On Monday 17 August 2015 11:20 AM, Krzysztof Kozlowski wrote:
> 2015-05-02 14:49 GMT+09:00 Krzysztof Kozlowski <k.kozlowski.k@gmail.com>:
>> W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
>>> Hi Kukjin,
>>>
>>> Any updated for this patch. Without this PMIC RTC is not working on
>>> SMDK5250.
>>>
>>
>> Could you resend the patch after rebasing it?
>>
>> Best regards,
>> Krzysztof
>
> Dear Pankaj and Yadwinder,
>
> Do you plan to do anything with this patch?
>

Thanks for reminding us. Somehow I missed this.
I will resend the patch shortly after rebasing and testing.

Thanks,
Pankaj Dubey

> Best regards,
> Krzysztof
>
>
>>> Thanks,
>>> Pankaj Dubey
>>>
>>> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
>>>> This patch adds pinctrl configuration for using configuring gpx3-2 as an
>>>> external interrupt from max77686. Though max77686 RTC is enabled and gets
>>>> probed by default, it doesnt work as its unable to get interrupt.
>>>>
>>>> This patch makes max77686 RTC work and also configures it as wakeup
>>>> source.
>>>>
>>>> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>>>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>>> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>>>
>>>> ---
>>>> arch/arm/boot/dts/exynos5250-smdk5250.dts |   12 ++++++++++++
>>>>    1 files changed, 12 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> index 95b5b51..19cd918 100644
>>>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> @@ -131,6 +131,9 @@
>>>>            reg = <0x09>;
>>>>            interrupt-parent = <&gpx3>;
>>>>            interrupts = <2 IRQ_TYPE_NONE>;
>>>> +        pinctrl-names = "default";
>>>> +        pinctrl-0 = <&max77686_irq>;
>>>> +        wakeup-source;
>>>>
>>>>            voltage-regulators {
>>>>                ldo1_reg: LDO1 {
>>>> @@ -411,3 +414,12 @@
>>>>            };
>>>>        };
>>>>    };
>>>> +
>>>> +&pinctrl_0 {
>>>> +    max77686_irq: max77686-irq {
>>>> +        samsung,pins = "gpx3-2";
>>>> +        samsung,pin-function = <0xf>;
>>>> +        samsung,pin-pud = <0>;
>>>> +        samsung,pin-drv = <0>;
>>>> +    };
>>>> +};
>>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe
>>> linux-samsung-soc" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>

Re: [2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

[Pankaj Dubey]

Hi Krzysztof,

On Monday 17 August 2015 11:20 AM, Krzysztof Kozlowski wrote:
> 2015-05-02 14:49 GMT+09:00 Krzysztof Kozlowski <k.kozlowski.k@gmail.com>:
>> W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
>>> Hi Kukjin,
>>>
>>> Any updated for this patch. Without this PMIC RTC is not working on
>>> SMDK5250.
>>>
>>
>> Could you resend the patch after rebasing it?
>>
>> Best regards,
>> Krzysztof
>
> Dear Pankaj and Yadwinder,
>
> Do you plan to do anything with this patch?
>
> Best regards,
> Krzysztof
>
>

Just noticed that the patch in subject is already merged in kgene tree.
There was another patch "[1/2]: ARM: dts: Fix bootup issue on smdk5250" 
which was posted along with this is still not merged. Resending it once 
again.

[1]: http://www.spinics.net/lists/linux-samsung-soc/msg39100.html

Thanks,
Pankaj Dubey
>>> Thanks,
>>> Pankaj Dubey
>>>
>>> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
>>>> This patch adds pinctrl configuration for using configuring gpx3-2 as an
>>>> external interrupt from max77686. Though max77686 RTC is enabled and gets
>>>> probed by default, it doesnt work as its unable to get interrupt.
>>>>
>>>> This patch makes max77686 RTC work and also configures it as wakeup
>>>> source.
>>>>
>>>> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>>>> Reviewed-by: Javier Martinez Canillas <javier.martinez@collabora.co.uk>
>>>> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>>>
>>>> ---
>>>> arch/arm/boot/dts/exynos5250-smdk5250.dts |   12 ++++++++++++
>>>>    1 files changed, 12 insertions(+), 0 deletions(-)
>>>>
>>>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> index 95b5b51..19cd918 100644
>>>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>>> @@ -131,6 +131,9 @@
>>>>            reg = <0x09>;
>>>>            interrupt-parent = <&gpx3>;
>>>>            interrupts = <2 IRQ_TYPE_NONE>;
>>>> +        pinctrl-names = "default";
>>>> +        pinctrl-0 = <&max77686_irq>;
>>>> +        wakeup-source;
>>>>
>>>>            voltage-regulators {
>>>>                ldo1_reg: LDO1 {
>>>> @@ -411,3 +414,12 @@
>>>>            };
>>>>        };
>>>>    };
>>>> +
>>>> +&pinctrl_0 {
>>>> +    max77686_irq: max77686-irq {
>>>> +        samsung,pins = "gpx3-2";
>>>> +        samsung,pin-function = <0xf>;
>>>> +        samsung,pin-pud = <0>;
>>>> +        samsung,pin-drv = <0>;
>>>> +    };
>>>> +};
>>>>
>>> --
>>> To unsubscribe from this list: send the line "unsubscribe
>>> linux-samsung-soc" in
>>> the body of a message to majordomo@vger.kernel.org
>>> More majordomo info at  http://vger.kernel.org/majordomo-info.html
>>
>

Re: [2/2] ARM: dts: Add missing irq pinctrl for max77686 on smdk5250

[Krzysztof Kozlowski]

On 18.08.2015 15:27, Pankaj Dubey wrote:
> Hi Krzysztof,
> 
> On Monday 17 August 2015 11:20 AM, Krzysztof Kozlowski wrote:
>> 2015-05-02 14:49 GMT+09:00 Krzysztof Kozlowski <k.kozlowski.k@gmail.com>:
>>> W dniu 28.04.2015 o 20:02, Pankaj Dubey pisze:
>>>> Hi Kukjin,
>>>>
>>>> Any updated for this patch. Without this PMIC RTC is not working on
>>>> SMDK5250.
>>>>
>>>
>>> Could you resend the patch after rebasing it?
>>>
>>> Best regards,
>>> Krzysztof
>>
>> Dear Pankaj and Yadwinder,
>>
>> Do you plan to do anything with this patch?
>>
>> Best regards,
>> Krzysztof
>>
>>
> 
> Just noticed that the patch in subject is already merged in kgene tree.

Yes, you're right.

> There was another patch "[1/2]: ARM: dts: Fix bootup issue on smdk5250"
> which was posted along with this is still not merged. Resending it once
> again.
> 
> [1]: http://www.spinics.net/lists/linux-samsung-soc/msg39100.html

Thanks!

Best regards,
Krzysztof

Re: [1/2] ARM: dts: Fix bootup issue on smdk5250

[Pankaj Dubey]

Hi,

On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
> With default config on smdk5250 latest tree throws below message :
>
> [    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
> [    2.227840] reboot: Failed to start orderly shutdown: forcing the issue
>
> and hangs randomly because it reads wrong temperature value.
>
> I can't figure out any direct relation between LDO10 and TMU from board
> schematics which I have. So making LDO10 always-on to fix issue for now.
>
> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>

Tested this on SMDK5250 board, system boot is fine now, hence

Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>

> ---
> arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
>   1 files changed, 1 insertions(+), 0 deletions(-)
>
> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> index bc27cc2..95b5b51 100644
> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> @@ -190,6 +190,7 @@
>   				regulator-name = "P1.8V_LDO_OUT10";
>   				regulator-min-microvolt = <1800000>;
>   				regulator-max-microvolt = <1800000>;
> +				regulator-always-on;
>   			};
>
>   			ldo11_reg: LDO11 {
>

RE: [1/2] ARM: dts: Fix bootup issue on smdk5250

[Kukjin Kim]

Pankaj Dubey wrote:
> 
> Hi,
> 
Hi,

Yadwinder, please don't miss [PATCH 1/2] in subject, so that my e-mail client
can't filter wrong ;)

> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
> > With default config on smdk5250 latest tree throws below message :
> >
> > [    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
> > [    2.227840] reboot: Failed to start orderly shutdown: forcing the issue
> >
> > and hangs randomly because it reads wrong temperature value.
> >
> > I can't figure out any direct relation between LDO10 and TMU from board
> > schematics which I have. So making LDO10 always-on to fix issue for now.
> >
Hmm...strange, I also can't see any relations now...but I need to contact to
hardware guy before applying this, this fixes the problem though.

Thanks,
Kukjin

> > Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> >
> 
> Tested this on SMDK5250 board, system boot is fine now, hence
> 
> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> 
> > ---
> > arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
> >   1 files changed, 1 insertions(+), 0 deletions(-)
> >
> > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > index bc27cc2..95b5b51 100644
> > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > @@ -190,6 +190,7 @@
> >   				regulator-name = "P1.8V_LDO_OUT10";
> >   				regulator-min-microvolt = <1800000>;
> >   				regulator-max-microvolt = <1800000>;
> > +				regulator-always-on;
> >   			};
> >
> >   			ldo11_reg: LDO11 {
> >

RE: [1/2] ARM: dts: Fix bootup issue on smdk5250

[Yadwinder Singh Brar]

Hi Kukjin,

> Subject: RE: [1/2] ARM: dts: Fix bootup issue on smdk5250
> 
> Pankaj Dubey wrote:
> >
> > Hi,
> >
> Hi,
> 
> Yadwinder, please don't miss [PATCH 1/2] in subject, so that my e-mail
> client can't filter wrong ;)
> 

Sure, but I think your mail client had played some trick, as patches
were posted with [PATCH */2] prefix.

> > On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
> > > With default config on smdk5250 latest tree throws below message :
> > >
> > > [    2.226049] thermal thermal_zone0: critical temperature
> reached(224 C),shutting down
> > > [    2.227840] reboot: Failed to start orderly shutdown: forcing
> the issue
> > >
> > > and hangs randomly because it reads wrong temperature value.
> > >
> > > I can't figure out any direct relation between LDO10 and TMU from
> > > board schematics which I have. So making LDO10 always-on to fix
> issue for now.
> > >
> Hmm...strange, I also can't see any relations now...but I need to
> contact to hardware guy before applying this, this fixes the problem
> though.
> 

Ok, sure it will be good know actual relation from hardware guy.

Meanwhile can we get another patch[1] merged which was posted along
with patch just because both patches were on same file. Otherwise
there is no dependency between them and can be applied independently.

Best Regards,
Yadwinder

[1] : http://www.spinics.net/lists/linux-samsung-soc/msg39107.html

> Thanks,
> Kukjin
> 
> > > Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
> > >
> >
> > Tested this on SMDK5250 board, system boot is fine now, hence
> >
> > Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
> >
> > > ---
> > > arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
> > >   1 files changed, 1 insertions(+), 0 deletions(-)
> > >
> > > diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > index bc27cc2..95b5b51 100644
> > > --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
> > > @@ -190,6 +190,7 @@
> > >   				regulator-name = "P1.8V_LDO_OUT10";
> > >   				regulator-min-microvolt = <1800000>;
> > >   				regulator-max-microvolt = <1800000>;
> > > +				regulator-always-on;
> > >   			};
> > >
> > >   			ldo11_reg: LDO11 {
> > >

Re: [1/2] ARM: dts: Fix bootup issue on smdk5250

[Pankaj Dubey]

Hi Kukjin,

On Saturday 22 November 2014 08:55 AM, Kukjin Kim wrote:
> Pankaj Dubey wrote:
>>
>> Hi,
>>
> Hi,
>
> Yadwinder, please don't miss [PATCH 1/2] in subject, so that my e-mail client
> can't filter wrong ;)
>
>> On Tuesday 18 November 2014 05:38 PM, Yadwinder Singh Brar wrote:
>>> With default config on smdk5250 latest tree throws below message :
>>>
>>> [    2.226049] thermal thermal_zone0: critical temperature reached(224 C),shutting down
>>> [    2.227840] reboot: Failed to start orderly shutdown: forcing the issue
>>>
>>> and hangs randomly because it reads wrong temperature value.
>>>
>>> I can't figure out any direct relation between LDO10 and TMU from board
>>> schematics which I have. So making LDO10 always-on to fix issue for now.
>>>
> Hmm...strange, I also can't see any relations now...but I need to contact to
> hardware guy before applying this, this fixes the problem though.
>

By any chance you got time to check with HW engineer, as issue is there 
without this patch, SMDK5250 fails to boot and hangs.

Thanks,
Pankaj Dubey

> Thanks,
> Kukjin
>
>>> Signed-off-by: Yadwinder Singh Brar <yadi.brar@samsung.com>
>>>
>>
>> Tested this on SMDK5250 board, system boot is fine now, hence
>>
>> Tested-by: Pankaj Dubey <pankaj.dubey@samsung.com>
>>
>>> ---
>>> arch/arm/boot/dts/exynos5250-smdk5250.dts |    1 +
>>>    1 files changed, 1 insertions(+), 0 deletions(-)
>>>
>>> diff --git a/arch/arm/boot/dts/exynos5250-smdk5250.dts b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> index bc27cc2..95b5b51 100644
>>> --- a/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> +++ b/arch/arm/boot/dts/exynos5250-smdk5250.dts
>>> @@ -190,6 +190,7 @@
>>>    				regulator-name = "P1.8V_LDO_OUT10";
>>>    				regulator-min-microvolt = <1800000>;
>>>    				regulator-max-microvolt = <1800000>;
>>> +				regulator-always-on;
>>>    			};
>>>
>>>    			ldo11_reg: LDO11 {
>>>
>
>