From: "Markus Stockhausen" <markus.stockhausen@gmx.de>
To: <andrew@lunn.ch>
Cc: <robh@kernel.org>, <conor+dt@kernel.org>,
<devicetree@vger.kernel.org>, <netdev@vger.kernel.org>
Subject: AW: [PATCH net-next v14 03/13] net: mdio: realtek-rtl9300: deny C45 over C22 access
Date: Mon, 24 Aug 2026 14:03:13 +0200 [thread overview]
Message-ID: <039501dd33c0$8ae34330$a0a9c990$@gmx.de> (raw)
In-Reply-To: <20260818162727.0392E1F000E9@smtp.kernel.org>
Hi Andrew,
> Von: sashiko-bot@kernel.org <sashiko-bot@kernel.org>
> Gesendet: Dienstag, 18. August 2026 18:27
> An: Markus Stockhausen <markus.stockhausen@gmx.de>
> Cc: robh@kernel.org; conor+dt@kernel.org; devicetree@vger.kernel.org
> Betreff: Re: [PATCH net-next v14 03/13] net: mdio: realtek-rtl9300: deny C45 over C22 access
>
> Thank you for your contribution! Sashiko AI review found 2 potential issue(s) to consider:
> - [High] Using `dev_WARN_ONCE` for an unsupported hardware operation triggers kernel
> stack traces and potential panics, creating a local denial of service vector.
> - [Medium] Returning the internal `-ENOTSUPP` error code instead of the standard `-EOPNOTSUPP`
> breaks error handling and leaks internal kernel error codes to user-space.
In contrast to your v13 advise Sashiko is unhappy with the implementation
Switching to -EOPNOTSUPP sounds logical. Regarding the other complaint.
Should I switch to dev_warn_once() then or keep as is?
Markus
next prev parent reply other threads:[~2026-08-24 12:03 UTC|newest]
Thread overview: 32+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-08-17 16:26 [PATCH net-next v14 00/13] net: mdio: realtek-rtl9300: Add RTL83xx support Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 01/13] dt-bindings: net: realtek,rtl9301-mdio: Add RTL83xx series Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 02/13] net: mdio: realtek-rtl9300: Add polling documentation Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 03/13] net: mdio: realtek-rtl9300: deny C45 over C22 access Markus Stockhausen
2026-08-18 16:27 ` sashiko-bot
2026-08-24 12:03 ` Markus Stockhausen [this message]
2026-08-17 16:26 ` [PATCH net-next v14 04/13] net: phy: add phy_detach_internal() helper Markus Stockhausen
2026-08-17 16:41 ` Andrew Lunn
2026-08-18 16:27 ` sashiko-bot
2026-08-17 16:26 ` [PATCH net-next v14 05/13] net: phy: add (*notify_phy_attach/detach)() hooks to struct mii_bus Markus Stockhausen
2026-08-17 16:46 ` Andrew Lunn
2026-08-17 16:26 ` [PATCH net-next v14 06/13] net: mdio: realtek-rtl9300: suppress sysfs bind/unbind attributes Markus Stockhausen
2026-08-17 16:47 ` Andrew Lunn
2026-08-18 16:27 ` sashiko-bot
2026-08-17 16:26 ` [PATCH net-next v14 07/13] net: mdio: realtek-rtl9300: Configure hardware polling during probing Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 08/13] net: mdio: realtek-rtl9300: Add page tracking Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 09/13] net: mdio: realtek-rtl9300: Increase MDIO timeout Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 10/13] net: mdio: realtek-rtl9300: Open up C22 and C45 space in parallel Markus Stockhausen
2026-08-17 17:03 ` Andrew Lunn
2026-08-17 17:29 ` AW: " Markus Stockhausen
2026-08-17 19:35 ` Andrew Lunn
2026-08-17 20:05 ` AW: " Markus Stockhausen
2026-08-17 20:10 ` Andrew Lunn
2026-08-17 20:25 ` AW: " Markus Stockhausen
2026-08-17 20:31 ` Andrew Lunn
2026-08-18 17:44 ` AW: " Markus Stockhausen
2026-08-18 19:32 ` Andrew Lunn
2026-08-18 16:27 ` sashiko-bot
2026-08-17 16:26 ` [PATCH net-next v14 11/13] net: mdio: realtek-rtl9300: Add support for RTL838x Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 12/13] net: mdio: realtek-rtl9300: Add support for RTL839x Markus Stockhausen
2026-08-17 16:26 ` [PATCH net-next v14 13/13] net: mdio: realtek-rtl9300: reword Kconfig and module description Markus Stockhausen
2026-08-17 17:25 ` [PATCH net-next v14 00/13] net: mdio: realtek-rtl9300: Add RTL83xx support Jakub Kicinski
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to='039501dd33c0$8ae34330$a0a9c990$@gmx.de' \
--to=markus.stockhausen@gmx.de \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=netdev@vger.kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox