From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id 4F3F5C05027 for ; Wed, 1 Feb 2023 09:57:27 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S232207AbjBAJ50 (ORCPT ); Wed, 1 Feb 2023 04:57:26 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:38992 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S232184AbjBAJ5Y (ORCPT ); Wed, 1 Feb 2023 04:57:24 -0500 Received: from mail-wm1-x32e.google.com (mail-wm1-x32e.google.com [IPv6:2a00:1450:4864:20::32e]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 03E4650840 for ; Wed, 1 Feb 2023 01:57:21 -0800 (PST) Received: by mail-wm1-x32e.google.com with SMTP id c10-20020a05600c0a4a00b003db0636ff84so961333wmq.0 for ; Wed, 01 Feb 2023 01:57:20 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :from:to:cc:subject:date:message-id:reply-to; bh=ePSrTzkMMNng2khdgheQOIcDWatP1PEI00zqDrWQnks=; b=oYP1aL6QJH56IKmeEBcKnbjMi6/NvzJeVrQZ9Klxdvk8dvINMrXZJ/J+7/ggXz7gZA U24dj5BIRXwrHxhzfDMapYDhJaRTSHqy8SN2dB4wu4iYUtsmoaAIdTTXC0ONo815UkoS DAzFUmL4WbuVX4yjnFjuJds4m7XqW8bOuUxWsAn+rud6vhx+IPGhltGll2KchHDW239J LeZfGKto7niCkyb+oaif2uVsuDhXvL6x71Va2XYNYT74/EvHagmrP4tpSd45iSehLB3l 86FC5XanFGhfmQzHmZY1gafBkm5qvzYYA+2TLxeYGl0sG2hLJTwqS/dVCidwoAYoSCcr NGIA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=content-transfer-encoding:in-reply-to:from:references:cc:to :content-language:subject:user-agent:mime-version:date:message-id :x-gm-message-state:from:to:cc:subject:date:message-id:reply-to; bh=ePSrTzkMMNng2khdgheQOIcDWatP1PEI00zqDrWQnks=; b=S5dOVvUqe9iuyB4Pae7KGY9fFcTxlHyGL3qq+HtBqzHGAcyTzeGRQ7Db+zx9ZX5P/p zhgLURpNj1McIiw8IV0XmWGsGI9On2yJzzvidp6wZ4ngm2xwryKQnq7TGr5KB7/h/2xh asQmst1PxYGGF1fFilSA9d5FgVJHITvAjj6s7bS3aNX1iuIgHgfjIAJI0nn/mMOF8qSZ M9V0B2t48FfhyrlHCvfPP97jq2rkvgYtQuT48ypeJchc5iMvDWjnCsr7hhlmiS/T0X5i MSnkfeyA2LDzcBt40qCVWB2ImFeZSBmWWXi/9V62AE8Rcpo5Jx/W0hFPYLlJ9wi/1QMu dxdA== X-Gm-Message-State: AO0yUKXL9knDFspFlXYmI2u1SxIhF6cX9GCpw3kXAA82TqsWe4EBZjbA cPzZCLLgI7Mw1usR9Rsc4LB1Dw== X-Google-Smtp-Source: AK7set+Zr918sBtF0rKPtTPU2ScDCggLyV4vVqb7ZJqK6OseqgAP8hHBEGS8nh3iKyB8TlpBXtxFiQ== X-Received: by 2002:a05:600c:b88:b0:3dc:5965:2c35 with SMTP id fl8-20020a05600c0b8800b003dc59652c35mr1313977wmb.24.1675245439466; Wed, 01 Feb 2023 01:57:19 -0800 (PST) Received: from [192.168.1.109] ([178.197.216.144]) by smtp.gmail.com with ESMTPSA id h14-20020a05600c314e00b003db0b0cc2afsm1312914wmo.30.2023.02.01.01.57.17 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Wed, 01 Feb 2023 01:57:19 -0800 (PST) Message-ID: <039986bb-a3e0-2482-9853-30532df10ff8@linaro.org> Date: Wed, 1 Feb 2023 10:57:16 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:102.0) Gecko/20100101 Thunderbird/102.7.1 Subject: Re: [PATCH v8 06/17] dt-bindings: mfd: amd,pensando-elbasr: Add AMD Pensando Elba System Resource chip Content-Language: en-US To: Brad Larson , robh@kernel.org Cc: adrian.hunter@intel.com, alcooperx@gmail.com, andy.shevchenko@gmail.com, arnd@arndb.de, brad@pensando.io, brijeshkumar.singh@amd.com, broonie@kernel.org, catalin.marinas@arm.com, devicetree@vger.kernel.org, fancer.lancer@gmail.com, gerg@linux-m68k.org, gsomlo@gmail.com, krzk@kernel.org, krzysztof.kozlowski+dt@linaro.org, lee.jones@linaro.org, linux-arm-kernel@lists.infradead.org, linux-kernel@vger.kernel.org, linux-mmc@vger.kernel.org, p.yadav@ti.com, p.zabel@pengutronix.de, piotrs@cadence.com, rdunlap@infradead.org, samuel@sholland.org, suravee.suthikulpanit@amd.com, thomas.lendacky@amd.com, ulf.hansson@linaro.org, will@kernel.org, yamada.masahiro@socionext.com References: <20221116223045.GA1130586-robh@kernel.org> <20230130191248.1933-1-blarson@amd.com> From: Krzysztof Kozlowski In-Reply-To: <20230130191248.1933-1-blarson@amd.com> Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 30/01/2023 20:12, Brad Larson wrote: > Hi Rob, > > On Wednesday, November 16, 2022 2:30 PM, Rob Herring wrote: >> On Wed, Nov 16, 2022 at 11:39:40AM -0800, Brad Larson wrote: >>> Add support for the AMD Pensando Elba SoC System Resource chip >>> using the SPI interface. >> >> Please resend the whole series properly threaded. > > Series sent as v9 > >>> +description: | >>> + AMD Pensando Elba SoC Resource Controller functions are >>> + accessed with four chip-selects. Reset control is on CS0. >> >> One device with 4 chip-selects? Then I'd expect 'reg = <0 1 2 3>;' >> >> Hard to say more because I don't have the whole thread nor remember what >> exactly we discussed before. That was 100s of bindings ago... > > This has been changed to one device and four chip selects. This binding error > is occuring for snps,dw-apb-ssi.yaml using reg for the chip selects. Any > guidance on how to fix? > > $ make ARCH=arm64 dtbs_check DT_SCHEMA_FILES=Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml > LINT Documentation/devicetree/bindings > CHKDT Documentation/devicetree/bindings/processed-schema.json > SCHEMA Documentation/devicetree/bindings/processed-schema.json > DTC_CHK arch/arm64/boot/dts/amd/elba-asic.dtb > /home/brad/linux.v10/arch/arm64/boot/dts/amd/elba-asic.dtb: spi@2800: system-controller@0:reg: [[0], [1], [2], [3]] is too long > From schema: /home/brad/linux.v10/Documentation/devicetree/bindings/spi/snps,dw-apb-ssi.yaml Maybe this would work in snps,dw-apb-ssi for children: reg: items: minimum: 0 maximum: 3 Best regards, Krzysztof