From: Krzysztof Kozlowski <krzk@kernel.org>
To: ChiYuan Huang <u0084500@gmail.com>
Cc: Mark Brown <broonie@kernel.org>, Rob Herring <robh+dt@kernel.org>,
Liam Girdwood <lgirdwood@gmail.com>,
cy_huang <cy_huang@richtek.com>,
gene_chen@richtek.com, lkml <linux-kernel@vger.kernel.org>,
"open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS"
<devicetree@vger.kernel.org>
Subject: Re: [PATCH 2/2] regulator: rt5759: Add support for Richtek RT5759 DCDC converter
Date: Fri, 25 Mar 2022 16:37:43 +0100 [thread overview]
Message-ID: <03999953-77c5-0272-7477-ab8a069b3671@kernel.org> (raw)
In-Reply-To: <CADiBU3-gwsh5v1NLUYr_ovXwpUxQqgR61f-Jpc3G-zHs_yV4uw@mail.gmail.com>
On 25/03/2022 15:59, ChiYuan Huang wrote:
> Krzysztof Kozlowski <krzk@kernel.org> 於 2022年3月25日 週五 下午10:47寫道：
>>
>>>>> +
>>>>> +static const struct of_device_id __maybe_unused rt5759_device_table[] = {
>>>>
>>>> I don't think this can be __maybe_unused. It is always referenced via
>>>> of_match_table, isn't it?
>>>>
>>> I think it can declared as '__maybe_unused'.
>>> If 'of_device_id' is unused, then in probe stage,
>>> 'of_device_get_match_data' will return NULL.
>>
>> But your of_device_id cannot be unused. It is always referenced.
>>
> I'm not sure, but your assumption is based on 'CONFIG_OF', right?
> Only if 'CONFIG_OF' is not defined, then it'll be really unused.
Is it possible to build this driver without CONFIG_OF? Did you try it?
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-03-25 15:43 UTC|newest]
Thread overview: 21+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-03-25 1:06 [PATCH 0/2] Add Richtek RT5759 buck converter support cy_huang
2022-03-25 1:06 ` [PATCH 1/2] dt-bindings: regulator: Add binding for Richtek RT5759 DCDC converter cy_huang
2022-03-25 12:14 ` Krzysztof Kozlowski
2022-03-25 13:44 ` ChiYuan Huang
2022-03-25 14:46 ` Krzysztof Kozlowski
2022-03-25 14:53 ` ChiYuan Huang
2022-03-25 1:06 ` [PATCH 2/2] regulator: rt5759: Add support " cy_huang
2022-03-25 12:17 ` Krzysztof Kozlowski
2022-03-25 14:10 ` ChiYuan Huang
2022-03-25 14:47 ` Krzysztof Kozlowski
2022-03-25 14:59 ` ChiYuan Huang
2022-03-25 15:37 ` Krzysztof Kozlowski [this message]
2022-03-25 15:50 ` ChiYuan Huang
2022-03-25 15:55 ` Krzysztof Kozlowski
2022-03-25 16:05 ` Mark Brown
2022-03-25 16:08 ` Krzysztof Kozlowski
2022-03-26 0:58 ` ChiYuan Huang
2022-03-26 1:07 ` Mark Brown
2022-03-26 7:55 ` ChiYuan Huang
2022-03-26 8:13 ` Krzysztof Kozlowski
2022-03-26 8:24 ` ChiYuan Huang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03999953-77c5-0272-7477-ab8a069b3671@kernel.org \
--to=krzk@kernel.org \
--cc=broonie@kernel.org \
--cc=cy_huang@richtek.com \
--cc=devicetree@vger.kernel.org \
--cc=gene_chen@richtek.com \
--cc=lgirdwood@gmail.com \
--cc=linux-kernel@vger.kernel.org \
--cc=robh+dt@kernel.org \
--cc=u0084500@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).