From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by smtp.lore.kernel.org (Postfix) with ESMTP id B8147C433EF for ; Fri, 25 Mar 2022 15:43:59 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S244270AbiCYPpa (ORCPT ); Fri, 25 Mar 2022 11:45:30 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:53146 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1377124AbiCYPnH (ORCPT ); Fri, 25 Mar 2022 11:43:07 -0400 Received: from mail-ed1-f51.google.com (mail-ed1-f51.google.com [209.85.208.51]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 6311D4C7AF; Fri, 25 Mar 2022 08:38:02 -0700 (PDT) Received: by mail-ed1-f51.google.com with SMTP id z92so9663873ede.13; Fri, 25 Mar 2022 08:38:02 -0700 (PDT) X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20210112; h=x-gm-message-state:message-id:date:mime-version:user-agent:subject :content-language:to:cc:references:from:in-reply-to :content-transfer-encoding; bh=V3nO6d/mIFndMoIv5fF65xBZWYCs2bp5IpMKAoTo1Bk=; b=49rv8QzOuUg3paKDnyhfd79NRDraOkmlnjj7tWMvnWdlKuwkmcSJICQEpcjgTMYmec GsrBQ3cEQBpjRgVPYbUUnmrXZocIirv3AwXhYo8gPr+3d9tSvH0nU/Ay+A6kt01A9oCB Nc+PV99WPQm31p0WLpJoJ7LVKqh97ASr/SeWOH1yXZWyQUV/4W1Z7iY5rLFi8a05Q35D nA89Y/mUtAQKyEVOqOrGOMtcd+ZZqDhc5zfDAJYlnnTCYW+qdL3vzNHBcEMz4uOOwhAi nf8vGVPGohpUtW56zbRTyryJUsRGumx+MgbK8sTncFxOnAw2XFqLgGS3XRhid0Ptk1cF 5WTA== X-Gm-Message-State: AOAM531cnKzFcJZO1Nq8CgRHi/xZ11HCGRuWmSuQadMGD4pEqcKYR/Zq OhgUMdDdkruKpZf06HaXE461dAG6mVg= X-Google-Smtp-Source: ABdhPJw69lO06lZbj+mR+Dc2s5HgECM0tyKGFhqlueX/AVFEfWdUY7nxhpfEGm2IdcdvQwO0KKVQSw== X-Received: by 2002:a05:6402:40d5:b0:419:496b:5ab0 with SMTP id z21-20020a05640240d500b00419496b5ab0mr13751750edb.284.1648222665503; Fri, 25 Mar 2022 08:37:45 -0700 (PDT) Received: from [192.168.0.162] (xdsl-188-155-201-27.adslplus.ch. [188.155.201.27]) by smtp.googlemail.com with ESMTPSA id bm24-20020a170906c05800b006d58518e55fsm2406059ejb.46.2022.03.25.08.37.43 (version=TLS1_3 cipher=TLS_AES_128_GCM_SHA256 bits=128/128); Fri, 25 Mar 2022 08:37:44 -0700 (PDT) Message-ID: <03999953-77c5-0272-7477-ab8a069b3671@kernel.org> Date: Fri, 25 Mar 2022 16:37:43 +0100 MIME-Version: 1.0 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:91.0) Gecko/20100101 Thunderbird/91.5.0 Subject: Re: [PATCH 2/2] regulator: rt5759: Add support for Richtek RT5759 DCDC converter Content-Language: en-US To: ChiYuan Huang Cc: Mark Brown , Rob Herring , Liam Girdwood , cy_huang , gene_chen@richtek.com, lkml , "open list:OPEN FIRMWARE AND FLATTENED DEVICE TREE BINDINGS" References: <1648170401-6351-1-git-send-email-u0084500@gmail.com> <1648170401-6351-3-git-send-email-u0084500@gmail.com> From: Krzysztof Kozlowski In-Reply-To: Content-Type: text/plain; charset=UTF-8 Content-Transfer-Encoding: 8bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 25/03/2022 15:59, ChiYuan Huang wrote: > Krzysztof Kozlowski 於 2022年3月25日 週五 下午10:47寫道： >> >>>>> + >>>>> +static const struct of_device_id __maybe_unused rt5759_device_table[] = { >>>> >>>> I don't think this can be __maybe_unused. It is always referenced via >>>> of_match_table, isn't it? >>>> >>> I think it can declared as '__maybe_unused'. >>> If 'of_device_id' is unused, then in probe stage, >>> 'of_device_get_match_data' will return NULL. >> >> But your of_device_id cannot be unused. It is always referenced. >> > I'm not sure, but your assumption is based on 'CONFIG_OF', right? > Only if 'CONFIG_OF' is not defined, then it'll be really unused. Is it possible to build this driver without CONFIG_OF? Did you try it? Best regards, Krzysztof