From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-wr1-f49.google.com (mail-wr1-f49.google.com [209.85.221.49]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id CE08B2FF65E for ; Wed, 5 Nov 2025 10:16:23 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.221.49 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762337785; cv=none; b=ExONo0lj/1iv6XiM5QQCHy7Zv+bpgEx3J98uaTHAtXVAot4mP7yyhaFTUFgsQECqugWYmq3IowDAT7sgTqc04k/nKfumrvxmo1tkLSs3KUEgLBP5l89sVSG8hSTY/g4+jRs3yRY5f5XIQO7z663xwpsy7n9uzRSi2DSixCo2w9M= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1762337785; c=relaxed/simple; bh=o8q8eHDOchVGcfDlePXk+hD6Np8WGRhU4jrr7Ucvbcg=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=s4dr4kMzei4yRXY2ruB8EN888eW7NUhiUtKkbJ7BBXyxiFnM1DtcSqgIYQ7Wcb0P59bt+cAOtONEdR3JoU19+5lzVlxlGNwoxkOxpjCDG0Oe6GkJAYC7BcXF7ILt87mMJlM1gyTJ4pQV48vAhUfsPwlnZAb+/5t6f00t0DsXqFo= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=mbU0x/kM; arc=none smtp.client-ip=209.85.221.49 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="mbU0x/kM" Received: by mail-wr1-f49.google.com with SMTP id ffacd0b85a97d-3f99ac9acc4so5670078f8f.3 for ; Wed, 05 Nov 2025 02:16:23 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1762337782; x=1762942582; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=o8q8eHDOchVGcfDlePXk+hD6Np8WGRhU4jrr7Ucvbcg=; b=mbU0x/kMB1aySzc0xzuEM5FuSE1snAnaK11Z2damf3P85NbMgCZdPa5UzmFYVRRegG th9L0SAbRWbwMoSbSjn+bSd4+PXZydLiBhklusF5fjFTzMmFUkZ3oVPnx+19zqNo5aMl JX5fbq6k3vaBuS24JBljGn8tGVdrReOMnfTgI26CxMqZTaMo0bXOcugppjMLSrkaijU9 G+VW9EaiTMyvEmZOeu+bj11+t1uKDEd2eIJbNdKyrs002m/QeQsxMjb61ID9dgbjH5et PioEQPCP9pN01dzuAdzzyKo/aajNCU4KU5NOz/1P2s/J95hpGqaploBtJWMG5umacdC2 LnJw== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1762337782; x=1762942582; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=o8q8eHDOchVGcfDlePXk+hD6Np8WGRhU4jrr7Ucvbcg=; b=QAMiItM5vNYjqyNc5qfkqq5XpxzoROKNEDd/W5JczD7oyC8p8uKTt39/F6jdXsB2zO 5HM9lGfe9EV2Zv3yGI2XRpWFGme/aaUrhOhYOd7MQL6jGkMkXg4w5MuSh7cBcWism14c 6R7uILyf9IjQwBtsQhDqqpHJrxoRUizc/K98182CmvivwMli14tl8EFWGyGvpmjUZY1M 5Ya9H5jRRGkG+NfydUFH2HdANNzP/ltNDDiBpiYM7kalYkvFFiRUo99mPoHePcTQNQ0i FKoH/QWRUWtIY+q9gk74w70g4mJfjzVTr/NcC6rtCuJEbGeLaROWrfT0Lf1k7ysOxpLc O6Aw== X-Forwarded-Encrypted: i=1; AJvYcCU6pnY9IJNTrQMpob1+ouFCP9B9RxVSmu1RiX1tJuZJw/YnodAPoqbWwsX8E0pZaDcgfQkTQx2/COYi@vger.kernel.org X-Gm-Message-State: AOJu0YzG+vCnxNfCLufqH1F/Fin21GraWHnIVwOqilpDliisjZrN3LJZ uQuGD9c3eZltYkajBLQFj3mrVW73D7niDfGIzzFbGiqmI9ONj5E/hR0s X-Gm-Gg: ASbGncsict9vgRbbayYkND/gVphodq4SyLmZqr2YtVmKypC4yw25UA+bc7tioxDHhht KzLap+2wVOdeBairdY5J9c43N30GYZZ72hPV+8ZFrgvCnLdFNgaIwc1zkXG7sn29dNH2pngsaJ+ qPdFNI6PI67On/96q9z42tZH5148pJSRn3skn3Jj7RBI6ES6qtwulBYiYGInhb8z2Gizu0nKrEe GHXLxYa3EUpPDsD8XPybv6jXhVc9jG+USN+WKqpktPUFWn2nYrig1DqFH4kfgTg+xzeStx98K6P w+YYEETAnQIemAdQLJDlS1IRmmI90wg2dyOEmDNBzyeD+h3vGweUynUZpNb5a3yvUKWgRxB62a6 Me3WKhD3rzyaSN+RY7mSI9Iie57pAUIy45CwI5zY21t8epXfJrNhtiYuJriImGmE+S+23Me3a6M 4XLcz7xAOy X-Google-Smtp-Source: AGHT+IEcYoNlOVReU2YdkRKw+el9w65GlaEGkVjAXyNIxaDkcpqgMt83AXD2Voio5N3cYobsRku+Vw== X-Received: by 2002:a05:6000:26c1:b0:426:d81f:483c with SMTP id ffacd0b85a97d-429e33088ddmr2183737f8f.33.1762337781952; Wed, 05 Nov 2025 02:16:21 -0800 (PST) Received: from [192.168.1.187] ([161.230.67.253]) by smtp.gmail.com with ESMTPSA id ffacd0b85a97d-429dc1fbd1csm9667564f8f.38.2025.11.05.02.16.21 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Wed, 05 Nov 2025 02:16:21 -0800 (PST) Message-ID: <039e8f13b876928ca331a5f698aa6c7ca2a5ec5d.camel@gmail.com> Subject: Re: [PATCH v4 00/12] iio: dac: ad5446: Refactor and add support for AD5542 From: Nuno =?ISO-8859-1?Q?S=E1?= To: Andy Shevchenko , nuno.sa@analog.com Cc: linux-iio@vger.kernel.org, devicetree@vger.kernel.org, Michael Hennerich , Jonathan Cameron , David Lechner , Andy Shevchenko , Lars-Peter Clausen , Rob Herring , Krzysztof Kozlowski , Conor Dooley Date: Wed, 05 Nov 2025 10:16:57 +0000 In-Reply-To: References: <20251104-dev-add-ad5542-v4-0-6fe35458bf8c@analog.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.58.1 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 On Tue, 2025-11-04 at 20:30 +0200, Andy Shevchenko wrote: > On Tue, Nov 04, 2025 at 03:35:05PM +0000, Nuno S=C3=A1 via B4 Relay wrote= : > > Alright, what was suposed to be a simple one liner patch ended up being > > a full refactor (modernization) of the whole thing :). I think the > > changes are anyways fairly simple so hopefully nothing was broken. > >=20 > > I'm also aware of the checkpatch failure in Patch 7 ("iio: dac: ad5446: > > Separate I2C/SPI into different drivers") but I'm really not seeing the > > added value of adding the kconfig help text to the core symbol.=20 >=20 > I don't see any major issue with the series, just a bunch of minor nit-pi= cks. > FWIW, > Reviewed-by: Andy Shevchenko >=20 Thanks! If I do need to re-spin, I might get some (or all) of the nit-picks include= d. - Nuno S=C3=A1