From: Krzysztof Kozlowski <krzk@kernel.org>
To: Ayush Singh <ayushdevel1325@gmail.com>, greybus-dev@lists.linaro.org
Cc: devicetree@vger.kernel.org, linux-kernel@vger.kernel.org,
gregkh@linuxfoundation.org,
Vaishnav M A <vaishnav@beagleboard.org>,
Jason Kridner <jkridner@beagleboard.org>,
Nishanth Menon <nm@ti.com>
Subject: Re: [PATCH v4 3/3] dts: ti: k3-am625-beagleplay: Add beaglecc1352
Date: Mon, 4 Sep 2023 09:20:24 +0200 [thread overview]
Message-ID: <03aab2bc-5fd2-956b-23ef-3359ed92db88@kernel.org> (raw)
In-Reply-To: <20230902182845.1840620-4-ayushdevel1325@gmail.com>
On 02/09/2023 20:28, Ayush Singh wrote:
> The BeaglePlay board by BeagleBoard.org has a CC1352 co-processor. This
> co-processor is connected to the main AM62 (running Linux) over UART. The
> CC1352 can run Zephyr and other embedded OS. This commit adds support for
> the CC1352 in the Linux kernel DTS. This allows Linux platform drivers to
> identify the device and communicate with it.
>
> This UART is used by gb-beagleplay, an upcoming Greybus driver for
> BeaglePlay.
upcoming? So not present in this patchset?
>
> Signed-off-by: Ayush Singh <ayushdevel1325@gmail.com>
> ---
> arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts | 4 ++++
> 1 file changed, 4 insertions(+)
>
> diff --git a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> index 7cfdf562b53b..10abbb8feda5 100644
> --- a/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> +++ b/arch/arm64/boot/dts/ti/k3-am625-beagleplay.dts
> @@ -870,6 +870,10 @@ &main_uart6 {
> pinctrl-names = "default";
> pinctrl-0 = <&wifi_debug_uart_pins_default>;
> status = "okay";
> +
> + beaglecc1352 {
Node names should be generic. See also an explanation and list of
examples (not exhaustive) in DT specification:
https://devicetree-specification.readthedocs.io/en/latest/chapter2-devicetree-basics.html#generic-names-recommendation
It does not look like you tested the DTS against bindings. Please run
`make dtbs_check W=1` (see
Documentation/devicetree/bindings/writing-schema.rst or
https://www.linaro.org/blog/tips-and-tricks-for-validating-devicetree-sources-with-the-devicetree-schema/
for instructions).
Best regards,
Krzysztof
next prev parent reply other threads:[~2023-09-04 7:20 UTC|newest]
Thread overview: 14+ messages / expand[flat|nested] mbox.gz Atom feed top
2023-09-02 18:28 [PATCH v4 0/3] greybus: Add BeaglePlay Greybus Driver Ayush Singh
2023-09-02 18:28 ` [PATCH v4 1/3] dt-bindings: Add beaglecc1352 Ayush Singh
2023-09-04 7:14 ` Krzysztof Kozlowski
2023-09-06 16:47 ` Ayush Singh
2023-09-11 6:23 ` Krzysztof Kozlowski
2023-09-02 18:28 ` [PATCH v4 2/3] greybus: Add BeaglePlay Linux Driver Ayush Singh
2023-09-04 7:19 ` Krzysztof Kozlowski
2023-09-05 16:27 ` Ayush Singh
2023-09-06 9:59 ` Krzysztof Kozlowski
2023-09-06 10:33 ` Ayush Singh
2023-09-06 21:05 ` kernel test robot
2023-09-02 18:28 ` [PATCH v4 3/3] dts: ti: k3-am625-beagleplay: Add beaglecc1352 Ayush Singh
2023-09-04 7:20 ` Krzysztof Kozlowski [this message]
2023-09-13 12:57 ` [PATCH v4 0/3] greybus: Add BeaglePlay Greybus Driver Jason Kridner
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03aab2bc-5fd2-956b-23ef-3359ed92db88@kernel.org \
--to=krzk@kernel.org \
--cc=ayushdevel1325@gmail.com \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=greybus-dev@lists.linaro.org \
--cc=jkridner@beagleboard.org \
--cc=linux-kernel@vger.kernel.org \
--cc=nm@ti.com \
--cc=vaishnav@beagleboard.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).