From: "Alexander A. Klimov" <grandmaster@al2klimov.de>
To: Tero Kristo <t-kristo@ti.com>,
nm@ti.com, ssantosh@kernel.org, tglx@linutronix.de,
jason@lakedaemon.net, maz@kernel.org, robh+dt@kernel.org,
p.zabel@pengutronix.de, linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, devicetree@vger.kernel.org
Subject: Re: [PATCH] firmware: ti_sci: Replace HTTP links with HTTPS ones
Date: Mon, 20 Jul 2020 23:27:02 +0200 [thread overview]
Message-ID: <03ad792e-a345-ee3d-02e5-19e489e25787@al2klimov.de> (raw)
In-Reply-To: <7b6caa87-8672-b5d5-ef8d-2fd38a4b53e6@ti.com>
Am 20.07.20 um 09:32 schrieb Tero Kristo:
> Hi Alexander,
Hi,
>
> One comment below.
>
> On 18/07/2020 13:55, Alexander A. Klimov wrote:
>> Rationale:
>> Reduces attack surface on kernel devs opening the links for MITM
>> as HTTPS traffic is much harder to manipulate.
>>
>> Deterministic algorithm:
>> For each file:
>> If not .svg:
>> For each line:
>> If doesn't contain `\bxmlns\b`:
>> For each link, `\bhttp://[^# \t\r\n]*(?:\w|/)`:
>> If neither `\bgnu\.org/license`, nor `\bmozilla\.org/MPL\b`:
>> If both the HTTP and HTTPS versions
>> return 200 OK and serve the same content:
>> Replace HTTP with HTTPS.
>>
>> Signed-off-by: Alexander A. Klimov <grandmaster@al2klimov.de>
>> ---
>> Continuing my work started at 93431e0607e5.
>> See also: git log --oneline '--author=Alexander A. Klimov
>> <grandmaster@al2klimov.de>' v5.7..master
>>
>> If there are any URLs to be removed completely
>> or at least not (just) HTTPSified:
>> Just clearly say so and I'll *undo my change*.
>> See also: https://lkml.org/lkml/2020/6/27/64
>>
>> If there are any valid, but yet not changed URLs:
>> See: https://lkml.org/lkml/2020/6/26/837
>>
>> If you apply the patch, please let me know.
>>
>>
>> .../devicetree/bindings/interrupt-controller/ti,sci-intr.txt | 2 +-
>> drivers/firmware/ti_sci.c | 2 +-
>> drivers/firmware/ti_sci.h | 2 +-
>> drivers/irqchip/irq-ti-sci-inta.c | 2 +-
>> drivers/irqchip/irq-ti-sci-intr.c | 2 +-
>> drivers/reset/reset-ti-sci.c | 2 +-
>> include/linux/soc/ti/ti_sci_inta_msi.h | 2 +-
>> include/linux/soc/ti/ti_sci_protocol.h | 2 +-
>> 8 files changed, 8 insertions(+), 8 deletions(-)
>>
>> diff --git
>> a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> index 1a8718f8855d..178fca08278f 100644
>> ---
>> a/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> +++
>> b/Documentation/devicetree/bindings/interrupt-controller/ti,sci-intr.txt
>> @@ -55,7 +55,7 @@ Required Properties:
>> corresponds to a range of host irqs.
>> For more details on TISCI IRQ resource management refer:
>> -http://downloads.ti.com/tisci/esd/latest/2_tisci_msgs/rm/rm_irq.html
>> +https://downloads.ti.com/tisci/esd/latest/2_tisci_msgs/rm/rm_irq.html
>> Example:
>> --------
>> diff --git a/drivers/firmware/ti_sci.c b/drivers/firmware/ti_sci.c
>> index 4126be9e3216..53cee17d0115 100644
>> --- a/drivers/firmware/ti_sci.c
>> +++ b/drivers/firmware/ti_sci.c
>> @@ -2,7 +2,7 @@
>> /*
>> * Texas Instruments System Control Interface Protocol Driver
>> *
>> - * Copyright (C) 2015-2016 Texas Instruments Incorporated -
>> http://www.ti.com/
>> + * Copyright (C) 2015-2016 Texas Instruments Incorporated -
>> https://www.ti.com/
>> * Nishanth Menon
>> */
>> diff --git a/drivers/firmware/ti_sci.h b/drivers/firmware/ti_sci.h
>> index f0d068c03944..57cd04062994 100644
>> --- a/drivers/firmware/ti_sci.h
>> +++ b/drivers/firmware/ti_sci.h
>> @@ -6,7 +6,7 @@
>> * The system works in a message response protocol
>> * See: http://processors.wiki.ti.com/index.php/TISCI for details
>
> ^^^^
>
> You should probably replace that one as well to be https while doing the
> rest of the changes, even though the wiki is being deprecated during
> this year.
Don't worry, I'll run another scan anyway to cover newly added URLs.
Do you require this additional change for applying this patch?
>
> -Tero
>
>> *
>> - * Copyright (C) 2015-2016 Texas Instruments Incorporated -
>> http://www.ti.com/
>> + * Copyright (C) 2015-2016 Texas Instruments Incorporated -
>> https://www.ti.com/
>> */
>> #ifndef __TI_SCI_H
>> diff --git a/drivers/irqchip/irq-ti-sci-inta.c
>> b/drivers/irqchip/irq-ti-sci-inta.c
>> index 7e3ebf6ed2cd..85de19fe9b6e 100644
>> --- a/drivers/irqchip/irq-ti-sci-inta.c
>> +++ b/drivers/irqchip/irq-ti-sci-inta.c
>> @@ -2,7 +2,7 @@
>> /*
>> * Texas Instruments' K3 Interrupt Aggregator irqchip driver
>> *
>> - * Copyright (C) 2018-2019 Texas Instruments Incorporated -
>> http://www.ti.com/
>> + * Copyright (C) 2018-2019 Texas Instruments Incorporated -
>> https://www.ti.com/
>> * Lokesh Vutla <lokeshvutla@ti.com>
>> */
>> diff --git a/drivers/irqchip/irq-ti-sci-intr.c
>> b/drivers/irqchip/irq-ti-sci-intr.c
>> index 59d51a20bbd8..5ea148faf2ab 100644
>> --- a/drivers/irqchip/irq-ti-sci-intr.c
>> +++ b/drivers/irqchip/irq-ti-sci-intr.c
>> @@ -2,7 +2,7 @@
>> /*
>> * Texas Instruments' K3 Interrupt Router irqchip driver
>> *
>> - * Copyright (C) 2018-2019 Texas Instruments Incorporated -
>> http://www.ti.com/
>> + * Copyright (C) 2018-2019 Texas Instruments Incorporated -
>> https://www.ti.com/
>> * Lokesh Vutla <lokeshvutla@ti.com>
>> */
>> diff --git a/drivers/reset/reset-ti-sci.c b/drivers/reset/reset-ti-sci.c
>> index bf68729ab729..b799aefad547 100644
>> --- a/drivers/reset/reset-ti-sci.c
>> +++ b/drivers/reset/reset-ti-sci.c
>> @@ -1,7 +1,7 @@
>> /*
>> * Texas Instrument's System Control Interface (TI-SCI) reset driver
>> *
>> - * Copyright (C) 2015-2017 Texas Instruments Incorporated -
>> http://www.ti.com/
>> + * Copyright (C) 2015-2017 Texas Instruments Incorporated -
>> https://www.ti.com/
>> * Andrew F. Davis <afd@ti.com>
>> *
>> * This program is free software; you can redistribute it and/or modify
>> diff --git a/include/linux/soc/ti/ti_sci_inta_msi.h
>> b/include/linux/soc/ti/ti_sci_inta_msi.h
>> index 11fb5048f5f6..e3aa8b14612e 100644
>> --- a/include/linux/soc/ti/ti_sci_inta_msi.h
>> +++ b/include/linux/soc/ti/ti_sci_inta_msi.h
>> @@ -2,7 +2,7 @@
>> /*
>> * Texas Instruments' K3 TI SCI INTA MSI helper
>> *
>> - * Copyright (C) 2018-2019 Texas Instruments Incorporated -
>> http://www.ti.com/
>> + * Copyright (C) 2018-2019 Texas Instruments Incorporated -
>> https://www.ti.com/
>> * Lokesh Vutla <lokeshvutla@ti.com>
>> */
>> diff --git a/include/linux/soc/ti/ti_sci_protocol.h
>> b/include/linux/soc/ti/ti_sci_protocol.h
>> index 9531ec823298..0fc452dd96d4 100644
>> --- a/include/linux/soc/ti/ti_sci_protocol.h
>> +++ b/include/linux/soc/ti/ti_sci_protocol.h
>> @@ -2,7 +2,7 @@
>> /*
>> * Texas Instruments System Control Interface Protocol
>> *
>> - * Copyright (C) 2015-2016 Texas Instruments Incorporated -
>> http://www.ti.com/
>> + * Copyright (C) 2015-2016 Texas Instruments Incorporated -
>> https://www.ti.com/
>> * Nishanth Menon
>> */
>>
>
> --
> Texas Instruments Finland Oy, Porkkalankatu 22, 00180 Helsinki.
> Y-tunnus/Business ID: 0615521-4. Kotipaikka/Domicile: Helsinki
next prev parent reply other threads:[~2020-07-20 21:27 UTC|newest]
Thread overview: 4+ messages / expand[flat|nested] mbox.gz Atom feed top
2020-07-18 10:55 [PATCH] firmware: ti_sci: Replace HTTP links with HTTPS ones Alexander A. Klimov
2020-07-20 7:32 ` Tero Kristo
2020-07-20 21:27 ` Alexander A. Klimov [this message]
2020-07-21 16:06 ` Rob Herring
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03ad792e-a345-ee3d-02e5-19e489e25787@al2klimov.de \
--to=grandmaster@al2klimov.de \
--cc=devicetree@vger.kernel.org \
--cc=jason@lakedaemon.net \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=maz@kernel.org \
--cc=nm@ti.com \
--cc=p.zabel@pengutronix.de \
--cc=robh+dt@kernel.org \
--cc=ssantosh@kernel.org \
--cc=t-kristo@ti.com \
--cc=tglx@linutronix.de \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).