From: Maximilian Luz <luzmaximilian@gmail.com>
To: "Konrad Dybcio" <konradybcio@kernel.org>,
"Rob Herring" <robh@kernel.org>,
"Greg Kroah-Hartman" <gregkh@linuxfoundation.org>,
"Jiri Slaby" <jirislaby@kernel.org>,
"Krzysztof Kozlowski" <krzk+dt@kernel.org>,
"Conor Dooley" <conor+dt@kernel.org>,
"Rafael J. Wysocki" <rafael@kernel.org>,
"Len Brown" <lenb@kernel.org>,
"Hans de Goede" <hdegoede@redhat.com>,
"Ilpo Järvinen" <ilpo.jarvinen@linux.intel.com>
Cc: Marijn Suijten <marijn.suijten@somainline.org>,
linux-serial@vger.kernel.org, linux-kernel@vger.kernel.org,
devicetree@vger.kernel.org, linux-acpi@vger.kernel.org,
platform-driver-x86@vger.kernel.org,
Bjorn Andersson <andersson@kernel.org>,
Konrad Dybcio <quic_kdybcio@quicinc.com>
Subject: Re: [PATCH v3 3/3] platform/surface: Add OF support
Date: Fri, 16 Aug 2024 20:23:12 +0200 [thread overview]
Message-ID: <03af1025-f946-4eb2-a41e-28f0436e60e6@gmail.com> (raw)
In-Reply-To: <20240814-topic-sam-v3-3-a84588aad233@quicinc.com>
On 8/14/24 12:27 PM, Konrad Dybcio wrote:
> From: Konrad Dybcio <quic_kdybcio@quicinc.com>
>
> Add basic support for registering the aggregator module on Device Tree-
> based platforms. These include at least three generations of Qualcomm
> Snapdragon-based Surface devices:
>
> - SC8180X / SQ1 / SQ2: Pro X,
> - SC8280XP / SQ3: Devkit 2023, Pro 9
> - X Elite: Laptop 7 / Pro11
>
> Thankfully, the aggregators on these seem to be configured in an
> identical way, which allows for using these settings as defaults and
> no DT properties need to be introduced (until that changes, anyway).
>
> Based on the work done by Maximilian Luz, largely rewritten.
>
> Signed-off-by: Konrad Dybcio <quic_kdybcio@quicinc.com>
> ---
Looks good to me and works without issues on my Surface Pro X.
Thanks again for picking this up!
Reviewed-by: Maximilian Luz <luzmaximilian@gmail.com>
Tested-by: Maximilian Luz <luzmaximilian@gmail.com>
next prev parent reply other threads:[~2024-08-16 18:23 UTC|newest]
Thread overview: 19+ messages / expand[flat|nested] mbox.gz Atom feed top
2024-08-14 10:27 [PATCH v3 0/3] OF support for Surface System Aggregator Module Konrad Dybcio
2024-08-14 10:27 ` [PATCH v3 1/3] dt-bindings: serial: Allow embedded-controller as child node Konrad Dybcio
2024-08-14 10:27 ` [PATCH v3 2/3] dt-bindings: platform: Add Surface System Aggregator Module Konrad Dybcio
2024-08-14 14:06 ` Krzysztof Kozlowski
2024-08-14 10:27 ` [PATCH v3 3/3] platform/surface: Add OF support Konrad Dybcio
2024-08-16 18:23 ` Maximilian Luz [this message]
2024-08-26 20:54 ` Andy Shevchenko
2024-08-27 9:07 ` Hans de Goede
2024-08-27 13:52 ` Konrad Dybcio
2024-08-27 14:04 ` Hans de Goede
2024-08-28 9:10 ` Maximilian Luz
2024-08-28 16:56 ` Andy Shevchenko
2024-08-28 17:40 ` Maximilian Luz
2024-08-28 19:06 ` Andy Shevchenko
2024-08-30 12:57 ` Konrad Dybcio
2024-08-19 11:57 ` [PATCH v3 0/3] OF support for Surface System Aggregator Module Hans de Goede
2024-08-19 13:27 ` Konrad Dybcio
2024-08-19 20:07 ` Maximilian Luz
2024-08-26 20:55 ` Andy Shevchenko
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03af1025-f946-4eb2-a41e-28f0436e60e6@gmail.com \
--to=luzmaximilian@gmail.com \
--cc=andersson@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=gregkh@linuxfoundation.org \
--cc=hdegoede@redhat.com \
--cc=ilpo.jarvinen@linux.intel.com \
--cc=jirislaby@kernel.org \
--cc=konradybcio@kernel.org \
--cc=krzk+dt@kernel.org \
--cc=lenb@kernel.org \
--cc=linux-acpi@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-serial@vger.kernel.org \
--cc=marijn.suijten@somainline.org \
--cc=platform-driver-x86@vger.kernel.org \
--cc=quic_kdybcio@quicinc.com \
--cc=rafael@kernel.org \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).