From: Lars-Peter Clausen <lars@metafoo.de>
To: Anand Ashok Dumbre <anand.ashok.dumbre@xilinx.com>,
linux-kernel@vger.kernel.org, jic23@kernel.org,
linux-iio@vger.kernel.org, git@xilinx.com,
michal.simek@xilinx.com, pmeerw@pmeerw.net,
devicetree@vger.kernel.org
Cc: Manish Narani <manish.narani@xilinx.com>
Subject: Re: [PATCH v7 2/4] iio: adc: Add Xilinx AMS driver
Date: Tue, 26 Oct 2021 09:09:44 +0200 [thread overview]
Message-ID: <03afaedd-8ea5-0379-ac98-db61ac679259@metafoo.de> (raw)
In-Reply-To: <20211019152048.28983-3-anand.ashok.dumbre@xilinx.com>
On 10/19/21 5:20 PM, Anand Ashok Dumbre wrote:
> [...]
> +#define AMS_CHAN_TEMP(_scan_index, _addr) { \
> + .type = IIO_TEMP, \
> + .indexed = 1, \
> + .address = (_addr), \
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
> + BIT(IIO_CHAN_INFO_SCALE) | \
> + BIT(IIO_CHAN_INFO_OFFSET), \
> + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), \
There is no handling of IIO_CHAN_INFO_SAMP_FREQ in read_raw(). Reading
the sampling_frequency attribute always returns -EINVAL.
> + .event_spec = ams_temp_events, \
> + .scan_index = _scan_index, \
> + .num_event_specs = ARRAY_SIZE(ams_temp_events), \
> +}
> +
> +#define AMS_CHAN_VOLTAGE(_scan_index, _addr, _alarm) { \
> + .type = IIO_VOLTAGE, \
> + .indexed = 1, \
> + .address = (_addr), \
> + .info_mask_separate = BIT(IIO_CHAN_INFO_RAW) | \
> + BIT(IIO_CHAN_INFO_SCALE), \
> + .info_mask_shared_by_all = BIT(IIO_CHAN_INFO_SAMP_FREQ), \
> + .event_spec = (_alarm) ? ams_voltage_events : NULL, \
> + .scan_index = _scan_index, \
> + .num_event_specs = (_alarm) ? ARRAY_SIZE(ams_voltage_events) : 0, \
> +}
next prev parent reply other threads:[~2021-10-26 7:09 UTC|newest]
Thread overview: 18+ messages / expand[flat|nested] mbox.gz Atom feed top
2021-10-19 15:20 [PATCH v7 0/4] Add Xilinx AMS Driver Anand Ashok Dumbre
2021-10-19 15:20 ` [PATCH v7 1/4] arm64: zynqmp: DT: Add Xilinx AMS node Anand Ashok Dumbre
2021-10-19 15:20 ` [PATCH v7 2/4] iio: adc: Add Xilinx AMS driver Anand Ashok Dumbre
2021-10-21 11:06 ` Jonathan Cameron
2021-10-26 10:18 ` Anand Ashok Dumbre
2021-10-23 12:36 ` Lars-Peter Clausen
2021-10-27 20:35 ` Anand Ashok Dumbre
2021-10-24 14:27 ` kernel test robot
2021-10-25 10:10 ` Andy Shevchenko
2021-11-02 21:31 ` Anand Ashok Dumbre
2021-11-03 17:19 ` Jonathan Cameron
2021-10-25 13:08 ` Lars-Peter Clausen
2021-10-27 9:35 ` Anand Ashok Dumbre
2021-10-26 7:09 ` Lars-Peter Clausen [this message]
2021-10-27 9:04 ` Anand Ashok Dumbre
2021-10-19 15:20 ` [PATCH v7 3/4] dt-bindings: iio: adc: Add Xilinx AMS binding documentation Anand Ashok Dumbre
2021-10-27 17:00 ` Rob Herring
2021-10-19 15:20 ` [PATCH v7 4/4] MAINTAINERS: Add maintainer for xilinx-ams Anand Ashok Dumbre
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03afaedd-8ea5-0379-ac98-db61ac679259@metafoo.de \
--to=lars@metafoo.de \
--cc=anand.ashok.dumbre@xilinx.com \
--cc=devicetree@vger.kernel.org \
--cc=git@xilinx.com \
--cc=jic23@kernel.org \
--cc=linux-iio@vger.kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=manish.narani@xilinx.com \
--cc=michal.simek@xilinx.com \
--cc=pmeerw@pmeerw.net \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).