From: Krzysztof Kozlowski <krzk@kernel.org>
To: Wilson Ding <dingwei@marvell.com>,
"linux-kernel@vger.kernel.org" <linux-kernel@vger.kernel.org>,
"devicetree@vger.kernel.org" <devicetree@vger.kernel.org>,
"linux-arm-kernel@lists.infradead.org"
<linux-arm-kernel@lists.infradead.org>,
"robh@kernel.org" <robh@kernel.org>
Cc: "andrew@lunn.ch" <andrew@lunn.ch>,
"gregory.clement@bootlin.com" <gregory.clement@bootlin.com>,
"sebastian.hesselbarth@gmail.com"
<sebastian.hesselbarth@gmail.com>,
"krzk+dt@kernel.org" <krzk+dt@kernel.org>,
"conor+dt@kernel.org" <conor+dt@kernel.org>,
"p.zabel@pengutronix.de" <p.zabel@pengutronix.de>,
Sanghoon Lee <salee@marvell.com>,
Geethasowjanya Akula <gakula@marvell.com>
Subject: Re: [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller node
Date: Thu, 6 Mar 2025 08:29:06 +0100 [thread overview]
Message-ID: <03b14353-5d47-48de-99fd-9cc48bad5651@kernel.org> (raw)
In-Reply-To: <BY3PR18MB4673B4CEB60D3D21AB17B01DA7C82@BY3PR18MB4673.namprd18.prod.outlook.com>
On 04/03/2025 20:08, Wilson Ding wrote:
>
> I did consider shrinking the syscon's register address range to
> make the reset-controller node to be independent from the
> syscon node. However, I found the syscon node is also referred
> by some devices for miscellaneous configurations . The reset
> configuration register happens to be located in between these
> registers and clock/GPIO registers.
>
>> drop offset in your patch or unify everything into 'reg'.
>>
>
> This is exactly what I proposed in v3 patch. Do I misunderstand
> you?
>
> CP11X_LABEL(swrst): reset-controller@268 {
> compatible = "marvell,armada8k-reset";
> reg = <0x268 0x4>;
> #reset-cells = <1>;
> };
I don't see the other device being fixed here. How did you unify them?
Best regards,
Krzysztof
next prev parent reply other threads:[~2025-03-06 7:29 UTC|newest]
Thread overview: 22+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-02-27 19:25 [PATCH v3 0/3] Add Armada8K reset controller support Wilson Ding
2025-02-27 19:25 ` [PATCH v3 1/3] dt-bindings: reset: Add Armada8K reset controller Wilson Ding
2025-02-27 20:24 ` Rob Herring (Arm)
2025-02-27 21:58 ` [EXTERNAL] " Wilson Ding
2025-02-28 6:52 ` Krzysztof Kozlowski
2025-03-07 0:03 ` Wilson Ding
2025-03-07 8:56 ` Krzysztof Kozlowski
2025-03-07 23:15 ` Wilson Ding
2025-02-28 6:55 ` Krzysztof Kozlowski
2025-02-27 19:25 ` [PATCH v3 2/3] reset: Add support for " Wilson Ding
2025-02-27 19:25 ` [PATCH v3 3/3] arm64: dts: marvell: cp11x: Add reset controller node Wilson Ding
2025-02-28 6:56 ` Krzysztof Kozlowski
2025-02-28 20:18 ` [EXTERNAL] " Wilson Ding
2025-03-01 13:46 ` Krzysztof Kozlowski
2025-03-01 13:49 ` Krzysztof Kozlowski
2025-03-04 2:17 ` Wilson Ding
2025-03-04 7:13 ` Krzysztof Kozlowski
2025-03-04 19:08 ` Wilson Ding
2025-03-06 7:29 ` Krzysztof Kozlowski [this message]
2025-03-06 17:42 ` [EXTERNAL] " Wilson Ding
2025-03-07 8:59 ` Krzysztof Kozlowski
2025-03-07 21:52 ` Wilson Ding
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03b14353-5d47-48de-99fd-9cc48bad5651@kernel.org \
--to=krzk@kernel.org \
--cc=andrew@lunn.ch \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=dingwei@marvell.com \
--cc=gakula@marvell.com \
--cc=gregory.clement@bootlin.com \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=p.zabel@pengutronix.de \
--cc=robh@kernel.org \
--cc=salee@marvell.com \
--cc=sebastian.hesselbarth@gmail.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).