From: Dinh Nguyen <dinguyen@kernel.org>
To: Krzysztof Kozlowski <krzk@kernel.org>,
niravkumarlaxmidas.rabara@altera.com,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Subject: Re: [PATCH 1/2] dt-bindings: intel: Add Agilex3 SoCFPGA board
Date: Mon, 10 Nov 2025 06:36:03 -0600 [thread overview]
Message-ID: <03d6086f-0a84-4cca-b668-5b8902cd866f@kernel.org> (raw)
In-Reply-To: <1c879d71-a4a5-4241-a0db-bfd2c61bf32c@kernel.org>
On 11/10/25 01:53, Krzysztof Kozlowski wrote:
> On 10/11/2025 07:47, niravkumarlaxmidas.rabara@altera.com wrote:
>> From: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
>>
>> Add compatible for Agilex3 SoCFPGA board.
>>
>> Signed-off-by: Niravkumar L Rabara <niravkumarlaxmidas.rabara@altera.com>
>> ---
>> Documentation/devicetree/bindings/arm/intel,socfpga.yaml | 5 +++++
>> 1 file changed, 5 insertions(+)
>>
>> diff --git a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> index cf7a91dfec8a..e706c4eff019 100644
>> --- a/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> +++ b/Documentation/devicetree/bindings/arm/intel,socfpga.yaml
>> @@ -21,6 +21,11 @@ properties:
>> - intel,socfpga-agilex-n6000
>> - intel,socfpga-agilex-socdk
>> - const: intel,socfpga-agilex
>> + - description: Agilex3 boards
>
> Agilex3?
>
From what I understand, the Agilex3 is the same chip as the Agilex5,
minus 2 CPU cores. So I recommended to Nirav, just to add the binding in
the Agilex5 context.
>> + items:
>> + - enum:
>> + - intel,socfpga-agilex3-socdk
>> + - const: intel,socfpga-agilex5
>
> Or Agilex5? Decide. Cannot be both.
>
From the explanation above, could we document the agilex3 socdk this way?
Thanks,
Dinh
next prev parent reply other threads:[~2025-11-10 12:36 UTC|newest]
Thread overview: 8+ messages / expand[flat|nested] mbox.gz Atom feed top
2025-11-10 6:47 [PATCH 0/2] Add support for Agilex3 SoCFPGA board niravkumarlaxmidas.rabara
2025-11-10 6:47 ` [PATCH 1/2] dt-bindings: intel: Add " niravkumarlaxmidas.rabara
2025-11-10 7:53 ` Krzysztof Kozlowski
2025-11-10 12:36 ` Dinh Nguyen [this message]
2025-11-10 12:38 ` Krzysztof Kozlowski
2025-11-10 6:47 ` [PATCH 2/2] arm64: dts: socfpga: add Agilex3 board niravkumarlaxmidas.rabara
2025-11-10 12:37 ` Dinh Nguyen
2025-11-11 2:22 ` Niravkumar L Rabara
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=03d6086f-0a84-4cca-b668-5b8902cd866f@kernel.org \
--to=dinguyen@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=krzk@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=niravkumarlaxmidas.rabara@altera.com \
--cc=robh@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).