From mboxrd@z Thu Jan 1 00:00:00 1970 Received: from mail-ej1-f53.google.com (mail-ej1-f53.google.com [209.85.218.53]) (using TLSv1.2 with cipher ECDHE-RSA-AES128-GCM-SHA256 (128/128 bits)) (No client certificate requested) by smtp.subspace.kernel.org (Postfix) with ESMTPS id 7104D252908 for ; Mon, 10 Feb 2025 15:01:16 +0000 (UTC) Authentication-Results: smtp.subspace.kernel.org; arc=none smtp.client-ip=209.85.218.53 ARC-Seal:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739199679; cv=none; b=N0Ft2LjMA1VZgRiwViem4/y01/noQaEYTXS16lS9DjeFhWwiTm+yEbhZQkE7LgDL5dY5fbJRUL+WUoTfHKojIvSI85ni3yfwIY+ddVzWNSaCanRLH5YvjbUC8wCCTMcnJTj0rEjthAKeyPgAHMrxLqUGyzk9j5fM9pdtKjMiwBw= ARC-Message-Signature:i=1; a=rsa-sha256; d=subspace.kernel.org; s=arc-20240116; t=1739199679; c=relaxed/simple; bh=visb9O0lxlMa5DUWC3Bk2Q1mSoeQvsC0v7T9kKbj3yw=; h=Message-ID:Subject:From:To:Cc:Date:In-Reply-To:References: Content-Type:MIME-Version; b=CRq8ZihevhEAtNtkSYbjUmeyRu3HXHTdBcMbOXpf0pgKYDYvKM8TtTknSQ6laYiDWq3r2tEkStdF7OkZaSu9NBjbC6kDs51Z+J8jF5UySzLV3Q4q7eswmJdODg3nrcz9Ma5XJ1bQA0u1b5UL53gosrEQqP0H7HAJ3kPxO2wE0xU= ARC-Authentication-Results:i=1; smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com; spf=pass smtp.mailfrom=gmail.com; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b=X8WmxZ7u; arc=none smtp.client-ip=209.85.218.53 Authentication-Results: smtp.subspace.kernel.org; dmarc=pass (p=none dis=none) header.from=gmail.com Authentication-Results: smtp.subspace.kernel.org; spf=pass smtp.mailfrom=gmail.com Authentication-Results: smtp.subspace.kernel.org; dkim=pass (2048-bit key) header.d=gmail.com header.i=@gmail.com header.b="X8WmxZ7u" Received: by mail-ej1-f53.google.com with SMTP id a640c23a62f3a-ab7ca64da5dso135755266b.0 for ; Mon, 10 Feb 2025 07:01:16 -0800 (PST) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=gmail.com; s=20230601; t=1739199675; x=1739804475; darn=vger.kernel.org; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:from:to:cc:subject :date:message-id:reply-to; bh=3M5idA8N7HpwZKk/3+pcrUsB6D7VU4LeXOhWq3Jgugs=; b=X8WmxZ7uUbRTGVMVGMmy4V3O/SVnDz5K+05koocfBVa0ZsQ1MsmZAca+LoIrc0180p 8k4ZfZ1aj+TK/eVHdfzwu5rKP3OasLWqNdh8YQwDC4TkJLeYZFmkVsyhf17bt+f3AwH8 l85YS+06Z9e1z9Wx73D2IhgZc3zqa8J5tPdRUNW8bwob2fXFEoKdz0O7zhsVGSpfuam8 5x9bU2CYIOPho7mkjtdahn2zOQlrNOKhWUD6Q7Ix3dhLENVd51TPapNl9O1NHz8Kefbj 64s4A76M6gGiHAzGGcpmm6y016fUBluVqtFHzatDEPPLhDkk7AqpQVD2Ts2QiSGlhrH+ rtdA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20230601; t=1739199675; x=1739804475; h=mime-version:user-agent:content-transfer-encoding:references :in-reply-to:date:cc:to:from:subject:message-id:x-gm-message-state :from:to:cc:subject:date:message-id:reply-to; bh=3M5idA8N7HpwZKk/3+pcrUsB6D7VU4LeXOhWq3Jgugs=; b=IhOYhoccIQWK8yj8BCL6gXzmcT3XV8TlGM+aF5ujjOpqHQZlx4DO4TqqkMx1TxE1nE 5dOynHRYcdeh5Cei45SCHFlBJeWrI6Q4WKSK1cu/573aB7Pbjd4LJIIH08q1ZFMK7gV3 4SC929UrMRhHQNrLduT4fVuQDit6VX0oVGP/ZFWDc6/Xih16F6OTHveUKMOPSEACkDRr cH0nbr/RsAKmwMvg+eud/c7oc/uSk7vH+GjIeMkrqb1Oul2jZsixb1+ADyWVmo/8F8aZ 96uBJW1LPkBp46r7TKg94XtscD919UrZyP+xdt76vEXqTCBlaR2N25mCd6SPMImvFMEz P7AQ== X-Forwarded-Encrypted: i=1; AJvYcCX09tYDUDEOhGIyOoQLNgMd/QFKAIrCcV0IVHxWhP88RsXKc1XiEGkQvwUf2umKqy7aPlEAlAUpaKmz@vger.kernel.org X-Gm-Message-State: AOJu0YwaQzJPa1ZPGzfRdwaishJk0a4YUV1hFOP6jF0KzojTu8k2jmGn jXz099Om7bkFZngW/VjBZ859doZBdJZnLfnEH+IPIZi7cZ3TMcLCtMUIta0T X-Gm-Gg: ASbGncvDBdox/+C0la2CYG5+efpyFE8HJEAJNYLPyzkLLdEwMunwXWch0YgcBbl6U2y q2JNPFWr8/UMR+8CG6L80JYl89oAHFb51RsKvXcyBMazeodbVumh3Bxpred432Jfyxp3jvHcmcw tDvIm84gTy+6dBZWeaYsgf/lXqfGhfLFfzIIfjo/FBXNl6CzUfuMR1MDeLz5t/kSDKEtvmPlGy+ cOhuZ8cSIbtgDi1ZanYs4Di3ByT0TbJnp0l4n0T6gu1MNbsJrKBXoR6glewER9MaLv4C0syvYEO STYHVX/sd1tZPpZb4j2X2mkTrUEpDCVl X-Google-Smtp-Source: AGHT+IHDvJX3+ekZa4vY1LIl/WMEIul6AD+KtHvHZm/OrLAAq1fRlkjI0uEBHS/oueveFzGr668vsg== X-Received: by 2002:a17:906:6a29:b0:ab6:d4ce:5674 with SMTP id a640c23a62f3a-ab76e9dc14amr1858509166b.26.1739199672976; Mon, 10 Feb 2025 07:01:12 -0800 (PST) Received: from giga-mm.home ([2a02:1210:861b:6f00:82ee:73ff:feb8:99e3]) by smtp.gmail.com with ESMTPSA id a640c23a62f3a-ab7cd7ffaa8sm122042766b.132.2025.02.10.07.01.12 (version=TLS1_3 cipher=TLS_AES_256_GCM_SHA384 bits=256/256); Mon, 10 Feb 2025 07:01:12 -0800 (PST) Message-ID: <03ff407fe68e46df4844e5dd244e7c609331af71.camel@gmail.com> Subject: Re: [PATCH 03/10] arm64: dts: sophgo: Add initial SG2000 SoC device tree From: Alexander Sverdlin To: Krzysztof Kozlowski , soc@lists.linux.dev Cc: Chen Wang , Inochi Amaoto , linux-riscv@lists.infradead.org, devicetree@vger.kernel.org, Haylen Chu , linux-arm-kernel@lists.infradead.org, Arnd Bergmann , Rob Herring , Krzysztof Kozlowski , Conor Dooley Date: Mon, 10 Feb 2025 16:01:10 +0100 In-Reply-To: <0d5484d1-be83-4f38-befd-94d458b3aaa8@kernel.org> References: <20250209220646.1090868-1-alexander.sverdlin@gmail.com> <20250209220646.1090868-4-alexander.sverdlin@gmail.com> <0d5484d1-be83-4f38-befd-94d458b3aaa8@kernel.org> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: quoted-printable User-Agent: Evolution 3.54.2 Precedence: bulk X-Mailing-List: devicetree@vger.kernel.org List-Id: List-Subscribe: List-Unsubscribe: MIME-Version: 1.0 Hi Krzysztof! On Mon, 2025-02-10 at 09:45 +0100, Krzysztof Kozlowski wrote: > On 09/02/2025 23:06, Alexander Sverdlin wrote: > > Add initial device tree for the SG2000 SoC by SOPHGO (from ARM64 PoV). > >=20 > > Signed-off-by: Alexander Sverdlin > > --- > > =C2=A0 arch/arm64/boot/dts/sophgo/sg2000.dtsi | 79 ++++++++++++++++++++= ++++++ > > =C2=A0 1 file changed, 79 insertions(+) > > =C2=A0 create mode 100644 arch/arm64/boot/dts/sophgo/sg2000.dtsi > >=20 > > diff --git a/arch/arm64/boot/dts/sophgo/sg2000.dtsi b/arch/arm64/boot/d= ts/sophgo/sg2000.dtsi > > new file mode 100644 > > index 000000000000..4e520486cbe5 > > --- /dev/null > > +++ b/arch/arm64/boot/dts/sophgo/sg2000.dtsi > > @@ -0,0 +1,79 @@ > > +// SPDX-License-Identifier: (GPL-2.0 OR MIT) > > + > > +#define SOC_PERIPHERAL_IRQ(nr) GIC_SPI (nr) > > + > > +#include > > +#include > > +#include > > + > > +/ { [...] > > + gic: interrupt-controller@1f01000 { >=20 > MMIO nodes are always in the soc. I think I've looked a wrong example (or a counter-example)... $ grep -R -P '^\t\tcompatible =3D "arm,cortex-a15-gic";' * arm/boot/dts/intel/axm/axm55xx.dtsi: compatible =3D "arm,cortex-a15-gic"; arm/boot/dts/ti/omap/dra7.dtsi: compatible =3D "arm,cortex-a15-gic"; arm/boot/dts/ti/omap/omap5.dtsi: compatible =3D "arm,cortex-a15-gic"; arm/boot/dts/nvidia/tegra124.dtsi: compatible =3D "arm,cortex-a15-gic"; arm/boot/dts/nvidia/tegra114.dtsi: compatible =3D "arm,cortex-a15-gic"; arm64/boot/dts/nvidia/tegra132.dtsi: compatible =3D "arm,cortex-a15-gic"; arm64/boot/dts/freescale/s32v234.dtsi: compatible =3D "arm,cortex-a15-gic"= ; arm64/boot/dts/apm/apm-storm.dtsi: compatible =3D "arm,cortex-a15-gic"; arm64/boot/dts/apm/apm-shadowcat.dtsi: compatible =3D "arm,cortex-a15-gic"= ; But thanks for clarification! > > + compatible =3D "arm,cortex-a15-gic"; > > + interrupt-controller; > > + #interrupt-cells =3D <3>; > > + reg =3D <0x01f01000 0x1000>, > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <0x01f02000 0x2000>; > > + }; > > + > > + soc { >=20 > Override by phandle/label instead of duplicating. >=20 > > + ranges; > > + > > + pinctrl: pinctrl@3001000 { > > + compatible =3D "sophgo,sg2000-pinctrl"; > > + reg =3D <0x03001000 0x1000>, > > + =C2=A0=C2=A0=C2=A0=C2=A0=C2=A0 <0x05027000 0x1000>; > > + reg-names =3D "sys", "rtc"; > > + }; > > + }; > > +}; > > + > > + > > +&clk { > > + compatible =3D "sophgo,sg2000-clk"; >=20 >=20 > That's discouraged practice. If you need to define compatible, it means > the block is not shared between designs and must not be in common DTSI. That doesn't come from my series, that's how original cv18xx.dtsi has been designed. Same question as before: do I need to rework it if I will not be = able to test the changes (I don't even posess the relevant HW). But if not, I have to adapt the same pattern into the new sg2000.dtsi. --=20 Alexander Sverdlin.