From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-11.4 required=3.0 tests=BAYES_00,DKIM_SIGNED, DKIM_VALID,DKIM_VALID_AU,HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_PATCH, MAILING_LIST_MULTI,NICE_REPLY_A,SIGNED_OFF_BY,SPF_HELO_NONE,SPF_PASS, URIBL_BLOCKED,USER_AGENT_SANE_1 autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 82FB5C35257 for ; Mon, 21 Sep 2020 21:20:29 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4AEF223A60 for ; Mon, 21 Sep 2020 21:20:29 +0000 (UTC) Authentication-Results: mail.kernel.org; dkim=pass (2048-bit key) header.d=linaro.org header.i=@linaro.org header.b="xCdO1gRc" Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S1728271AbgIUVU0 (ORCPT ); Mon, 21 Sep 2020 17:20:26 -0400 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:48484 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S1726577AbgIUVU0 (ORCPT ); Mon, 21 Sep 2020 17:20:26 -0400 Received: from mail-wr1-x442.google.com (mail-wr1-x442.google.com [IPv6:2a00:1450:4864:20::442]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id B3640C0613CF for ; Mon, 21 Sep 2020 14:20:25 -0700 (PDT) Received: by mail-wr1-x442.google.com with SMTP id t10so14430898wrv.1 for ; Mon, 21 Sep 2020 14:20:25 -0700 (PDT) DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=linaro.org; s=google; h=subject:to:cc:references:from:message-id:date:user-agent :mime-version:in-reply-to:content-language:content-transfer-encoding; bh=kIlLYItMEH57/OIqphwHXbMgNacdFFxpGWnfPMYalYM=; b=xCdO1gRcr6I9/MbCD0uw5F/eP5g5juh4KmwgJ74QrZi7bp9XafkV52CkCDZyuPvywJ klFDm00snWt05m5t0d6GVartPTQnXWWgSeVqT0GLO42aNW4NaSU2qlr4iAIO8nAcwav9 Kd6FnvQtYG/wDbGoxOEL/k7OvVlLsAtPNpMyXxgLufJmto4gi9VtkwXbCVCd8mZ+iOBW y+iDOd8TImm7iFI9b9o2WEkK+x81XTI8f9sa3lpdPV/0oAyLeGhy2JAYNKG4j5YwJ6PJ CVho83FUl9DcMa0mWLy5Adn9Dkzorkkyh9P65qDGGkEAb4F5AT5yL74NYtt6LT5v5UGB 9ajA== X-Google-DKIM-Signature: v=1; a=rsa-sha256; c=relaxed/relaxed; d=1e100.net; s=20161025; h=x-gm-message-state:subject:to:cc:references:from:message-id:date :user-agent:mime-version:in-reply-to:content-language :content-transfer-encoding; bh=kIlLYItMEH57/OIqphwHXbMgNacdFFxpGWnfPMYalYM=; b=IfvJkq81t2E/R2041adzT+Kt7gZpSvm7gfUqYokddlo91VUQtgIUROcGJM+PdgsiVl 8EI+vLjvm6k9tlFTGj43rA5m0ZmFRDubLCvyQB3XloKlaK17gnyjtl9DAtUPHuU/qYqa RM7CrUq/K25InP8Hx+ZvfwKkZuJ8BAxpFfr2xmyRP9PPd6Yeuq7oYuk7VjGo1cde9ZNJ uUyuu6QOlI+eBIkxjMANk7o3iXiizlynUIGp/FB/OmTZf4pob1HeHWkRqdmvcjijhG/p FHTmKPW86qE7G7t7Kg5/t4eXapRAMhQ5tsJ4lTVW2C0tlBR6VBRgrwVIJQPlOBp+ZRxQ 4k5Q== X-Gm-Message-State: AOAM533+rBz8WWVqExtJyHt13J0lvVFyUHvXO7qDmF0gKYrO3LDJKmi8 uW1EeoU18FNWSv+4y5JakjwIGA== X-Google-Smtp-Source: ABdhPJyF0BsM1hu0mJu+3NmgGTwLh8BB1+qR4UB77Xt7FosUKuVI2AExucUuS/VzfoNIEgGOPKDDPw== X-Received: by 2002:a5d:4d48:: with SMTP id a8mr1722763wru.318.1600723224330; Mon, 21 Sep 2020 14:20:24 -0700 (PDT) Received: from [192.168.86.34] (cpc86377-aztw32-2-0-cust226.18-1.cable.virginm.net. [92.233.226.227]) by smtp.googlemail.com with ESMTPSA id i83sm1202081wma.22.2020.09.21.14.20.22 (version=TLS1_2 cipher=ECDHE-ECDSA-AES128-GCM-SHA256 bits=128/128); Mon, 21 Sep 2020 14:20:23 -0700 (PDT) Subject: Re: [PATCH v6 3/5] Asoc:qcom:lpass-cpu:Update dts property read API To: Srinivasa Rao Mandadapu , agross@kernel.org, bjorn.andersson@linaro.org, lgirdwood@gmail.com, broonie@kernel.org, robh+dt@kernel.org, plai@codeaurora.org, bgoswami@codeaurora.org, perex@perex.cz, tiwai@suse.com, rohitkr@codeaurora.org, linux-arm-msm@vger.kernel.org, alsa-devel@alsa-project.org, devicetree@vger.kernel.org, linux-kernel@vger.kernel.org Cc: V Sujith Kumar Reddy References: <1600409084-29093-1-git-send-email-srivasam@codeaurora.org> <1600409084-29093-4-git-send-email-srivasam@codeaurora.org> From: Srinivas Kandagatla Message-ID: <040290a8-26a3-ab9c-04dc-beb23ee827e8@linaro.org> Date: Mon, 21 Sep 2020 22:20:22 +0100 User-Agent: Mozilla/5.0 (X11; Linux x86_64; rv:60.0) Gecko/20100101 Thunderbird/60.8.0 MIME-Version: 1.0 In-Reply-To: <1600409084-29093-4-git-send-email-srivasam@codeaurora.org> Content-Type: text/plain; charset=utf-8; format=flowed Content-Language: en-US Content-Transfer-Encoding: 7bit Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On 18/09/2020 07:04, Srinivasa Rao Mandadapu wrote: > From: V Sujith Kumar Reddy > > Signed-off-by: Srinivasa Rao > Signed-off-by: V Sujith Kumar Reddy > --- > sound/soc/qcom/lpass-cpu.c | 2 +- > sound/soc/qcom/lpass-platform.c | 2 +- > 2 files changed, 2 insertions(+), 2 deletions(-) > > diff --git a/sound/soc/qcom/lpass-cpu.c b/sound/soc/qcom/lpass-cpu.c > index 1ee6d8b..5d84f63 100644 > --- a/sound/soc/qcom/lpass-cpu.c > +++ b/sound/soc/qcom/lpass-cpu.c > @@ -575,7 +575,7 @@ int asoc_qcom_lpass_cpu_platform_probe(struct platform_device *pdev) > > of_lpass_cpu_parse_dai_data(dev, drvdata); > > - res = platform_get_resource(pdev, IORESOURCE_MEM, 0); > + res = platform_get_resource_byname(pdev, IORESOURCE_MEM, "lpass-lpaif"); Interesting!! this patch https://lore.kernel.org/alsa-devel/1597402388-14112-11-git-send-email-rohitkr@codeaurora.org/ just took it out and you add it back in! Index is always preferred over name w.r.t device tree bindings, so lets stick with that for now! Unless you have any strong reason to lookup resource by name? --srini > > drvdata->lpaif = devm_ioremap_resource(dev, res); > if (IS_ERR((void const __force *)drvdata->lpaif)) { > diff --git a/sound/soc/qcom/lpass-platform.c b/sound/soc/qcom/lpass-platform.c > index df692ed..35aead1 100644 > --- a/sound/soc/qcom/lpass-platform.c > +++ b/sound/soc/qcom/lpass-platform.c > @@ -638,7 +638,7 @@ int asoc_qcom_lpass_platform_register(struct platform_device *pdev) > struct lpass_variant *v = drvdata->variant; > int ret; > > - drvdata->lpaif_irq = platform_get_irq(pdev, 0); > + drvdata->lpaif_irq = platform_get_irq_byname(pdev, "lpass-irq-lpaif"); > if (drvdata->lpaif_irq < 0) > return -ENODEV; > >