From: Krzysztof Kozlowski <krzysztof.kozlowski@linaro.org>
To: Yanhong Wang <yanhong.wang@starfivetech.com>,
linux-riscv@lists.infradead.org, netdev@vger.kernel.org,
devicetree@vger.kernel.org, linux-kernel@vger.kernel.org
Cc: "David S . Miller" <davem@davemloft.net>,
Eric Dumazet <edumazet@google.com>,
Jakub Kicinski <kuba@kernel.org>, Paolo Abeni <pabeni@redhat.com>,
Rob Herring <robh+dt@kernel.org>,
Krzysztof Kozlowski <krzysztof.kozlowski+dt@linaro.org>,
Emil Renner Berthing <kernel@esmil.dk>,
Richard Cochran <richardcochran@gmail.com>,
Andrew Lunn <andrew@lunn.ch>,
Heiner Kallweit <hkallweit1@gmail.com>,
Peter Geis <pgwipeout@gmail.com>
Subject: Re: [PATCH v2 2/9] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names
Date: Fri, 16 Dec 2022 12:03:08 +0100 [thread overview]
Message-ID: <040b56b1-c65c-34c3-e4a1-5cae4428d1d2@linaro.org> (raw)
In-Reply-To: <20221216070632.11444-3-yanhong.wang@starfivetech.com>
On 16/12/2022 08:06, Yanhong Wang wrote:
> Some boards(such as StarFive VisionFive v2) require more than one value
> which defined by resets property, so the original definition can not
> meet the requirements. In order to adapt to different requirements,
> adjust the maxitems number from 1 to 3..
>
> Signed-off-by: Yanhong Wang <yanhong.wang@starfivetech.com>
> ---
> .../devicetree/bindings/net/snps,dwmac.yaml | 15 +++++++++++----
> 1 file changed, 11 insertions(+), 4 deletions(-)
>
> diff --git a/Documentation/devicetree/bindings/net/snps,dwmac.yaml b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> index e26c3e76ebb7..7870228b4cd3 100644
> --- a/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> +++ b/Documentation/devicetree/bindings/net/snps,dwmac.yaml
> @@ -133,12 +133,19 @@ properties:
> - ptp_ref
>
> resets:
> - maxItems: 1
> - description:
> - MAC Reset signal.
> + minItems: 1
> + maxItems: 3
> + additionalItems: true
> + items:
> + - description: MAC Reset signal
>
> reset-names:
> - const: stmmaceth
> + minItems: 1
> + maxItems: 3
> + additionalItems: true
> + contains:
> + enum:
> + - stmmaceth
No, this is highly unspecific and you know affect all the schemas using
snps,dwmac.yaml. Both lists must be specific - for your device and for
others.
Best regards,
Krzysztof
next prev parent reply other threads:[~2022-12-16 11:03 UTC|newest]
Thread overview: 31+ messages / expand[flat|nested] mbox.gz Atom feed top
2022-12-16 7:06 [PATCH v2 0/9] Add Ethernet driver for StarFive JH7110 SoC Yanhong Wang
2022-12-16 7:06 ` [PATCH v2 1/9] dt-bindings: net: snps,dwmac: Add dwmac-5.20 version Yanhong Wang
2022-12-16 7:06 ` [PATCH v2 2/9] dt-bindings: net: snps,dwmac: Update the maxitems number of resets and reset-names Yanhong Wang
2022-12-16 11:03 ` Krzysztof Kozlowski [this message]
2022-12-20 6:48 ` yanhong wang
2022-12-20 9:21 ` Krzysztof Kozlowski
2022-12-27 7:48 ` yanhong wang
2022-12-27 8:18 ` Krzysztof Kozlowski
2022-12-16 7:06 ` [PATCH v2 3/9] net: stmmac: platform: Add snps,dwmac-5.20 IP compatible string Yanhong Wang
2022-12-16 7:06 ` [PATCH v2 4/9] dt-bindings: net: Add bindings for StarFive dwmac Yanhong Wang
2022-12-16 11:05 ` Krzysztof Kozlowski
2022-12-20 6:53 ` yanhong wang
2022-12-16 11:06 ` Krzysztof Kozlowski
2022-12-20 6:57 ` yanhong wang
2022-12-20 18:03 ` Rob Herring
2022-12-16 7:06 ` [PATCH v2 5/9] dt-bindings: net: motorcomm: add support for Motorcomm YT8531 Yanhong Wang
2022-12-16 11:15 ` Krzysztof Kozlowski
2022-12-27 9:38 ` yanhong wang
2022-12-27 9:52 ` Krzysztof Kozlowski
2022-12-28 3:23 ` yanhong wang
2022-12-28 9:11 ` Krzysztof Kozlowski
2022-12-28 9:24 ` yanhong wang
2022-12-16 7:06 ` [PATCH v2 6/9] net: phy: motorcomm: Add YT8531 phy support Yanhong Wang
2022-12-16 8:41 ` Arun.Ramadoss
2022-12-16 11:58 ` Heiner Kallweit
2022-12-21 1:16 ` yanhong wang
2022-12-20 14:20 ` Andrew Lunn
2022-12-16 7:06 ` [PATCH v2 7/9] net: stmmac: Add glue layer for StarFive JH71x0 SoCs Yanhong Wang
2022-12-16 11:19 ` Krzysztof Kozlowski
2022-12-16 7:06 ` [PATCH v2 8/9] riscv: dts: starfive: jh7110: Add ethernet device node Yanhong Wang
2022-12-16 7:06 ` [PATCH v2 9/9] riscv: dts: starfive: visionfive-v2: Add phy clock delay train configuration Yanhong Wang
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=040b56b1-c65c-34c3-e4a1-5cae4428d1d2@linaro.org \
--to=krzysztof.kozlowski@linaro.org \
--cc=andrew@lunn.ch \
--cc=davem@davemloft.net \
--cc=devicetree@vger.kernel.org \
--cc=edumazet@google.com \
--cc=hkallweit1@gmail.com \
--cc=kernel@esmil.dk \
--cc=krzysztof.kozlowski+dt@linaro.org \
--cc=kuba@kernel.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-riscv@lists.infradead.org \
--cc=netdev@vger.kernel.org \
--cc=pabeni@redhat.com \
--cc=pgwipeout@gmail.com \
--cc=richardcochran@gmail.com \
--cc=robh+dt@kernel.org \
--cc=yanhong.wang@starfivetech.com \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox;
as well as URLs for NNTP newsgroup(s).