From mboxrd@z Thu Jan 1 00:00:00 1970 Return-Path: X-Spam-Checker-Version: SpamAssassin 3.4.0 (2014-02-07) on aws-us-west-2-korg-lkml-1.web.codeaurora.org X-Spam-Level: X-Spam-Status: No, score=-8.8 required=3.0 tests=BAYES_00, HEADER_FROM_DIFFERENT_DOMAINS,INCLUDES_CR_TRAILER,MAILING_LIST_MULTI, SPF_HELO_NONE,SPF_PASS,URIBL_BLOCKED autolearn=unavailable autolearn_force=no version=3.4.0 Received: from mail.kernel.org (mail.kernel.org [198.145.29.99]) by smtp.lore.kernel.org (Postfix) with ESMTP id 84F76C433E0 for ; Thu, 4 Mar 2021 11:58:24 +0000 (UTC) Received: from vger.kernel.org (vger.kernel.org [23.128.96.18]) by mail.kernel.org (Postfix) with ESMTP id 4FF5764F2B for ; Thu, 4 Mar 2021 11:58:24 +0000 (UTC) Received: (majordomo@vger.kernel.org) by vger.kernel.org via listexpand id S239248AbhCDL5h convert rfc822-to-8bit (ORCPT ); Thu, 4 Mar 2021 06:57:37 -0500 Received: from lindbergh.monkeyblade.net ([23.128.96.19]:58066 "EHLO lindbergh.monkeyblade.net" rhost-flags-OK-OK-OK-OK) by vger.kernel.org with ESMTP id S239572AbhCDL5a (ORCPT ); Thu, 4 Mar 2021 06:57:30 -0500 Received: from metis.ext.pengutronix.de (metis.ext.pengutronix.de [IPv6:2001:67c:670:201:290:27ff:fe1d:cc33]) by lindbergh.monkeyblade.net (Postfix) with ESMTPS id 8D81AC061756 for ; Thu, 4 Mar 2021 03:56:50 -0800 (PST) Received: from lupine.hi.pengutronix.de ([2001:67c:670:100:3ad5:47ff:feaf:1a17] helo=lupine) by metis.ext.pengutronix.de with esmtps (TLS1.3:ECDHE_RSA_AES_256_GCM_SHA384:256) (Exim 4.92) (envelope-from ) id 1lHmaw-0002CJ-Ip; Thu, 04 Mar 2021 12:56:42 +0100 Received: from pza by lupine with local (Exim 4.92) (envelope-from ) id 1lHmav-0005GO-NI; Thu, 04 Mar 2021 12:56:41 +0100 Message-ID: <04122d95be5489a9a2b7de1e36d3744538cc3c30.camel@pengutronix.de> Subject: Re: [PATCH v4 01/13] phy: cadence: Sierra: Fix PHY power_on sequence From: Philipp Zabel To: Kishon Vijay Abraham I , Vinod Koul , Rob Herring , Swapnil Jakhade Cc: linux-kernel@vger.kernel.org, devicetree@vger.kernel.org, Lokesh Vutla , stable@vger.kernel.org Date: Thu, 04 Mar 2021 12:56:41 +0100 In-Reply-To: <20210304044122.15166-2-kishon@ti.com> References: <20210304044122.15166-1-kishon@ti.com> <20210304044122.15166-2-kishon@ti.com> Content-Type: text/plain; charset="UTF-8" Content-Transfer-Encoding: 8BIT User-Agent: Evolution 3.30.5-1.1 MIME-Version: 1.0 X-SA-Exim-Connect-IP: 2001:67c:670:100:3ad5:47ff:feaf:1a17 X-SA-Exim-Mail-From: p.zabel@pengutronix.de X-SA-Exim-Scanned: No (on metis.ext.pengutronix.de); SAEximRunCond expanded to false X-PTX-Original-Recipient: devicetree@vger.kernel.org Precedence: bulk List-ID: X-Mailing-List: devicetree@vger.kernel.org On Thu, 2021-03-04 at 10:11 +0530, Kishon Vijay Abraham I wrote: > Commit 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") > de-asserts PHY_RESET even before the configurations are loaded in > phy_init(). However PHY_RESET should be de-asserted only after > all the configurations has been initialized, instead of de-asserting > in probe. Fix it here. > > Fixes: 44d30d622821d ("phy: cadence: Add driver for Sierra PHY") > Signed-off-by: Kishon Vijay Abraham I > Cc: # v5.4+ Reviewed-by: Philipp Zabel regards Philipp