From mboxrd@z Thu Jan 1 00:00:00 1970 From: Kukjin Kim Subject: RE: [PATCH v3] ARM: dts: Add SPI CS on exynos5250-snow Date: Wed, 29 Jul 2015 09:57:29 +0900 Message-ID: <041501d0c999$8af92f30$a0eb8d90$@kernel.org> References: Mime-Version: 1.0 Content-Type: text/plain; charset=us-ascii Content-Transfer-Encoding: 7bit Return-path: In-reply-to: Content-language: ko Sender: linux-samsung-soc-owner@vger.kernel.org To: 'Michal Suchanek' , 'Rob Herring' , 'Pawel Moll' , 'Mark Rutland' , 'Ian Campbell' , 'Kumar Gala' , 'Russell King' , 'Kukjin Kim' , 'Krzysztof Kozlowski' , devicetree@vger.kernel.org, linux-arm-kernel@lists.infradead.org, linux-samsung-soc@vger.kernel.org, linux-kernel@vger.kernel.org List-Id: devicetree@vger.kernel.org Michal Suchanek wrote: > > Although there is only one choice of chipselect it is necessary to > specify it. The driver cannot claim the gpio otherwise. > > Signed-off-by: Michal Suchanek > Acked-by: Javier Martinez Canillas > Acked-by: Krzysztof Kozlowski > >>From here ---8<--------8<----------- > -- > - don't move unrelated line > - use symbolic GPIO_ACTIVE_HIGH to here ---8<--------8<----------- should be added under the following '---'. Please add some additional comments like above 'changes since previous version' under the following '---' not '--', because all comments will be logged before the '---' and I don't want to keep the changes basically. Anyway, applied with removing above comments. Thanks, Kukjin > --- > arch/arm/boot/dts/exynos5250-snow.dts | 1 + > 1 file changed, 1 insertion(+) > > diff --git a/arch/arm/boot/dts/exynos5250-snow.dts b/arch/arm/boot/dts/exynos5250-snow.dts > index b7f4122..2d6a976 100644 > --- a/arch/arm/boot/dts/exynos5250-snow.dts > +++ b/arch/arm/boot/dts/exynos5250-snow.dts > @@ -688,6 +688,7 @@ > status = "okay"; > samsung,spi-src-clk = <0>; > num-cs = <1>; > + cs-gpios = <&gpa2 5 GPIO_ACTIVE_HIGH>; > }; > > &usbdrd_dwc3 { > -- > 2.1.4