From: Krzysztof Kozlowski <krzk@kernel.org>
To: Tzu-Hao Wei <twei@axiado.com>
Cc: SriNavmani A <srinavmani@axiado.com>,
Prasad Bolisetty <pbolisetty@axiado.com>,
Vinod Koul <vkoul@kernel.org>,
Neil Armstrong <neil.armstrong@linaro.org>,
Rob Herring <robh@kernel.org>,
Krzysztof Kozlowski <krzk+dt@kernel.org>,
Conor Dooley <conor+dt@kernel.org>,
linux-phy@lists.infradead.org, devicetree@vger.kernel.org,
linux-arm-kernel@lists.infradead.org,
linux-kernel@vger.kernel.org, openbmc@lists.ozlabs.org
Subject: Re: [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY
Date: Mon, 12 Jan 2026 09:34:13 +0100 [thread overview]
Message-ID: <041acb02-13de-4efe-a7d0-630390fb2940@kernel.org> (raw)
In-Reply-To: <20260111-camouflaged-shiny-wrasse-796dbd@quoll>
On 11/01/2026 11:37, Krzysztof Kozlowski wrote:
> On Fri, Jan 09, 2026 at 05:43:29PM +0800, Tzu-Hao Wei wrote:
>> From: SriNavmani A <srinavmani@axiado.com>
>>
>> Axiado AX3000 SoC contains Arasan PHY which provides the interface to the
>> HS200 eMMC host controller.
>>
>> Signed-off-by: SriNavmani A <srinavmani@axiado.com>
>> Signed-off-by: Tzu-Hao Wei <twei@axiado.com>
>> ---
>
> You did not bother to test your code...
And this is not even v1, but v2 and you completely ignored that part.
So did you implement any previous feedback?
Best regards,
Krzysztof
next prev parent reply other threads:[~2026-01-12 8:34 UTC|newest]
Thread overview: 16+ messages / expand[flat|nested] mbox.gz Atom feed top
2026-01-09 9:43 [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Tzu-Hao Wei
2026-01-09 9:43 ` [PATCH 1/4] dt-bindings: phy: axiado,ax3000-emmc-phy: add Axiado eMMC PHY Tzu-Hao Wei
2026-01-11 10:37 ` Krzysztof Kozlowski
2026-01-12 8:34 ` Krzysztof Kozlowski [this message]
2026-01-12 10:27 ` Tzu-Hao Wei
2026-01-09 9:43 ` [PATCH 2/4] phy: axiado: add Axiado eMMC PHY driver Tzu-Hao Wei
2026-01-15 22:22 ` kernel test robot
2026-01-09 9:43 ` [PATCH 3/4] MAINTAINERS: Add Axiado AX3000 " Tzu-Hao Wei
2026-01-11 10:40 ` Krzysztof Kozlowski
2026-01-13 3:38 ` Tzu-Hao Wei
2026-01-12 6:02 ` Prasad Bolisetty
2026-01-09 9:43 ` [PATCH 4/4] arm64: dts: axiado: Add eMMC PHY node Tzu-Hao Wei
2026-01-12 8:32 ` [PATCH 0/4] Add eMMC PHY support for Axiado AX3000 SoC Krzysztof Kozlowski
2026-01-13 6:16 ` Tzu-Hao Wei
2026-01-12 15:17 ` Rob Herring
2026-02-04 9:19 ` Tzu-Hao Wei
Reply instructions:
You may reply publicly to this message via plain-text email
using any one of the following methods:
* Save the following mbox file, import it into your mail client,
and reply-to-all from there: mbox
Avoid top-posting and favor interleaved quoting:
https://en.wikipedia.org/wiki/Posting_style#Interleaved_style
* Reply using the --to, --cc, and --in-reply-to
switches of git-send-email(1):
git send-email \
--in-reply-to=041acb02-13de-4efe-a7d0-630390fb2940@kernel.org \
--to=krzk@kernel.org \
--cc=conor+dt@kernel.org \
--cc=devicetree@vger.kernel.org \
--cc=krzk+dt@kernel.org \
--cc=linux-arm-kernel@lists.infradead.org \
--cc=linux-kernel@vger.kernel.org \
--cc=linux-phy@lists.infradead.org \
--cc=neil.armstrong@linaro.org \
--cc=openbmc@lists.ozlabs.org \
--cc=pbolisetty@axiado.com \
--cc=robh@kernel.org \
--cc=srinavmani@axiado.com \
--cc=twei@axiado.com \
--cc=vkoul@kernel.org \
/path/to/YOUR_REPLY
https://kernel.org/pub/software/scm/git/docs/git-send-email.html
* If your mail client supports setting the In-Reply-To header
via mailto: links, try the mailto: link
Be sure your reply has a Subject: header at the top and a blank line
before the message body.
This is a public inbox, see mirroring instructions
for how to clone and mirror all data and code used for this inbox